Changes in / [22a0e87:88ac843e]

Location:

src

Files:

• AST/Type.cpp (modified) (2 diffs)
• AST/Type.hpp (modified) (1 diff)
• GenPoly/GenPoly.cc (modified) (5 diffs)
• GenPoly/GenPoly.h (modified) (6 diffs)
• GenPoly/ScrubTyVars.cc (modified) (4 diffs)
• ResolvExpr/SatisfyAssertions.cpp (modified) (1 diff)
• SymTab/Mangler.cc (modified) (4 diffs)
• SymTab/Mangler.h (modified) (4 diffs)
• Virtual/ExpandCasts.cc (modified) (2 diffs)

src/AST/Type.cpp

@@ -147 +147 @@
 // --- TypeInstType
 
-bool TypeInstType::operator==( const TypeInstType & other ) const {
-        return base == other.base
-                && formal_usage == other.formal_usage
-                && expr_id == other.expr_id;
-}
-
 TypeInstType::TypeInstType( const TypeDecl * b,
         CV::Qualifiers q, std::vector<ptr<Attribute>> && as )
@@ -163 +157 @@
 
 bool TypeInstType::isComplete() const { return base->sized; }
-
-std::string TypeInstType::TypeEnvKey::typeString() const {
-        return std::string("_") + std::to_string(formal_usage)
-                + "_" + std::to_string(expr_id) + "_" + base->name;
-}
-
-bool TypeInstType::TypeEnvKey::operator==(
-                const TypeInstType::TypeEnvKey & other ) const {
-        return base == other.base
-                && formal_usage == other.formal_usage
-                && expr_id == other.expr_id;
-}
-
-bool TypeInstType::TypeEnvKey::operator<(
-                const TypeInstType::TypeEnvKey & other ) const {
-        // TypeEnvKey ordering is an arbitrary total ordering.
-        // It doesn't mean anything but allows for a sorting.
-        if ( base < other.base ) {
-                return true;
-        } else if ( other.base < base ) {
-                return false;
-        } else if ( formal_usage < other.formal_usage ) {
-                return true;
-        } else if ( other.formal_usage < formal_usage ) {
-                return false;
-        } else {
-                return expr_id < other.expr_id;
-        }
-}
 
 // --- TupleType

src/AST/Type.hpp

@@ -408 +408 @@
 
                 TypeEnvKey() = default;
-                TypeEnvKey(const TypeDecl * base, int formal_usage = 0, int expr_id = 0)
-                : base(base), formal_usage(formal_usage), expr_id(expr_id) {}
-                TypeEnvKey(const TypeInstType & inst)
-                : base(inst.base), formal_usage(inst.formal_usage), expr_id(inst.expr_id) {}
-                std::string typeString() const;
-                bool operator==(const TypeEnvKey & other) const;
-                bool operator<(const TypeEnvKey & other) const;
+                TypeEnvKey(const TypeDecl * base, int formal_usage = 0, int expr_id = 0): base(base), formal_usage(formal_usage), expr_id(expr_id) {}
+                TypeEnvKey(const TypeInstType & inst): base(inst.base), formal_usage(inst.formal_usage), expr_id(inst.expr_id) {}
+                std::string typeString() const { return std::string("_") + std::to_string(formal_usage) + "_" + std::to_string(expr_id) + "_" + base->name; }
+                bool operator==(const TypeEnvKey & other) const { return base == other.base && formal_usage == other.formal_usage && expr_id == other.expr_id; }
         };
 
-        bool operator==(const TypeInstType & other) const;
+        bool operator==(const TypeInstType & other) const { return base == other.base && formal_usage == other.formal_usage && expr_id == other.expr_id; }
 
         TypeInstType(

src/GenPoly/GenPoly.cc

@@ -10 +10 @@
 // Created On       : Mon May 18 07:44:20 2015
 // Last Modified By : Andrew Beach
-// Last Modified On : Mon Oct 24 15:19:00 2022
-// Update Count     : 17
+// Last Modified On : Fri Oct  7 15:25:00 2022
+// Update Count     : 16
 //
 
@@ -194 +194 @@
 
         if ( auto inst = dynamic_cast< const ast::TypeInstType * >( type ) ) {
-                if ( typeVars.find( *inst ) != typeVars.end() ) return type;
+                if ( typeVars.find( inst->typeString() ) != typeVars.end() ) return type;
         } else if ( auto array = dynamic_cast< const ast::ArrayType * >( type ) ) {
                 return isPolyType( array->base, subst );
@@ -227 +227 @@
 
         if ( auto inst = dynamic_cast<ast::TypeInstType const *>( type ) ) {
-                auto var = typeVars.find( *inst );
+                auto var = typeVars.find( inst->name );
                 if ( var != typeVars.end() && var->second.isComplete ) {
 
@@ -784 +784 @@
 
 void addToTypeVarMap( const ast::TypeInstType * type, TypeVarMap & typeVars ) {
-        typeVars.insert( *type, ast::TypeDecl::Data( type->base ) );
+        typeVars.insert( type->typeString(), ast::TypeDecl::Data( type->base ) );
 }
 
@@ -816 +816 @@
         }
 
+void printTypeVarMap( std::ostream &os, const TypeVarMap & typeVars ) {
+        for ( auto const & pair : typeVars ) {
+                os << pair.first << " (" << pair.second << ") ";
+        } // for
+        os << std::endl;
+}
+
 } // namespace GenPoly
 

src/GenPoly/GenPoly.h

@@ -10 +10 @@
 // Created On       : Mon May 18 07:44:20 2015
 // Last Modified By : Andrew Beach
-// Last Modified On : Mon Oct 24 15:18:00 2022
-// Update Count     : 11
+// Last Modified On : Fri Oct  7 15:06:00 2022
+// Update Count     : 9
 //
 
@@ -22 +22 @@
 #include "AST/Decl.hpp"           // for TypeDecl::Data
 #include "AST/Fwd.hpp"            // for ApplicationExpr, BaseInstType, Func...
-#include "AST/Type.hpp"           // for TypeInstType::TypeEnvKey
 #include "SymTab/Mangler.h"       // for Mangler
 #include "SynTree/Declaration.h"  // for TypeDecl::Data, AggregateDecl, Type...
@@ -29 +28 @@
 namespace GenPoly {
 
+        // TODO Via some tricks this works for ast::TypeDecl::Data as well.
         typedef ErasableScopedMap< std::string, TypeDecl::Data > TyVarMap;
-        using TypeVarMap = ErasableScopedMap< ast::TypeInstType::TypeEnvKey, ast::TypeDecl::Data >;
+        using TypeVarMap = ErasableScopedMap< std::string, ast::TypeDecl::Data >;
 
         /// Replaces a TypeInstType by its referrent in the environment, if applicable
         Type* replaceTypeInst( Type* type, const TypeSubstitution* env );
-        const ast::Type * replaceTypeInst( const ast::Type *, const ast::TypeSubstitution * );
 
         /// returns polymorphic type if is polymorphic type, NULL otherwise; will look up substitution in env if provided
@@ -54 +53 @@
         /// true iff function has dynamic-layout return type under the type variable map generated from its forall-parameters
         ReferenceToType *isDynRet( FunctionType *function );
-        const ast::BaseInstType *isDynRet( const ast::FunctionType * func );
 
         /// A function needs an adapter if it returns a dynamic-layout value or if any of its parameters have dynamic-layout type
@@ -114 +112 @@
         /// Prints type variable map
         void printTyVarMap( std::ostream &os, const TyVarMap &tyVarMap );
+        void printTypeVarMap( std::ostream &os, const TypeVarMap & typeVars );
 
         /// Gets the mangled name of this type; alias for SymTab::Mangler::mangleType().
@@ -129 +128 @@
         /// Gets the name of the layout function for a given aggregate type, given its declaration
         inline std::string layoutofName( AggregateDecl *decl ) { return std::string( "_layoutof_" ) + decl->get_name(); }
-        inline std::string layoutofName( ast::AggregateDecl const * decl ) {
-                return std::string( "_layoutof_" ) + decl->name;
-        }
 
 } // namespace GenPoly

src/GenPoly/ScrubTyVars.cc

@@ -20 +20 @@
 #include "GenPoly/ErasableScopedMap.h"  // for ErasableScopedMap<>::const_it...
 #include "ScrubTyVars.h"
-#include "SymTab/Mangler.h"             // for mangleType
+#include "SymTab/Mangler.h"             // for mangle, typeMode
 #include "SynTree/Declaration.h"        // for TypeDecl, TypeDecl::Data, Typ...
 #include "SynTree/Expression.h"         // for Expression (ptr only), NameExpr
@@ -195 +195 @@
         }
 
-        auto typeVar = typeVars->find( *type );
+        auto typeVar = typeVars->find( type->name );
         if ( typeVar == typeVars->end() ) {
                 return type;
@@ -227 +227 @@
         if ( dynType ) {
                 return new ast::NameExpr( expr->location,
-                        sizeofName( Mangle::mangleType( dynType ) ) );
+                        sizeofName( Mangle::mangle( dynType, Mangle::typeMode() ) ) );
         } else {
                 return expr;
@@ -237 +237 @@
         if ( dynType ) {
                 return new ast::NameExpr( expr->location,
-                        alignofName( Mangle::mangleType( dynType ) ) );
+                        alignofName( Mangle::mangle( dynType, Mangle::typeMode() ) ) );
         } else {
                 return expr;

src/ResolvExpr/SatisfyAssertions.cpp

@@ -268 +268 @@
                 ast::ptr< ast::Type > resType = cand.expr->result;
                 cand.env.apply( resType );
-                return Mangle::mangleType( resType );
+                return Mangle::mangle( resType, Mangle::typeMode() );
         }
 

src/SymTab/Mangler.cc

@@ -9 +9 @@
 // Author           : Richard C. Bilson
 // Created On       : Sun May 17 21:40:29 2015
-// Last Modified By : Andrew Beach
-// Last Modified On : Fri Oct 21 16:18:00 2022
-// Update Count     : 75
+// Last Modified By : Peter A. Buhr
+// Last Modified On : Mon Jan 11 21:56:06 2021
+// Update Count     : 74
 //
 #include "Mangler.h"
@@ -418 +418 @@
                         void postvisit( const ast::QualifiedType * qualType );
 
-                        /// The result is the current constructed mangled name.
-                        std::string result() const { return mangleName; }
+                        std::string get_mangleName() { return mangleName; }
                   private:
                         std::string mangleName;         ///< Mangled name being constructed
@@ -445 +444 @@
         } // namespace
 
+
         std::string mangle( const ast::Node * decl, Mangle::Mode mode ) {
-                return ast::Pass<Mangler_new>::read( decl, mode );
+                ast::Pass<Mangler_new> mangler( mode );
+                maybeAccept( decl, mangler );
+                return mangler.core.get_mangleName();
         }
 
@@ -687 +689 @@
                                         } // for
                                         for ( auto & assert : ptype->assertions ) {
-                                                assertionNames.push_back( ast::Pass<Mangler_new>::read(
-                                                        assert->var.get(),
-                                                        mangleOverridable, typeMode, mangleGenericParams, nextVarNum, varNums ) );
+                                                ast::Pass<Mangler_new> sub_mangler(
+                                                        mangleOverridable, typeMode, mangleGenericParams, nextVarNum, varNums );
+                                                assert->var->accept( sub_mangler );
+                                                assertionNames.push_back( sub_mangler.core.get_mangleName() );
                                                 acount++;
                                         } // for

src/SymTab/Mangler.h

@@ -9 +9 @@
 // Author           : Richard C. Bilson
 // Created On       : Sun May 17 21:44:03 2015
-// Last Modified By : Andrew Beach
-// Last Modified On : Thu Oct 27 11:58:00 2022
-// Update Count     : 16
+// Last Modified By : Peter A. Buhr
+// Last Modified On : Sat Jul 22 09:45:30 2017
+// Update Count     : 15
 //
 
@@ -22 +22 @@
 
 #include "AST/Bitfield.hpp"
+#include "AST/Fwd.hpp"
 #include "SynTree/SynTree.h"  // for Types
 #include "SynTree/Visitor.h"  // for Visitor, maybeAccept
@@ -32 +33 @@
 // * Currently name compression is not implemented.
 
-namespace ast {
-        class Node;
-}
 namespace ResolvExpr {
         class TypeEnvironment;
@@ -103 +101 @@
         using Mode = bitfield<mangle_flags>;
 
-        /// Mangle declaration name.
+        static inline Mode typeMode() { return NoOverrideable | Type; }
+
+        /// Mangle declaration name
         std::string mangle( const ast::Node * decl, Mode mode = {} );
-
-        /// Most common mangle configuration for types.
-        static inline std::string mangleType( const ast::Node * type ) {
-                return mangle( type, { NoOverrideable | Type } );
-        }
 
         namespace Encoding {

src/Virtual/ExpandCasts.cc

@@ -295 +295 @@
         // returns the previous declaration for error messages.
         ast::ObjectDecl const * insert( ast::ObjectDecl const * typeIdDecl ) {
-                std::string mangledName = Mangle::mangleType( typeIdDecl->type );
+                std::string const & mangledName =
+                                Mangle::mangle( typeIdDecl->type, Mangle::typeMode() );
                 ast::ObjectDecl const *& value = instances[ mangledName ];
                 if ( value ) {
@@ -309 +310 @@
 
         ast::ObjectDecl const * lookup( ast::Type const * typeIdType ) {
-                std::string mangledName = Mangle::mangleType( typeIdType );
+                std::string const & mangledName =
+                                Mangle::mangle( typeIdType, Mangle::typeMode() );
                 auto const it = instances.find( mangledName );
                 return ( instances.end() == it ) ? nullptr : it->second;