Changeset 861799c for src/SymTab

Timestamp:

Mar 10, 2017, 11:00:13 AM (8 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

c857ad3

Parents:

0e7ea335

Message:

fix 0,1 member access, fix autogenerated routines missing size for sized generic types

Location:

src/SymTab

Files:

• Autogen.cc (modified) (1 diff)
• Validate.cc (modified) (2 diffs)

src/SymTab/Autogen.cc

@@ -151 +151 @@
         bool hasDynamicLayout( AggrDecl * aggregateDecl ) {
                 for ( TypeDecl * param : aggregateDecl->get_parameters() ) {
-                        if ( param->get_kind() == TypeDecl::Any ) return true;
+                        if ( param->isComplete() ) return true;
                 }
                 return false;

src/SymTab/Validate.cc

@@ -224 +224 @@
                 HoistStruct::hoistStruct( translationUnit );
                 ReturnTypeFixer::fix( translationUnit ); // must happen before autogen
+                acceptAll( translationUnit, lrt ); // must happen before autogen, because sized flag needs to propagate to generated functions
                 autogenerateRoutines( translationUnit ); // moved up, used to be below compoundLiteral - currently needs EnumAndPointerDecayPass
                 acceptAll( translationUnit, epc );
-                acceptAll( translationUnit, lrt );
                 ReturnChecker::checkFunctionReturns( translationUnit );
                 compoundliteral.mutateDeclarationList( translationUnit );
@@ -838 +838 @@
                 assertf( retVals.size() == 0 || retVals.size() == 1, "Function %s has too many return values: %d", functionDecl->get_name().c_str(), retVals.size() );
                 if ( retVals.size() == 1 ) {
-                        // ensure all function return values have a name - use the name of the function to disambiguate (this also provides a nice bit of help for debugging)
-                        // ensure other return values have a name
+                        // ensure all function return values have a name - use the name of the function to disambiguate (this also provides a nice bit of help for debugging).
+                        // ensure other return values have a name.
                         DeclarationWithType * ret = retVals.front();
                         if ( ret->get_name() == "" ) {