Changes in libcfa/src/exception.c [73530d9:851fd92]

File:

• libcfa/src/exception.c (modified) (17 diffs)

libcfa/src/exception.c

@@ -10 +10 @@
 // Created On       : Mon Jun 26 15:13:00 2017
 // Last Modified By : Andrew Beach
-// Last Modified On : Fri Apr 03 11:57:00 2020
-// Update Count     : 14
+// Last Modified On : Tue Apr 14 12:01:00 2020
+// Update Count     : 18
 //
 
@@ -28 +28 @@
 #include <unwind.h>
 #include <bits/debug.hfa>
+#include "stdhdr/assert.h"
 
 // FIX ME: temporary hack to keep ARM build working
@@ -75 +76 @@
 // RESUMPTION ================================================================
 
+static void reset_top_resume(struct __cfaehm_try_resume_node ** store) {
+        this_exception_context()->top_resume = *store;
+}
+
 void __cfaehm_throw_resume(exception_t * except) {
         struct exception_context_t * context = this_exception_context();
 
-        __cfaabi_dbg_print_safe("Throwing resumption exception\n");
-
+        __cfadbg_print_safe(exception, "Throwing resumption exception\n");
+
+        __attribute__((cleanup(reset_top_resume)))
         struct __cfaehm_try_resume_node * original_head = context->top_resume;
         struct __cfaehm_try_resume_node * current = context->top_resume;
@@ -86 +92 @@
                 context->top_resume = current->next;
                 if (current->handler(except)) {
-                        context->top_resume = original_head;
                         return;
                 }
         }
 
-        __cfaabi_dbg_print_safe("Unhandled exception\n");
-        context->top_resume = original_head;
+        __cfadbg_print_safe(exception, "Unhandled exception\n");
 
         // Fall back to termination:
@@ -176 +180 @@
         struct exception_context_t * context = this_exception_context();
 
-        __cfaabi_dbg_print_safe("Deleting Exception\n");
+        __cfadbg_print_safe(exception, "Deleting Exception\n");
 
         // Remove the exception from the list.
@@ -213 +217 @@
                 struct _Unwind_Context * unwind_context,
                 void * stop_param) {
-        if ( actions & _UA_END_OF_STACK  ) exit(1);
-        if ( actions & _UA_CLEANUP_PHASE ) return _URC_NO_REASON;
-
-        return _URC_FATAL_PHASE2_ERROR;
+        // Verify actions follow the rules we expect.
+        verify((actions & _UA_CLEANUP_PHASE) && (actions & _UA_FORCE_UNWIND));
+        verify(!(actions & (_UA_SEARCH_PHASE | _UA_HANDER_FRAME)));
+
+        if ( actions & _UA_END_OF_STACK ) {
+                exit(1);
+        } else {
+                return _URC_NO_REASON;
+        }
 }
 
@@ -252 +261 @@
 
 void __cfaehm_throw_terminate( exception_t * val ) {
-        __cfaabi_dbg_print_safe("Throwing termination exception\n");
+        __cfadbg_print_safe(exception, "Throwing termination exception\n");
 
         __cfaehm_allocate_exception( val );
@@ -259 +268 @@
 
 void __cfaehm_rethrow_terminate(void) {
-        __cfaabi_dbg_print_safe("Rethrowing termination exception\n");
+        __cfadbg_print_safe(exception, "Rethrowing termination exception\n");
 
         __cfaehm_begin_unwind();
@@ -275 +284 @@
 {
 
-        //__cfaabi_dbg_print_safe("CFA: 0x%lx\n", _Unwind_GetCFA(context));
-        __cfaabi_dbg_print_safe("Personality function (%d, %x, %llu, %p, %p):",
+        //__cfadbg_print_safe(exception, "CFA: 0x%lx\n", _Unwind_GetCFA(context));
+        __cfadbg_print_safe(exception, "Personality function (%d, %x, %llu, %p, %p):",
                         version, actions, exception_class, unwind_exception, unwind_context);
 
-        // If we've reached the end of the stack then there is nothing much we can do...
-        if (actions & _UA_END_OF_STACK) return _URC_END_OF_STACK;
-
+        // Verify that actions follow the rules we expect.
+        // This function should never be called at the end of the stack.
+        verify(!(actions & _UA_END_OF_STACK));
+        // Either only the search phase flag is set or...
         if (actions & _UA_SEARCH_PHASE) {
-                __cfaabi_dbg_print_safe(" lookup phase");
-        }
-        else if (actions & _UA_CLEANUP_PHASE) {
-                __cfaabi_dbg_print_safe(" cleanup phase");
-        }
-        // Just in case, probably can't actually happen
-        else {
-                printf(" error\n");
-                return _URC_FATAL_PHASE1_ERROR;
+                verify(actions == _UA_SEARCH_PHASE);
+                __cfadbg_print_safe(exception, " lookup phase");
+        // ... we are in clean-up phase.
+        } else {
+                verify(actions & _UA_CLEANUP_PHASE);
+                __cfadbg_print_safe(exception, " cleanup phase");
+                // We shouldn't be the handler frame during forced unwind.
+                if (actions & _UA_HANDLER_FRAME) {
+                        verify(!(actions & _UA_FORCE_UNWIND));
+                        __cfadbg_print_safe(exception, " (handler frame)");
+                } else if (actions & _UA_FORCE_UNWIND) {
+                        __cfadbg_print_safe(exception, " (force unwind)");
+                }
         }
 
@@ -331 +345 @@
                         void * ep = (void*)lsd_info.Start + callsite_start + callsite_len;
                         void * ip = (void*)instruction_ptr;
-                        __cfaabi_dbg_print_safe("\nfound %p - %p (%p, %p, %p), looking for %p\n",
+                        __cfadbg_print_safe(exception, "\nfound %p - %p (%p, %p, %p), looking for %p\n",
                                         bp, ep, ls, cs, cl, ip);
 #endif // __CFA_DEBUG_PRINT__
@@ -346 +360 @@
                 if ( 0 == callsite_landing_pad ) {
                         // Nothing to do, move along
-                        __cfaabi_dbg_print_safe(" no landing pad");
+                        __cfadbg_print_safe(exception, " no landing pad");
                 } else if (actions & _UA_SEARCH_PHASE) {
                         // In search phase, these means we found a potential handler we must check.
@@ -384 +398 @@
                                 // Based on the return value, check if we matched the exception
                                 if (ret == _URC_HANDLER_FOUND) {
-                                        __cfaabi_dbg_print_safe(" handler found\n");
+                                        __cfadbg_print_safe(exception, " handler found\n");
                                 } else {
-                                        __cfaabi_dbg_print_safe(" no handler\n");
+                                        __cfadbg_print_safe(exception, " no handler\n");
                                 }
                                 return ret;
@@ -392 +406 @@
 
                         // This is only a cleanup handler, ignore it
-                        __cfaabi_dbg_print_safe(" no action");
-                } else if (actions & _UA_CLEANUP_PHASE) {
+                        __cfadbg_print_safe(exception, " no action");
+                } else {
                         // In clean-up phase, no destructors here but this could be the handler.
 
@@ -414 +428 @@
                         _Unwind_SetIP( unwind_context, ((lsd_info.LPStart) + (callsite_landing_pad)) );
 
-                        __cfaabi_dbg_print_safe(" action\n");
+                        __cfadbg_print_safe(exception, " action\n");
 
                         // Return have some action to run
@@ -421 +435 @@
         }
         // No handling found
-        __cfaabi_dbg_print_safe(" table end reached\n");
+        __cfadbg_print_safe(exception, " table end reached");
 
         UNWIND:
-        __cfaabi_dbg_print_safe(" unwind\n");
+        __cfadbg_print_safe(exception, " unwind\n");
 
         // Keep unwinding the stack
@@ -431 +445 @@
 
 #pragma GCC push_options
-#pragma GCC optimize("O0")
+#pragma GCC optimize(0)
 
 // Try statements are hoisted out see comments for details. While this could probably be unique
@@ -528 +542 @@
         "       .quad __gcfa_personality_v0\n"
 #else // then __i386
-        "   .long __gcfa_personality_v0\n"
+        "       .long __gcfa_personality_v0\n"
 #endif
 );