Changeset 804bf677 for tests/collections

Timestamp:

Oct 13, 2021, 9:52:02 PM (3 years ago)

Author:

Michael Brooks <mlbrooks@…>

Branches:

ADT, ast-experimental, enum, master, pthread-emulation, qualifiedEnum

Children:

7b0e8b7

Parents:

4b3b352

Message:

String hybrid: Basic cases of solo alloc now working

Location:

tests/collections

Files:

• .expect/string-ctx-manage.txt (modified) (1 diff)
• string-ctx-manage.cfa (modified) (2 diffs)

tests/collections/.expect/string-ctx-manage.txt

@@ -3 +3 @@
 hi
 bye
+hi
 done

tests/collections/string-ctx-manage.cfa

@@ -24 +24 @@
     sout | y; // hi
 
-    x = "bye";                                                     //.... Bookmark 9/30 shallow:  surprisingly this step failed
+    x = "bye";
     y = x; // y was already in different context => eager copy
     assert( y.inner->Handle.s != x.inner->Handle.s);
@@ -30 +30 @@
 }
 
-void failSoloAlloc() {
+void soloAlloc() {
     string x = "hi";
     string_sharectx c = { NO_SHARING };
+    
+    string y = x; // y allocates into private pad, implying eager copy
+    assert( y.inner->Handle.s != x.inner->Handle.s);
+    sout | y; // hi
 
-    // want: allocation into private pad, with forced eager copy into it
-    // got: assertion failure, "Need to implement private contexts"
-    string y = x;
+    // -- following hits "need to implement actual growth"
+    //    and it passes if I modify string_res.cfa to oversize the owned heaps
+
+    // x = "bye";
+    // y = x; // into private y => eager copy
+    // assert( y.inner->Handle.s != x.inner->Handle.s);
+    // sout | y; // bye
 }
 
-volatile bool showFail = false;
 
 int main() {
     baseline();
     eagerCopy();
-    if (showFail) {
-        failSoloAlloc();
-    }
+    soloAlloc();
     printf("done\n");
 }