Changes in src/ResolvExpr/AlternativeFinder.cc [cc4218f:7d01cf44]

File:

• src/ResolvExpr/AlternativeFinder.cc (modified) (8 diffs)

src/ResolvExpr/AlternativeFinder.cc

@@ -9 +9 @@
 // Author           : Richard C. Bilson
 // Created On       : Sat May 16 23:52:08 2015
-// Last Modified By : Peter A. Buhr
-// Last Modified On : Thu Jul 25 22:37:46 2019
-// Update Count     : 37
+// Last Modified By : Andrew Beach
+// Last Modified On : Thu Aug  8 16:35:00 2019
+// Update Count     : 38
 //
 
@@ -377 +377 @@
         }
 
-        Cost computeConversionCost( Type * actualType, Type * formalType, const SymTab::Indexer &indexer, const TypeEnvironment & env ) {
+        Cost computeConversionCost( Type * actualType, Type * formalType, bool actualIsLvalue,
+                        const SymTab::Indexer &indexer, const TypeEnvironment & env ) {
                 PRINT(
                         std::cerr << std::endl << "converting ";
@@ -387 +388 @@
                         std::cerr << std::endl;
                 )
-                Cost convCost = conversionCost( actualType, formalType, indexer, env );
+                Cost convCost = conversionCost( actualType, formalType, actualIsLvalue, indexer, env );
                 PRINT(
                         std::cerr << std::endl << "cost is " << convCost << std::endl;
@@ -402 +403 @@
 
         Cost computeExpressionConversionCost( Expression *& actualExpr, Type * formalType, const SymTab::Indexer &indexer, const TypeEnvironment & env ) {
-                Cost convCost = computeConversionCost( actualExpr->result, formalType, indexer, env );
+                Cost convCost = computeConversionCost(
+                        actualExpr->result, formalType, actualExpr->get_lvalue(), indexer, env );
 
                 // if there is a non-zero conversion cost, ignoring poly cost, then the expression requires conversion.
@@ -1135 +1137 @@
         bool isLvalue( Expression *expr ) {
                 // xxx - recurse into tuples?
-                return expr->result && ( expr->result->get_lvalue() || dynamic_cast< ReferenceType * >( expr->result ) );
+                return expr->result && ( expr->get_lvalue() || dynamic_cast< ReferenceType * >( expr->result ) );
         }
 
@@ -1186 +1188 @@
                 assert( toType );
                 toType = resolveTypeof( toType, indexer );
-                assert(!dynamic_cast<TypeofType *>(toType));
                 SymTab::validateType( toType, &indexer );
                 adjustExprType( toType, env, indexer );
@@ -1213 +1214 @@
                         unify( castExpr->result, alt.expr->result, alt.env, needAssertions,
                                 haveAssertions, openVars, indexer );
-                        Cost thisCost = castCost( alt.expr->result, castExpr->result, indexer,
-                                alt.env );
+                        Cost thisCost = castCost( alt.expr->result, castExpr->result, alt.expr->get_lvalue(),
+                                indexer, alt.env );
                         PRINT(
                                 std::cerr << "working on cast with result: " << castExpr->result << std::endl;
@@ -1641 +1642 @@
                                 // xxx - do some inspecting on this line... why isn't result bound to initAlt.type?
 
-                                Cost thisCost = castCost( alt.expr->result, toType, indexer, newEnv );
+                                Cost thisCost = castCost( alt.expr->result, toType, alt.expr->get_lvalue(),
+                                        indexer, newEnv );
                                 if ( thisCost != Cost::infinity ) {
                                         // count one safe conversion for each value that is thrown away