Changeset 7ce8873 for libcfa

Timestamp:

Jul 28, 2022, 12:03:16 PM (2 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, ast-experimental, master, pthread-emulation

Children:

3f95dab

Parents:

e8616b6

Message:

Added some io stats

Location:

libcfa/src/concurrency

Files:

• io.cfa (modified) (1 diff)
• io/call.cfa.in (modified) (2 diffs)
• io/setup.cfa (modified) (2 diffs)
• stats.cfa (modified) (3 diffs)
• stats.hfa (modified) (1 diff)

libcfa/src/concurrency/io.cfa

@@ -432 +432 @@
 
                 disable_interrupts();
+                __STATS__( true, if(!lazy) io.submit.eagr += 1; )
                 processor * proc = __cfaabi_tls.this_processor;
                 $io_context * ctx = proc->io.ctx;

libcfa/src/concurrency/io/call.cfa.in

@@ -34 +34 @@
 #include "kernel.hfa"
 #include "io/types.hfa"
+#include "stats.hfa"
 
 //=============================================================================================
@@ -226 +227 @@
         async_{name}( future, {args}, submit_flags );
 
-        wait( future );
+        __attribute__((unused)) bool parked;
+        parked = wait( future );
+        __STATS__(false, if(!parked) io.submit.nblk += 1; )
         if( future.result < 0 ) {{
                 errno = -future.result;

libcfa/src/concurrency/io/setup.cfa

@@ -229 +229 @@
                 #if !defined(CFA_WITH_IO_URING_IDLE)
                         // Step 4 : eventfd
-                        // io_uring_register is so f*cking slow on some machine that it
-                        // will never succeed if preemption isn't hard blocked
                         __cfadbg_print_safe(io_core, "Kernel I/O : registering %d for completion with ring %d\n", procfd, fd);
 
@@ -240 +238 @@
                         __cfadbg_print_safe(io_core, "Kernel I/O : registered %d for completion with ring %d\n", procfd, fd);
                 #endif
+
+                // #if defined(CFA_HAVE_IORING_REGISTER_IOWQ_MAX_WORKERS)
+                //      // Step 5 : max worker count
+                //      __cfadbg_print_safe(io_core, "Kernel I/O : lmiting max workers for ring %d\n", fd);
+
+                //      unsigned int maxes[2];
+                //      maxes[0] = 64; // max number of bounded workers (Regular files / block)
+                //      maxes[1] = 64;  // max number of unbounded workers (IOSQE_ASYNC)
+                //      int ret = syscall( __NR_io_uring_register, fd, IORING_REGISTER_IOWQ_MAX_WORKERS, maxes, 2);
+                //      if (ret < 0) {
+                //              abort("KERNEL ERROR: IO_URING MAX WORKER REGISTER - %s\n", strerror(errno));
+                //      }
+
+                //      __cfadbg_print_safe(io_core, "Kernel I/O : lmited max workers for ring %d\n", fd);
+                // #endif
 
                 // some paranoid checks

libcfa/src/concurrency/stats.cfa

@@ -46 +46 @@
                         stats->io.submit.fast       = 0;
                         stats->io.submit.slow       = 0;
+                        stats->io.submit.eagr       = 0;
+                        stats->io.submit.nblk       = 0;
                         stats->io.flush.external    = 0;
                         stats->io.flush.dirty       = 0;
@@ -116 +118 @@
                         tally_one( &cltr->io.submit.fast      , &proc->io.submit.fast       );
                         tally_one( &cltr->io.submit.slow      , &proc->io.submit.slow       );
+                        tally_one( &cltr->io.submit.eagr      , &proc->io.submit.eagr       );
+                        tally_one( &cltr->io.submit.nblk      , &proc->io.submit.nblk       );
                         tally_one( &cltr->io.flush.external   , &proc->io.flush.external    );
                         tally_one( &cltr->io.flush.dirty      , &proc->io.flush.dirty       );
@@ -197 +201 @@
                                         sstr | "fast," | eng3(io.submit.slow) | "slow (" | ws(3, 3, avgfasts) | "%)" | nonl;
                                 }
+                                sstr | " - eager" | eng3(io.submit.eagr) | nonl;
+                                sstr | " - no-wait" | eng3(io.submit.nblk) | nonl;
                                 sstr | nl;
 

libcfa/src/concurrency/stats.hfa

@@ -92 +92 @@
                                 volatile uint64_t fast;
                                 volatile uint64_t slow;
+                                volatile uint64_t eagr;
+                                volatile uint64_t nblk;
                         } submit;
                         struct {