Changeset 7cd23d5

Timestamp:

Nov 26, 2015, 6:06:12 PM (9 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, ctor, deferred_resn, demangler, enum, forall-pointer-decay, gc_noraii, jacob/cs343-translation, jenkins-sandbox, master, memory, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, string, with_gc

Children:

ed1065c

Parents:

13ca524

Message:

Revert "fixed adapter suffix naming scheme"

This reverts commit 43ffef1bb4f4f9fa7b91108113708cad3f6e2a61.

File:

• src/InitTweak/RemoveInit.cc (modified) (2 diffs)

src/InitTweak/RemoveInit.cc

@@ -9 +9 @@
 // Author           : Rodolfo G. Esteves
 // Created On       : Mon May 18 07:44:20 2015
-// Last Modified By : Rob Schluntz
-// Last Modified On : Mon Nov 16 16:58:36 2015
-// Update Count     : 30
+// Last Modified By : Peter A. Buhr
+// Last Modified On : Tue May 19 16:39:32 2015
+// Update Count     : 1
 //
 
@@ -21 +21 @@
 #include "SynTree/Initializer.h"
 #include "SynTree/Mutator.h"
-
-// changes to Validate:
-// -check that ctor/dtor has >= 1 argument
-// -check that first argument to ctor/dtor has pointer type
-// -check that return type is void (0 return types)
-// -transform ctor to return its first argument
-// -generate ctors and dtors alongside ?=? for aggregate types 
-
-// idea: modify this pass to decide whether an object declaration is
-// POD type. 
-// - If it is not POD-type, initialization should be changed into 
-//   a constructor call. 
-// - If it is a POD type, then check that there are no designations. 
-//   It is probably easiest to leave the declaration in C-initializer
-//   form and resolve as normal, since we don't want to actually incur
-//   the cost of a constructor unless we have to.
-
-// change indexer to remove all constructors for a type once a user-defined one appears?
-
-// question: if a destructor is declared before the scope of a variable ends, 
-// should it be destructed? Or should we decide this at declaration point?
-
-
-// alternative (that I think I like better, if there aren't any flaws)
-//   --flaw appears to be the exponential blowup in the number of ctors described below
-// change into constructor form if no designations
-// if not POD type, error out if there are designations
-// if there are designations, handle them in the resolver
-
-// ==MAYBE== even possible to rewrite designations not as ?=?, but as ?{} (see initialization.txt)
-// there may be some transformation that's required to bring this back into a reasonable form
-// for codegen, it'll depend on exactly what the expressions that are fed to the resolver look like
-// e.g.
-
-// struct A {
-//   struct B { int x; } b;
-//   struct C { int x, y, z } c;
-//   struct D { int x; } d;
-// }
-//
-// A a = { 1, 2, 3, 4, 5 };
-// => struct A a;
-//    ?{}(&a.b, (struct B){ 1 } );
-//    ?{}(&a.c, (struct C){ 2, 3, 4 } );
-//    ?{}(&a.d, (struct D){ 5 } );
-// (it obviously shouldn't look like this, but what should it look like??)
-//
-// (perhaps this?)
-// => struct A a;
-//    ?{}(&a, (struct B){ 1 }, (struct C){ 2, 3, 4 }, (struct D){ 5 });
-// (of course, this requires me to do the grouping found here,
-//  and remember that parts might be missing! That said, I'm essentially
-//  already doing this in the resolver, so whatever I guess?)
-// (note this requires an alternative finder, because these may be
-//  function calls, not just simple literals)
-// (this is a bit of a recursive problem - in order to know how to group
-//  the expressions into a struct to be an argument to a constructor, I need to
-//  know what the constructor's signature looks like - but in order to figure out
-//  which constructor is being used (and thus what its signature looks like), I need
-//  to group the values into a struct type)
-// (this seems to imply (to me, anyway) that C initializers can't be represented as 
-//  constructors without an exponential blowup in the number of constructors present)
 
 namespace InitTweak {