Changeset 7959e56 for src

Timestamp:

Feb 3, 2025, 1:27:20 PM (8 weeks ago)

Author:

Michael Brooks <mlbrooks@…>

Branches:

master

Children:

dfe8f78

Parents:

59fdd0d

Message:

Eliminate libcfa-build warnings of missing int-to-pointer casts.

Replace a zero_t variable use with literal 0 when it's an argument to an intrinsic and we're generating final C code. Partially revert e0330d2cd1a. Such intrinsics are initialization/assignment of pointers; using the variable implies a missing cast, while using literal 0 needs no cast.

CodeGenerator?.hpp
CodeGenerator?.cpp

Put attibute unused on all zero_t/one_t object decls. It is needed on those whose uses are rewritten by the rule above.

Generate.cpp

Location:

src/CodeGen

Files:

• CodeGenerator.cpp (modified) (4 diffs)
• CodeGenerator.hpp (modified) (1 diff)
• Generate.cpp (modified) (2 diffs)

src/CodeGen/CodeGenerator.cpp ¶

@@ -130 +130 @@
         // TODO: Which means the ast::Pass is just providing a default no visit?
         visit_children = false;
+        changeState_ArgToIntrinsic(false);
 }
 
@@ -466 +467 @@
                 if ( var->var->linkage == ast::Linkage::Intrinsic &&
                                 ( opInfo = operatorLookup( var->var->name ) ) ) {
+                        changeState_ArgToIntrinsic(true);
                         auto arg = expr->args.begin();
                         switch ( opInfo->type ) {
@@ -558 +560 @@
         if ( auto name = expr->func.as<ast::NameExpr>() ) {
                 if ( const OperatorInfo * opInfo = operatorLookup( name->name ) ) {
+                        changeState_ArgToIntrinsic(true);
                         auto arg = expr->args.begin();
                         switch ( opInfo->type ) {
@@ -743 +746 @@
         extension( expr );
         const OperatorInfo * opInfo;
-        if ( expr->var->linkage == ast::Linkage::Intrinsic
+        if ( visitingArgToIntrinsic
+                        && options.genC
+                        && dynamic_cast<ast::ZeroType const *>( expr->var->get_type() ) ) {
+                // int * p; p = 0;               ==>  ?=?( p, (zero_t){} );  ==>  p = 0;
+                // void f( zero_t z ) { g(z); }  ==>  g(z);                  ==>  g(z);
+                // (we are at the last '==>')
+                output << "0";
+        } else if ( expr->var->linkage == ast::Linkage::Intrinsic
                         && ( opInfo = operatorLookup( expr->var->name ) )
                         && opInfo->type == OT_CONSTANT ) {

src/CodeGen/CodeGenerator.hpp ¶

@@ -181 +181 @@
         void handleTypedef( ast::NamedTypeDecl const * type );
         std::string mangleName( ast::DeclWithType const * decl );
+
+        bool nextVisitedNodeIsArgToIntrinsic = false;
+        bool visitingArgToIntrinsic = false;
+        void changeState_ArgToIntrinsic( bool newValue ) {
+                GuardValue( visitingArgToIntrinsic ) = nextVisitedNodeIsArgToIntrinsic;
+                GuardValue( nextVisitedNodeIsArgToIntrinsic ) = newValue;
+        }
 };
 

src/CodeGen/Generate.cpp ¶

@@ -46 +46 @@
                 }
         };
+
+        struct ZeroOneObjectHider final {
+                ast::ObjectDecl const * postvisit( ast::ObjectDecl const * decl ) {
+                        if ( decl->type.as<ast::ZeroType>() || decl->type.as<ast::OneType>() ) {
+                                ast::ObjectDecl * mutDecl = ast::mutate( decl );
+                                mutDecl->attributes.push_back( new ast::Attribute( "unused" ) );
+                                return mutDecl;
+                        }
+                        return decl;
+                }
+        };
 } // namespace
 
@@ -52 +63 @@
         erase_if( translationUnit.decls, shouldClean );
         ast::Pass<TreeCleaner>::run( translationUnit );
+        ast::Pass<ZeroOneObjectHider>::run( translationUnit );
 
         ast::Pass<CodeGenerator> cgv( os,