Changeset 790f251

Timestamp:

Aug 22, 2024, 2:32:14 PM (4 months ago)

Author:

Peter A. Buhr <pabuhr@…>

Branches:

master

Children:

cc0aa8c

Parents:

df2e00f

Message:

update error message for parameter default-initialization in function-pointer declarations

Files:

• src/Parser/DeclarationNode.cpp (modified) (3 diffs)
• tests/.expect/opt-params.txt (modified) (1 diff)
• tests/opt-params.cfa (modified) (1 diff)

src/Parser/DeclarationNode.cpp

@@ -10 +10 @@
 // Created On       : Sat May 16 12:34:05 2015
 // Last Modified By : Peter A. Buhr
-// Last Modified On : Fri Feb 23 18:25:57 2024
-// Update Count     : 1533
+// Last Modified On : Thu Aug 22 14:11:47 2024
+// Update Count     : 1555
 //
 
@@ -134 +134 @@
                 os << endl << string( indent + 2, ' ' ) << "with initializer ";
                 initializer->printOneLine( os );
-                os << " maybe constructed? " << initializer->get_maybeConstructed();
+                if ( ! initializer->get_maybeConstructed() ) {
+                        os << " constructed with @= ";
+                } // if
         } // if
 
@@ -999 +1001 @@
         assert( type );
 
-        // Some types are parsed as declarations and, syntactically, can have
-        // initializers. However, semantically, this is meaningless.
-        if ( initializer ) {
-                SemanticError( this, "Initializer on type declaration " );
+        // Some types are parsed as declarations and, syntactically, can have initializers, which are not support (possibly
+        // meaningless).
+        if ( initializer && initializer->get_maybeConstructed() ) { // no @=
+                SemanticError( location, "default initialization for parameter %s is unsupport for a function-pointer declaration.",
+                                           (this->name) ? this->name->c_str() : "anonymous" );
         }
 

tests/.expect/opt-params.txt

@@ -1 @@
-opt-params.cfa:12:1 error: Initializer on type declaration i: int 
-  with initializer  maybe constructed? 1
-
-opt-params.cfa:13:1 error: Initializer on type declaration int 
-  with initializer  maybe constructed? 1
-
-opt-params.cfa:14:1 error: Initializer on type declaration int 
-  with initializer  maybe constructed? 1
-
-opt-params.cfa:15:1 error: Initializer on type declaration int 
-  with initializer  maybe constructed? 1
-
+opt-params.cfa:13:1 error: default initialization for parameter i is unsupport for a function-pointer declaration.
+opt-params.cfa:13:1 error: default initialization for parameter j is unsupport for a function-pointer declaration.
+opt-params.cfa:14:1 error: default initialization for parameter anonymous is unsupport for a function-pointer declaration.
+opt-params.cfa:15:1 error: default initialization for parameter anonymous is unsupport for a function-pointer declaration.
+opt-params.cfa:16:1 error: default initialization for parameter anonymous is unsupport for a function-pointer declaration.
+opt-params.cfa:17:1 error: default initialization for parameter i is unsupport for a function-pointer declaration.
+opt-params.cfa:18:1 error: default initialization for parameter i is unsupport for a function-pointer declaration.

tests/opt-params.cfa

@@ -9 +9 @@
 // This is a slightly weird way to do it, but it let's us try all the cases
 // before any of the errors cause compilation to stop.
+
 void bad_cases(
-        int (*fee)( int i = 10 ),
-        int (*fie)( int = 10 ),
-        void feo( int (*p)( int = 10 ) ),
-        void fum( int (*)( int = 10 ) )
+        int (*f1)( int i = 10, int j = 5 ),
+        int (*f2)( int = 10 ),
+        void f3( int (*p)( int = 10 ) ),
+        void f4( int (*)( int = 10 ) ),
+        void f5( int (*p)( int i = 10 ) ),
+        void f6( int (*)( int i = 10 ) )
 );
+