Changeset 78cdb06

Timestamp:

Nov 29, 2019, 1:47:14 PM (5 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

0f9ceacb, ce7bdc4, e71c1d4

Parents:

397c101a

Message:

Modified Lvalue cast handling to ignore top level dereferencing in AsmExpr?, also added test case for this fixes #152?

Files:

• src/GenPoly/Lvalue.cc (modified) (3 diffs)
• tests/.expect/references.txt (modified) (1 diff)
• tests/references.cfa (modified) (1 diff)

src/GenPoly/Lvalue.cc

@@ -60 +60 @@
                 }
 
-                struct ReferenceConversions final : public WithStmtsToAdd {
+                struct ReferenceConversions final : public WithStmtsToAdd, public WithGuards {
                         Expression * postmutate( CastExpr * castExpr );
                         Expression * postmutate( AddressExpr * addrExpr );
@@ -71 +71 @@
 
                 struct FixIntrinsicResult final : public WithGuards {
+                        enum {
+                                NoSkip,
+                                Skip,
+                                SkipInProgress
+                        } skip = NoSkip;
+
+                        void premutate( AsmExpr * ) { GuardValue( skip ); skip = Skip; }
+                        void premutate( ApplicationExpr * ) { GuardValue( skip ); skip = (skip == Skip) ? SkipInProgress : NoSkip; }
+
+
                         Expression * postmutate( ApplicationExpr * appExpr );
                         void premutate( FunctionDecl * funcDecl );
@@ -162 +172 @@
 
                 Expression * FixIntrinsicResult::postmutate( ApplicationExpr * appExpr ) {
-                        if ( isIntrinsicReference( appExpr ) ) {
+                        if ( skip != SkipInProgress && isIntrinsicReference( appExpr ) ) {
                                 // eliminate reference types from intrinsic applications - now they return lvalues
                                 ReferenceType * result = strict_dynamic_cast< ReferenceType * >( appExpr->result );

tests/.expect/references.txt

@@ -36 +36 @@
 3
 3 9 { 1., 7. }, [1, 2, 3]
+4
 Destructing a Y
 Destructing a Y

tests/references.cfa

@@ -119 +119 @@
                 f( 3, a + b, (S){ 1.0, 7.0 }, (int [3]){ 1, 2, 3 } ); // two rvalue to reference
         }
+
+        {
+                int a = 3;
+                int *p = &a;
+                asm (
+                        "incl %[p]\n\t" :
+                        : [p] "m" (*p)
+                );
+                printf("%d\n", a);
+        }
 }