Changes in src/ControlStruct/ExceptTranslate.cc [bfc7811:7862059]

File:

• src/ControlStruct/ExceptTranslate.cc (modified) (18 diffs)

src/ControlStruct/ExceptTranslate.cc

@@ -34 +34 @@
 #include "SynTree/Statement.h"        // for CompoundStmt, CatchStmt, ThrowStmt
 #include "SynTree/Type.h"             // for FunctionType, Type, noQualifiers
-#include "SynTree/VarExprReplacer.h"  // for VarExprReplacer, VarExprReplace...
+#include "SynTree/DeclReplacer.h"     // for DeclReplacer
 #include "SynTree/Visitor.h"          // for acceptAll
 
@@ -104 +104 @@
                 // Types used in translation, make sure to use clone.
                 // void (*function)();
-                FunctionType * try_func_t;
+                FunctionType try_func_t;
                 // void (*function)(int, exception);
-                FunctionType * catch_func_t;
+                FunctionType catch_func_t;
                 // int (*function)(exception);
-                FunctionType * match_func_t;
+                FunctionType match_func_t;
                 // bool (*function)(exception);
-                FunctionType * handle_func_t;
+                FunctionType handle_func_t;
                 // void (*function)(__attribute__((unused)) void *);
-                FunctionType * finally_func_t;
+                FunctionType finally_func_t;
 
                 StructInstType * create_except_type() {
@@ -125 +125 @@
                         handler_except_decl( nullptr ),
                         except_decl( nullptr ), node_decl( nullptr ), hook_decl( nullptr ),
-                        try_func_t( new FunctionType(noQualifiers, false) ),
-                        catch_func_t( new FunctionType(noQualifiers, false) ),
-                        match_func_t( new FunctionType(noQualifiers, false) ),
-                        handle_func_t( new FunctionType(noQualifiers, false) ),
-                        finally_func_t( new FunctionType(noQualifiers, false) )
+                        try_func_t( noQualifiers, false ),
+                        catch_func_t( noQualifiers, false ),
+                        match_func_t( noQualifiers, false ),
+                        handle_func_t( noQualifiers, false ),
+                        finally_func_t( noQualifiers, false )
                 {}
 
@@ -141 +141 @@
                 assert( except_decl );
 
-                auto index_obj = new ObjectDecl(
+                ObjectDecl index_obj(
                         "__handler_index",
                         Type::StorageClasses(),
@@ -149 +149 @@
                         /*init*/ NULL
                         );
-                auto exception_obj = new ObjectDecl(
+                ObjectDecl exception_obj(
                         "__exception_inst",
                         Type::StorageClasses(),
@@ -160 +160 @@
                         /*init*/ NULL
                         );
-                auto bool_obj = new ObjectDecl(
+                ObjectDecl bool_obj(
                         "__ret_bool",
                         Type::StorageClasses(),
@@ -169 +169 @@
                         std::list<Attribute *>{ new Attribute( "unused" ) }
                         );
-                auto voidptr_obj = new ObjectDecl(
+                ObjectDecl voidptr_obj(
                         "__hook",
                         Type::StorageClasses(),
@@ -184 +184 @@
                         );
 
-                ObjectDecl * unused_index_obj = index_obj->clone();
+                ObjectDecl * unused_index_obj = index_obj.clone();
                 unused_index_obj->attributes.push_back( new Attribute( "unused" ) );
 
-                catch_func_t->get_parameters().push_back( index_obj );
-                catch_func_t->get_parameters().push_back( exception_obj->clone() );
-                match_func_t->get_returnVals().push_back( unused_index_obj );
-                match_func_t->get_parameters().push_back( exception_obj->clone() );
-                handle_func_t->get_returnVals().push_back( bool_obj );
-                handle_func_t->get_parameters().push_back( exception_obj );
-                finally_func_t->get_parameters().push_back( voidptr_obj );
+                catch_func_t.get_parameters().push_back( index_obj.clone() );
+                catch_func_t.get_parameters().push_back( exception_obj.clone() );
+                match_func_t.get_returnVals().push_back( unused_index_obj );
+                match_func_t.get_parameters().push_back( exception_obj.clone() );
+                handle_func_t.get_returnVals().push_back( bool_obj.clone() );
+                handle_func_t.get_parameters().push_back( exception_obj.clone() );
+                finally_func_t.get_parameters().push_back( voidptr_obj.clone() );
         }
 
@@ -204 +204 @@
                 call->get_args().push_back( throwStmt->get_expr() );
                 throwStmt->set_expr( nullptr );
+                delete throwStmt;
                 return new ExprStmt( call );
         }
@@ -233 +234 @@
                         new UntypedExpr( new NameExpr( "__cfaabi_ehm__rethrow_terminate" ) )
                         ) );
+                delete throwStmt;
                 return result;
         }
@@ -249 +251 @@
                         );
                 result->labels = throwStmt->labels;
+                delete throwStmt;
                 return result;
         }
@@ -264 +267 @@
 
                 return new FunctionDecl( "try", Type::StorageClasses(),
-                        LinkageSpec::Cforall, try_func_t->clone(), body );
+                        LinkageSpec::Cforall, try_func_t.clone(), body );
         }
 
@@ -271 +274 @@
                 std::list<CaseStmt *> handler_wrappers;
 
-                FunctionType *func_type = catch_func_t->clone();
+                FunctionType *func_type = catch_func_t.clone();
                 DeclarationWithType * index_obj = func_type->get_parameters().front();
                 DeclarationWithType * except_obj = func_type->get_parameters().back();
@@ -311 +314 @@
                         // Update variables in the body to point to this local copy.
                         {
-                                VarExprReplacer::DeclMap mapping;
+                                DeclReplacer::DeclMap mapping;
                                 mapping[ handler_decl ] = local_except;
-                                VarExprReplacer::replace( handler->body, mapping );
+                                DeclReplacer::replace( handler->body, mapping );
                         }
 
@@ -381 +384 @@
                 modded_handler->set_cond( nullptr );
                 modded_handler->set_body( nullptr );
+                delete modded_handler;
                 return block;
         }
@@ -392 +396 @@
                 CompoundStmt * body = new CompoundStmt();
 
-                FunctionType * func_type = match_func_t->clone();
+                FunctionType * func_type = match_func_t.clone();
                 DeclarationWithType * except_obj = func_type->get_parameters().back();
 
@@ -446 +450 @@
                 CompoundStmt * body = new CompoundStmt();
 
-                FunctionType * func_type = handle_func_t->clone();
+                FunctionType * func_type = handle_func_t.clone();
                 DeclarationWithType * except_obj = func_type->get_parameters().back();
 
@@ -526 +530 @@
                 CompoundStmt * body = finally->get_block();
                 finally->set_block( nullptr );
+                delete finally;
                 tryStmt->set_finally( nullptr );
 
                 return new FunctionDecl("finally", Type::StorageClasses(),
-                        LinkageSpec::Cforall, finally_func_t->clone(), body);
+                        LinkageSpec::Cforall, finally_func_t.clone(), body);
         }