Changes in / [9b81fed3:768b3b4f]

Location:

src/AST

Files:

• Node.hpp (modified) (1 diff)
• porting.md (modified) (3 diffs)

src/AST/Node.hpp

@@ -133 +133 @@
         operator const node_t * const() const { return node; }
 
-        template<typename o_node_t>
-        const o_node_t * as() const { return dynamic_cast<o_node_t *>(node); }
-
         using ptr = const node_t *;
 

src/AST/porting.md

@@ -3 +3 @@
 ## Pointer Types ##
 * raw pointer `T*` is used for construction, but not storage
-* `ast::ptr_base<T,R>` is a pointer to AST node `T` with reference type `R`
-  * specialization: strong pointer `ast::ptr<T>` is used for an ownership relationship
-  * specialization: weak pointer `ast::readonly<T>` is used for an observation relationship
-  * added `ast::ptr_base<T,R>::as<S>()` with same semantics as `dynamic_cast<S*>(p)`
+* strong pointer `ast::ptr<T>` is used for an ownership relationship
+* weak pointer `ast::readonly<T>` is used for an observation relationship
 
 ## Visitors ##
@@ -58 +56 @@
 * Strong justification required for private fields
   * No `get_` prefix on getters (including for generated fields)
-    * exception is `DeclWithType::get_type()`
 * Notable changes:
   * for concision and consistency with subclasses:
@@ -111 +108 @@
 * Still a `std::list` for children, rather than `std::vector`
   * allows more-efficient splicing for purposes of later code generation
-
-`Type`
-* `forall` field split off into `ParameterizedType` subclass
-  * any type that needs it can inherit from `ParameterizedType`
-* `get_qualifiers()` replaced with accessor `qualifiers()` and mutator `set_qualifiers()`
-  * `get_CV()` replaced with `is_CV()` variants
-* A number of features only supported on aggregates pushed down to `ReferenceToType`:
-  * `attributes`: per docs [1] GCC only supports type attributes on aggregates and typedefs
-    * suggest adding a `TypeWithAttributes` wrapper type if this proves insufficient
-  * `getAggr()`
-  * `genericSubstitution()`
-
-`BasicType`
-* does not inherit from `Type` to allow pointer inlining
-* moved `Kind` before qualifiers in constructor to allow for default
-* **TODO** move `kind`, `typeNames` into code generator
-
-[1] https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gcc/Type-Attributes.html#Type-Attributes
-