Changeset 75308bcc for src

Timestamp:

May 30, 2018, 3:57:01 PM (6 years ago)

Author:

Aaron Moss <a3moss@…>

Branches:

new-env, with_gc

Children:

8e18b8e

Parents:

8a1289f

Message:

Remove clones from Tuples::Explode

File:

• src/Tuples/Explode.h (modified) (2 diffs)

src/Tuples/Explode.h

@@ -84 +84 @@
                                 // tuple type, but not tuple expr - recursively index into its components.
                                 // if expr type is reference, convert to value type
-                                Expression * arg = expr->clone();
+                                Expression * arg = expr;
                                 if ( Tuples::maybeImpureIgnoreUnique( arg ) ) {
                                         // expressions which may contain side effects require a single unique instance of the expression.
@@ -94 +94 @@
                                 }
                                 for ( unsigned int i = 0; i < tupleType->size(); i++ ) {
-                                        TupleIndexExpr * idx = new TupleIndexExpr( arg->clone(), i );
+                                        TupleIndexExpr * idx = new TupleIndexExpr( arg, i );
                                         explodeUnique( idx, alt, indexer, std::forward<Output>(out), isTupleAssign );
                                 }
                         }
                 } else {
-                        // atomic (non-tuple) type - output a clone of the expression in a new alternative
-                        append( std::forward<Output>(out), expr->clone(), alt.env, alt.cost, alt.cvtCost );
+                        // atomic (non-tuple) type - output the expression in a new alternative
+                        append( std::forward<Output>(out), expr, alt.env, alt.cost, alt.cvtCost );
                 }
         }