Changeset 748c751 for src

Timestamp:

Apr 18, 2024, 8:38:33 PM (8 months ago)

Author:

JiadaL <j82liang@…>

Branches:

master

Children:

38093ae

Parents:

cdb4eaa

Message:

Remove unnecessary implicit enum type conversion

Location:

src

Files:

• ResolvExpr/ConversionCost.cc (modified) (1 diff)
• Validate/ImplementEnumFunc.cpp (modified) (1 diff)

src/ResolvExpr/ConversionCost.cc

@@ -379 +379 @@
 void ConversionCost::postvisit( const ast::EnumAttrType * src ) {
     auto dstAsEnumAttrType = dynamic_cast<const ast::EnumAttrType *>(dst);
-    if ( src->attr == ast::EnumAttribute::Label ) {
-        if ( dstAsEnumAttrType && dstAsEnumAttrType->attr == ast::EnumAttribute::Label ) {
-            cost = costCalc( src->instance, dstAsEnumAttrType->instance, srcIsLvalue, symtab, env );
-        } 
-        // Add Conversion To String
-    } else if ( src->attr == ast::EnumAttribute::Value ) {
+        assert( src->attr != ast::EnumAttribute::Label );
+    if ( src->attr == ast::EnumAttribute::Value ) {
         if ( dstAsEnumAttrType && dstAsEnumAttrType->attr == ast::EnumAttribute::Value) {
             cost = costCalc( src->instance, dstAsEnumAttrType->instance, srcIsLvalue, symtab, env );

src/Validate/ImplementEnumFunc.cpp

@@ -296 +296 @@
         {new ast::ObjectDecl(getLocation(), "_i", new ast::EnumInstType(decl))},
         {new ast::ObjectDecl(getLocation(), "_ret",
-                             new ast::EnumAttrType(new ast::EnumInstType(decl),
-                                                   ast::EnumAttribute::Posn))});
+            new ast::BasicType(ast::BasicType::UnsignedInt))});
 }