Changes in src/AST/porting.md [fdbd4fd:6d51bd7]

File:

• src/AST/porting.md (modified) (4 diffs)

src/AST/porting.md

@@ -3 +3 @@
 ## Pointer Types ##
 * raw pointer `T*` is used for construction, but not storage
-* `ast::ptr_base<T,R>` is a pointer to AST node `T` with reference type `R`
-  * specialization: strong pointer `ast::ptr<T>` is used for an ownership relationship
-  * specialization: weak pointer `ast::readonly<T>` is used for an observation relationship
-  * added `ast::ptr_base<T,R>::as<S>()` with same semantics as `dynamic_cast<S*>(p)`
+* strong pointer `ast::ptr<T>` is used for an ownership relationship
+* weak pointer `ast::readonly<T>` is used for an observation relationship
 
 ## Visitors ##
 * `Visitor` and `Mutator` are combined into a single `ast::Visitor` class
-  * Base nodes now override `Node* accept( Visitor& v ) = 0` with, e.g. `Stmt* accept( Visitor& v ) override = 0`
+  * Base nodes now override `const Node * accept( Visitor & v ) const = 0` with, e.g. `const Stmt * accept( Visitor & v ) const override = 0`
 * `PassVisitor` is replaced with `ast::Pass`
 
@@ -26 +24 @@
 `clone` is private to `Node` now
 * still needs to be overriden to return appropriate type
-  * e.g. `private: virtual Stmt* clone() const override = 0;`
+  * e.g. `private: virtual Stmt * clone() const override = 0;`
+  * because friendship is not inherited, all implementations of clone need
+      /// Must be copied in ALL derived classes
+      template<typename node_t>
+      friend auto mutate(const node_t * node);
 
 All leaves of the `Node` inheritance tree are now declared `final`
@@ -58 +60 @@
 * Strong justification required for private fields
   * No `get_` prefix on getters (including for generated fields)
-    * exception is `DeclWithType::get_type()`
 * Notable changes:
   * for concision and consistency with subclasses:
@@ -111 +112 @@
 * Still a `std::list` for children, rather than `std::vector`
   * allows more-efficient splicing for purposes of later code generation
-
-`Type`
-* `forall` field split off into `ParameterizedType` subclass
-  * any type that needs it can inherit from `ParameterizedType`
-* `get_qualifiers()` replaced with accessor `qualifiers()` and mutator `set_qualifiers()`
-  * `get_CV()` replaced with `is_CV()` variants
-* A number of features only supported on aggregates pushed down to `ReferenceToType`:
-  * `attributes`: per docs [1] GCC only supports type attributes on aggregates and typedefs
-    * suggest adding a `TypeWithAttributes` wrapper type if this proves insufficient
-  * `getAggr()`
-  * `genericSubstitution()`
-
-`BasicType`
-* does not inherit from `Type` to allow pointer inlining
-* moved `Kind` before qualifiers in constructor to allow for default
-* **TODO** move `kind`, `typeNames` into code generator
-
-[1] https://gcc.gnu.org/onlinedocs/gcc-9.1.0/gcc/Type-Attributes.html#Type-Attributes
-