Changeset 692db791

Timestamp:

Aug 31, 2021, 11:44:15 AM (3 years ago)

Author:

Jacob Prud'homme <jafprudhomme@…>

Branches:

ADT, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, pthread-emulation, qualifiedEnum

Children:

32913bc

Parents:

a75cd3d

Message:

Made little changes and added comments

File:

• libcfa/src/parseconfig.cfa (modified) (5 diffs)

libcfa/src/parseconfig.cfa

@@ -17 +17 @@
 
 void msg( Missing_Config_Entries * ex ) {
-        serr | "The config file is missing " | ex->num_missing | " entries";
+        serr | "The config file is missing " | ex->num_missing | " entries.";
 }
 
@@ -66 +66 @@
 
 
+// TODO: Replace KVPairs with vector2 when it's fully functional
 struct KVPairs {
         size_t size, max_size;
@@ -114 +115 @@
 // Parse configuration from a file formatted in shell style
 KVPairs * parse_tabular_config_format( const char * config_file, size_t num_entries ) {
+        // TODO: Change this to a unique_ptr when we fully support returning them (move semantics)
         * KVPairs kv_pairs = new( num_entries );
 
@@ -145 +147 @@
 // Parse configuration values from intermediate format
 void parse_config( const char * config_file, config_entry entries[], size_t num_entries, config_format format ) {
-        KVPairs * kv_pairs = 0p;
+        * KVPairs kv_pairs = 0p;
         choose ( format ) {
                 case TABULAR_CONFIG:
@@ -179 +181 @@
                 }
         }
+        // TODO: Once we get vector2+hash_table, we can more easily add the missing config keys to this error
         if ( entries_so_far < num_entries ) {
                 delete( kv_pairs );