Changeset 68f36f4

Timestamp:

Jun 19, 2020, 4:59:19 PM (4 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

0f89d4f

Parents:

64a7146

Message:

Added Idle Sleep stats and removed extra call to unsafe_remove

Location:

libcfa/src/concurrency

Files:

• kernel.cfa (modified) (4 diffs)
• stats.cfa (modified) (4 diffs)
• stats.hfa (modified) (1 diff)

libcfa/src/concurrency/kernel.cfa

@@ -371 +371 @@
 
                         // Make sure we aren't on the idle queue
+                        #if !defined(__CFA_NO_STATISTICS__)
+                                bool removed =
+                        #endif
                         unsafe_remove( this->cltr->idles, this );
-                        Link(processor) * link = &this->cltr->idles.stack;
-                        for() {
-                                processor * next = link->top;
-                                if( next == this ) {
-                                        link->top = getNext(this)->top;
-                                        break;
-                                }
-                                if( next == 0p ) break;
-                                link = getNext(next);
-                        }
+
+                        #if !defined(__CFA_NO_STATISTICS__)
+                                if(removed) __tls_stats()->ready.sleep.exits++;
+                        #endif
 
                 // Unlock the RWlock
@@ -672 +669 @@
                 push( thrd->curr_cluster, thrd );
 
-                __wake_one(id, thrd->curr_cluster);
+                #if !defined(__CFA_NO_STATISTICS__)
+                        bool woke =
+                #endif
+                        __wake_one(id, thrd->curr_cluster);
+
+                #if !defined(__CFA_NO_STATISTICS__)
+                        if(woke) __tls_stats()->ready.sleep.wakes++;
+                #endif
         ready_schedule_unlock( id );
 
@@ -969 +973 @@
         if( do_terminate ) return;
 
+        #if !defined(__CFA_NO_STATISTICS__)
+                __tls_stats()->ready.sleep.halts++;
+        #endif
         // Push self to queue
         push(cltr->idles, *this);
@@ -979 +986 @@
                         __wake_one( id, cltr );
                 ready_schedule_unlock( id );
+                #if !defined(__CFA_NO_STATISTICS__)
+                        __tls_stats()->ready.sleep.cancels++;
+                #endif
         }
 

libcfa/src/concurrency/stats.cfa

@@ -13 +13 @@
                 stats->ready.pick.pop .attempt = 0;
                 stats->ready.pick.pop .success = 0;
+                stats->ready.sleep.halts   = 0;
+                stats->ready.sleep.cancels = 0;
+                stats->ready.sleep.wakes   = 0;
+                stats->ready.sleep.exits   = 0;
 
                 #if defined(HAVE_LINUX_IO_URING_H)
@@ -37 +41 @@
                 __atomic_fetch_add( &cltr->ready.pick.pop .attempt, proc->ready.pick.pop .attempt, __ATOMIC_SEQ_CST );
                 __atomic_fetch_add( &cltr->ready.pick.pop .success, proc->ready.pick.pop .success, __ATOMIC_SEQ_CST );
+                __atomic_fetch_add( &cltr->ready.sleep.halts  , proc->ready.sleep.halts  , __ATOMIC_SEQ_CST );
+                __atomic_fetch_add( &cltr->ready.sleep.cancels, proc->ready.sleep.cancels, __ATOMIC_SEQ_CST );
+                __atomic_fetch_add( &cltr->ready.sleep.wakes  , proc->ready.sleep.wakes  , __ATOMIC_SEQ_CST );
+                __atomic_fetch_add( &cltr->ready.sleep.exits  , proc->ready.sleep.exits  , __ATOMIC_SEQ_CST );
 
                 #if defined(HAVE_LINUX_IO_URING_H)
@@ -89 +97 @@
                         "- push average probe len : %'18.2lf, %'18.2lf%% (%'15lu attempts)\n"
                         "- pop  average probe len : %'18.2lf, %'18.2lf%% (%'15lu attempts)\n"
+                        "- Idle Sleep -\n"
+                        "-- halts                 : %'15lu\n"
+                        "-- cancelled halts       : %'15lu\n"
+                        "-- schedule wake         : %'15lu\n"
+                        "-- wake on exit          : %'15lu\n"
                         #if defined(HAVE_LINUX_IO_URING_H)
                                 "\n"
@@ -109 +122 @@
                         , push_len, push_sur, stats->ready.pick.push.attempt
                         , pop_len , pop_sur , stats->ready.pick.pop .attempt
+                        , stats->ready.sleep.halts, stats->ready.sleep.cancels, stats->ready.sleep.wakes, stats->ready.sleep.exits
                         #if defined(HAVE_LINUX_IO_URING_H)
                                 , submit_avg.cnt

libcfa/src/concurrency/stats.hfa

@@ -34 +34 @@
                         } pop;
                 } pick;
+                struct {
+                        volatile uint64_t halts;
+                        volatile uint64_t cancels;
+                        volatile uint64_t wakes;
+                        volatile uint64_t exits;
+                } sleep;
         };