Changes in / [9cb89b87:68887f9]

Files:

• examples/io/client.c (deleted)
• examples/io/filereader.c (added)
• examples/io/server.c (deleted)
• examples/io/simple/client.c (added)
• examples/io/simple/server.c (added)
• tests/pybin/settings.py (modified) (4 diffs)
• tests/pybin/tools.py (modified) (1 diff)
• tests/test.py (modified) (7 diffs)

tests/pybin/settings.py

@@ -77 +77 @@
                         print("updated to %s" % self.target)
 
-        def match(self, arch):
+        def filter(self, tests):
+                return [test for test in tests if not test.arch or self.target == test.arch]
                 return True if not arch else self.target == arch
 
@@ -113 +114 @@
 
 def init( options ):
+        global all_arch
+        global all_debug
+        global all_install
         global arch
         global archive
+        global continue_
         global debug
-        global distcc
         global dry_run
         global generating
@@ -125 +129 @@
         global timeout2gdb
 
-        arch         = Architecture(options.arch)
+        all_arch     = [Architecture(o) for o in list(dict.fromkeys(options.arch   ))]
+        all_debug    = [Debug(o)        for o in list(dict.fromkeys(options.debug  ))]
+        all_install  = [Install(o)      for o in list(dict.fromkeys(options.install))]
         archive      = os.path.abspath(os.path.join(original_path, options.archive_errors)) if options.archive_errors else None
-        debug        = Debug(options.debug)
+        continue_    = options.continue_
         dry_run      = options.dry_run # must be called before tools.config_hash()
-        distcc       = "DISTCC_CFA_PATH=~/.cfadistcc/%s/cfa" % tools.config_hash()
         generating   = options.regenerate_expected
-        install      = Install(options.install)
         make         = ['make']
         output_width = 24
@@ -148 +152 @@
 
 def validate():
+        """Validate the current configuration and update globals"""
+
+        global distcc
+        distcc       = "DISTCC_CFA_PATH=~/.cfadistcc/%s/cfa" % tools.config_hash()
         errf = os.path.join(BUILDDIR, ".validate.err")
         make_ret, out = tools.make( ".validate", error_file = errf, output_file=subprocess.DEVNULL, error=subprocess.DEVNULL )

tests/pybin/tools.py

@@ -327 +327 @@
         raise argparse.ArgumentTypeError(msg)
 
+# Convert a function that converts a string to one that converts comma separated string.
+def comma_separated(elements):
+    return lambda string: [elements(part) for part in string.split(',')]
+
 def fancy_print(text):
         column = which('column')

tests/test.py

@@ -6 +6 @@
 
 import argparse
+import itertools
 import re
 import sys
@@ -29 +30 @@
                         test.path = match.group(1)
                         test.arch = match.group(3)[1:] if match.group(3) else None
-                        if settings.arch.match(test.arch):
-                                expected.append(test)
+                        expected.append(test)
 
         path_walk( match_test )
@@ -52 +52 @@
                         x.target().startswith( tuple(excludes) )
                 ]
+
+        # sort the test alphabetically for convenience
+        test_list.sort(key=lambda t: ('~' if t.arch else '') + t.target() + (t.arch if t.arch else ''))
 
         return test_list
@@ -76 +79 @@
 
                         if test :
-                                tests.append( test[0] )
+                                tests.extend( test )
                         else :
                                 print('ERROR: No expected file for test %s, ignoring it' % testname, file=sys.stderr)
@@ -86 +89 @@
         # create a parser with the arguments for the tests script
         parser = argparse.ArgumentParser(description='Script which runs cforall tests')
-        parser.add_argument('--debug', help='Run all tests in debug or release', type=yes_no, default='yes')
-        parser.add_argument('--install', help='Run all tests based on installed binaries or tree binaries', type=yes_no, default='no')
-        parser.add_argument('--arch', help='Test for specific architecture', type=str, default='')
+        parser.add_argument('--debug', help='Run all tests in debug or release', type=comma_separated(yes_no), default='yes')
+        parser.add_argument('--install', help='Run all tests based on installed binaries or tree binaries', type=comma_separated(yes_no), default='no')
+        parser.add_argument('--arch', help='Test for specific architecture', type=comma_separated(str), default='')
+        parser.add_argument('--continue', help='When multiple specifications are passed (debug/install/arch), sets whether or not to continue if the last specification failed', type=yes_no, default='yes', dest='continue_')
         parser.add_argument('--timeout', help='Maximum duration in seconds after a single test is considered to have timed out', type=int, default=60)
         parser.add_argument('--global-timeout', help='Maximum cumulative duration in seconds after the ALL tests are considered to have timed out', type=int, default=7200)
@@ -279 +283 @@
         make('clean', output_file=subprocess.DEVNULL, error=subprocess.DEVNULL)
 
-        return 1 if failed else 0
+        return failed
 
 
@@ -293 +297 @@
         settings.init( options )
 
-        # fetch the liest of all valid tests
-        all_tests = list_tests( options.include, options.exclude )
-
-
-        # if user wants all tests than no other treatement of the test list is required
-        if options.all or options.list or options.list_comp or options.include :
-                tests = all_tests
-
-        #otherwise we need to validate that the test list that was entered is valid
-        else :
-                tests = valid_tests( options )
-
-        # make sure we have at least some test to run
-        if not tests :
-                print('ERROR: No valid test to run', file=sys.stderr)
-                sys.exit(1)
-
-
-        # sort the test alphabetically for convenience
-        tests.sort(key=lambda t: (t.arch if t.arch else '') + t.target())
-
         # users may want to simply list the tests
         if options.list_comp :
+                # fetch the liest of all valid tests
+                tests = list_tests( None, None )
+
+                # print the possible options
                 print("-h --help --debug --dry-run --list --arch --all --regenerate-expected --archive-errors --install --timeout --global-timeout --timeout-with-gdb -j --jobs ", end='')
                 print(" ".join(map(lambda t: "%s" % (t.target()), tests)))
 
         elif options.list :
-                print("Listing for %s:%s"% (settings.arch.string, settings.debug.string))
+                # fetch the liest of all valid tests
+                tests = list_tests( options.include, options.exclude )
+
+                # print the available tests
                 fancy_print("\n".join(map(lambda t: t.toString(), tests)))
 
         else :
-                # check the build configuration works
+                # fetch the liest of all valid tests
+                all_tests = list_tests( options.include, options.exclude )
+
+                # if user wants all tests than no other treatement of the test list is required
+                if options.all or options.include :
+                        tests = all_tests
+
+                #otherwise we need to validate that the test list that was entered is valid
+                else :
+                        tests = valid_tests( options )
+
+                # make sure we have at least some test to run
+                if not tests :
+                        print('ERROR: No valid test to run', file=sys.stderr)
+                        sys.exit(1)
+
+                # prep invariants
                 settings.prep_output(tests)
-                settings.validate()
-
-                options.jobs, forceJobs = job_count( options, tests )
-                settings.update_make_cmd(forceJobs, options.jobs)
-
-                print('%s %i tests on %i cores (%s:%s)' % (
-                        'Regenerating' if settings.generating else 'Running',
-                        len(tests),
-                        options.jobs,
-                        settings.arch.string,
-                        settings.debug.string
-                ))
-
-                # otherwise run all tests and make sure to return the correct error code
-                sys.exit( run_tests(tests, options.jobs) )
+                failed = 0
+
+                # for each build configurations, run the test
+                for arch, debug, install in itertools.product(settings.all_arch, settings.all_debug, settings.all_install):
+                        settings.arch    = arch
+                        settings.debug   = debug
+                        settings.install = install
+
+                        # filter out the tests for a different architecture
+                        # tests are the same across debug/install
+                        local_tests = settings.arch.filter( tests )
+                        options.jobs, forceJobs = job_count( options, local_tests )
+                        settings.update_make_cmd(forceJobs, options.jobs)
+
+                        # check the build configuration works
+                        settings.validate()
+
+                        # print configuration
+                        print('%s %i tests on %i cores (%s:%s)' % (
+                                'Regenerating' if settings.generating else 'Running',
+                                len(local_tests),
+                                options.jobs,
+                                settings.arch.string,
+                                settings.debug.string
+                        ))
+
+                        # otherwise run all tests and make sure to return the correct error code
+                        failed = run_tests(local_tests, options.jobs)
+                        if failed:
+                                result = 1
+                                if not settings.continue_:
+                                        break
+
+
+                sys.exit( failed )