Changeset 5ece8ce for libcfa/src

Timestamp:

May 24, 2023, 11:45:39 AM (12 months ago)

Author:

caparsons <caparson@…>

Branches:

ADT, ast-experimental, master

Children:

88b49bb

Parents:

76e77a4

Message:

fixed a bug in mcs implementation and cleaned up a bit

File:

• libcfa/src/concurrency/locks.hfa (modified) (3 diffs)

libcfa/src/concurrency/locks.hfa

@@ -176 +176 @@
 static inline void ?{}(mcs_spin_node & this) { this.next = 0p; this.locked = true; }
 
-static inline mcs_spin_node * volatile & ?`next ( mcs_spin_node * node ) {
-        return node->next;
-}
-
 struct mcs_spin_lock {
         mcs_spin_queue queue;
@@ -185 +181 @@
 
 static inline void lock(mcs_spin_lock & l, mcs_spin_node & n) {
+    n.locked = true;
         mcs_spin_node * prev = __atomic_exchange_n(&l.queue.tail, &n, __ATOMIC_SEQ_CST);
-        n.locked = true;
-        if(prev == 0p) return;
+        if( prev == 0p ) return;
         prev->next = &n;
-        while(__atomic_load_n(&n.locked, __ATOMIC_RELAXED)) Pause();
+        while( __atomic_load_n(&n.locked, __ATOMIC_RELAXED) ) Pause();
 }
 
@@ -195 +191 @@
         mcs_spin_node * n_ptr = &n;
         if (__atomic_compare_exchange_n(&l.queue.tail, &n_ptr, 0p, false, __ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST)) return;
-        while (__atomic_load_n(&n.next, __ATOMIC_RELAXED) == 0p) {}
+        while (__atomic_load_n(&n.next, __ATOMIC_RELAXED) == 0p) Pause();
         n.next->locked = false;
 }