Changeset 5ccb10d for src/SynTree

Timestamp:

Aug 22, 2017, 6:41:28 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

0b5d871

Parents:

d104b02

Message:

Set reference size to base size, clean up debug code, remove more old-style NULLs from prelude

Location:

src/SynTree

Files:

• Expression.cc (modified) (1 diff)
• TupleExpr.cc (modified) (1 diff)
• Type.h (modified) (1 diff)

src/SynTree/Expression.cc

@@ -611 +611 @@
 CompoundLiteralExpr::CompoundLiteralExpr( Type * type, Initializer * initializer ) : initializer( initializer ) {
         assert( type && initializer );
+        type->set_lvalue( true );
         set_result( type );
 }

src/SynTree/TupleExpr.cc

@@ -60 +60 @@
         assertf( type->size() > index, "TupleIndexExpr index out of bounds: tuple size %d, requested index %d in expr %s", type->size(), index, toString( tuple ).c_str() );
         set_result( (*std::next( type->get_types().begin(), index ))->clone() );
-        get_result()->set_lvalue( type->get_lvalue() );
+        // like MemberExpr, TupleIndexExpr is always an lvalue
+        get_result()->set_lvalue( true );
 }
 

src/SynTree/Type.h

@@ -311 +311 @@
         virtual int referenceDepth() const;
 
+        // Since reference types act like value types, their size is the size of the base.
+        // This makes it simple to cast the empty tuple to a reference type, since casts that increase
+        // the number of values are disallowed.
+        virtual unsigned size() const { return base->size(); }
+
         virtual ReferenceType *clone() const { return new ReferenceType( *this ); }
         virtual void accept( Visitor & v ) { v.visit( this ); }