Changeset 5a4b403

Timestamp:

Nov 30, 2022, 11:50:22 AM (2 years ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

ADT, ast-experimental, master

Children:

be1d00c

Parents:

9f70a67b

Message:

Cleaning old box pass for easier translation. I believe I have an explination for why the confusing loop works.

File:

• src/GenPoly/Box.cc (modified) (2 diffs)

src/GenPoly/Box.cc

@@ -563 +563 @@
                         // NOTE: This is iterating over a map. This means the sorting
                         // order of the keys changes behaviour, as the iteration order
-                        // is visible outside the loop.
-                        // TODO: I cannot figure out how this gets matched in the later
-                        // passes the modify the function.
+                        // is visible outside the loop. - The order matches the orignal
+                        // order because the vars have been renamed with numbers that,
+                        // even when converted to strings, sort in the original order.
+                        // (At least, that is the best explination I have.)
                         for ( std::pair<std::string, TypeDecl::Data> const & tyParam : exprTyVars ) {
                                 if ( !tyParam.second.isComplete ) continue;
@@ -1328 +1329 @@
                         ObjectDecl newPtr( "", Type::StorageClasses(), LinkageSpec::C, 0,
                                            new PointerType( Type::Qualifiers(), new BasicType( Type::Qualifiers(), BasicType::LongUnsignedInt ) ), 0 );
-                        // NOTE: This loop somehow consistently matching one in
-                        // `passTypeVars` even though it does loop in the same way.
                         for ( TypeDecl * const tyParam : funcType->get_forall() ) {
                                 ObjectDecl *sizeParm, *alignParm;