Changes in / [77a45e9:58560d2]

Location:

src

Files:

• AST/Decl.hpp (modified) (2 diffs)
• Common/Eval.cpp (modified) (2 diffs)
• GenPoly/GenPoly.cpp (modified) (2 diffs)
• InitTweak/FixGlobalInit.cpp (modified) (5 diffs)
• InitTweak/FixInit.cpp (modified) (1 diff)
• InitTweak/InitTweak.cpp (modified) (2 diffs)
• InitTweak/InitTweak.hpp (modified) (2 diffs)
• main.cpp (modified) (2 diffs)

src/AST/Decl.hpp

@@ -9 +9 @@
 // Author           : Aaron B. Moss
 // Created On       : Thu May 9 10:00:00 2019
-// Last Modified By : Peter A. Buhr
-// Last Modified On : Sun Jun 28 21:54:18 2026
-// Update Count     : 36
+// Last Modified By : Andrew Beach
+// Last Modified On : Wed Apr  5 10:42:00 2023
+// Update Count     : 35
 //
 
@@ -108 +108 @@
           init( init ), bitfieldWidth( bitWd ) {}
 
-        const Type * get_type() const override { return type; }
+        const Type* get_type() const override { return type; }
         void set_type( const Type * ty ) override { type = ty; }
 

src/Common/Eval.cpp

@@ -10 +10 @@
 // Created On       : Mon May 18 07:44:20 2015
 // Last Modified By : Peter A. Buhr
-// Last Modified On : Sun Jun 28 21:50:29 2026
-// Update Count     : 121
+// Last Modified On : Sat Aug  6 12:11:59 2022
+// Update Count     : 119
 //
 
@@ -200 +200 @@
 Evaluation eval( const ast::Expr * expr ) {
         if ( expr ) {
+
                 return ast::Pass<EvalNew>::read(expr);
                 // Evaluation ret = ast::Pass<EvalNew>::read(expr);
                 // ret.knownValue = 777;
                 // return ret;
+
         } else {
                 return { 0, false, false };

src/GenPoly/GenPoly.cpp

@@ -9 +9 @@
 // Author           : Richard C. Bilson
 // Created On       : Mon May 18 07:44:20 2015
-// Last Modified By : Peter A. Buhr
-// Last Modified On : Sun Jun 28 21:49:48 2026
-// Update Count     : 18
+// Last Modified By : Andrew Beach
+// Last Modified On : Mon Oct 24 15:19:00 2022
+// Update Count     : 17
 //
 
@@ -252 +252 @@
 bool typesPolyCompatible( ast::Type const * lhs, ast::Type const * rhs );
 
-static bool exprsPolyCompatibleByStaticValue( const ast::Expr * e1, const ast::Expr * e2 ) {
+static bool exprsPolyCompatibleByStaticValue(
+                const ast::Expr * e1, const ast::Expr * e2 ) {
         Evaluation r1 = eval(e1);
         Evaluation r2 = eval(e2);

src/InitTweak/FixGlobalInit.cpp

@@ -10 +10 @@
 // Created On       : Mon May 04 15:14:56 2016
 // Last Modified By : Peter A. Buhr
-// Last Modified On : Thu Jul  2 16:39:52 2026
-// Update Count     : 35
+// Last Modified On : Fri Dec 13 23:41:10 2019
+// Update Count     : 19
 //
 
 #include "FixGlobalInit.hpp"
 
-#include <set>
 #include <cassert>                 // for assert
 #include <stddef.h>                // for NULL
@@ -41 +40 @@
         void previsit(const ast::TypeDecl *) { visit_children = false; }
 
-        bool pass = false;
         std::list< ast::ptr<ast::Stmt> > initStmts;
         std::list< ast::ptr<ast::Stmt> > destroyStmts;
-        std::set< std::string > constDeclsMnames;
 };
 
@@ -50 +47 @@
         auto mutDecl = mutate(objDecl);
         assertf(mutDecl == objDecl, "Global object decl must be unique");
-        if ( ! pass ) {                                                                         // pass 1
-                auto ctorInit = objDecl->init.as<ast::ConstructorInit>();
-                if ( nullptr == ctorInit ) return;
+        auto ctorInit = objDecl->init.as<ast::ConstructorInit>();
+        if ( nullptr == ctorInit ) return;
 
-                // a decision should have been made by the resolver, so ctor and init are not both non-NULL
-                assert( !ctorInit->ctor || !ctorInit->init );
+        // a decision should have been made by the resolver, so ctor and init are not both non-NULL
+        assert( !ctorInit->ctor || !ctorInit->init );
 
-                const ast::Stmt * dtor = ctorInit->dtor;
-                if ( dtor && !isIntrinsicSingleArgCallStmt( dtor ) ) {
-                        // don't need to call intrinsic dtor, because it does nothing, but
-                        // non-intrinsic dtors must be called
-                        destroyStmts.push_front( dtor );
-                } // if
-                if ( const ast::Stmt * ctor = ctorInit->ctor ) {
-                        if ( mutDecl->type->is_const() ) {
-                                // Store names of all declarations with const qualifier and initializer for second pass.
-                                constDeclsMnames.emplace( mutDecl->mangleName );
-                        }
-                        initStmts.push_back( ctor );
-                        mutDecl->init = nullptr;
-                } else if ( const ast::Init * init = ctorInit->init ) {
-                        mutDecl->init = init;
-                } else {
-                        // no constructor and no initializer, which is okay
-                        mutDecl->init = nullptr;
-                }
-        } else {                                                                                // pass 2
-                // Remove const qualifier from matching names, covering all forward declaration(s) and definition.
-                if ( constDeclsMnames.find( objDecl->mangleName ) != constDeclsMnames.end() ) {
-                        ast::Type * fred = const_cast<ast::Type *>(mutDecl->get_type());
-                        fred->set_const( false );
-                } // if
+        const ast::Stmt * dtor = ctorInit->dtor;
+        if ( dtor && !isIntrinsicSingleArgCallStmt( dtor ) ) {
+                // don't need to call intrinsic dtor, because it does nothing, but
+                // non-intrinsic dtors must be called
+                destroyStmts.push_front( dtor );
+        } // if
+        if ( const ast::Stmt * ctor = ctorInit->ctor ) {
+                addDataSectionAttribute(mutDecl);
+                initStmts.push_back( ctor );
+                mutDecl->init = nullptr;
+        } else if ( const ast::Init * init = ctorInit->init ) {
+                mutDecl->init = init;
+        } else {
+                // no constructor and no initializer, which is okay
+                mutDecl->init = nullptr;
         }
 }
@@ -89 +75 @@
 void fixGlobalInit(ast::TranslationUnit & translationUnit, bool inLibrary) {
         ast::Pass<GlobalFixer> fixer;
-
-        // First pass fixes global initialization.
-        accept_all( translationUnit, fixer );
+        accept_all(translationUnit, fixer);
 
         // Say these magic declarations come at the end of the file.
@@ -119 +103 @@
                 translationUnit.decls.emplace_back(destroyFunction);
         } // if
-
-        fixer.core.pass = ! fixer.core.pass;
-        // Second pass, removes const qualifiers so declarations appear in mutable .data section.
-        // Note, the resolver has already checked for const-ness, so C only has to get the initialization correct.
-        accept_all(translationUnit, fixer);
 }
 

src/InitTweak/FixInit.cpp

@@ -816 +816 @@
         if ( const ast::Stmt * ctor = ctorInit->ctor ) {
                 if ( objDecl->storage.is_static ) {
-                        // Remove const qualifier from definition and there can be no forward declarations.
-                        if ( objDecl->type->is_const() ) {
-                                ast::Type * fred = const_cast<ast::Type *>(objDecl->get_type());
-                                fred->set_const( false );
-                        }
+                        addDataSectionAttribute(objDecl);
                         // originally wanted to take advantage of gcc nested functions, but
                         // we get memory errors with this approach. To remedy this, the static

src/InitTweak/InitTweak.cpp

@@ -9 +9 @@
 // Author           : Rob Schluntz
 // Created On       : Fri May 13 11:26:36 2016
-// Last Modified By : Peter A. Buhr
-// Last Modified On : Thu Jul  2 16:47:11 2026
-// Update Count     : 44
+// Last Modified By : Andrew Beach
+// Last Modified On : Wed Sep 22  9:50:00 2022
+// Update Count     : 21
 //
 
@@ -428 +428 @@
 }
 
+#if defined( __x86_64 ) || defined( __i386 ) // assembler comment to prevent assembler warning message
+        #define ASM_COMMENT "#"
+#else // defined( __ARM_ARCH )
+        #define ASM_COMMENT "//"
+#endif
+static const char * const data_section =  ".data" ASM_COMMENT;
+static const char * const tlsd_section = ".tdata" ASM_COMMENT;
+
+void addDataSectionAttribute( ast::ObjectDecl * objDecl ) {
+        const bool is_tls = objDecl->storage.is_threadlocal_any();
+        const char * section = is_tls ? tlsd_section : data_section;
+        objDecl->attributes.push_back(new ast::Attribute("section", {
+                ast::ConstantExpr::from_string(objDecl->location, section)
+        }));
+}
+
 InitExpander::InitExpander( const ast::Init * init )
 : expander( new InitImpl{ init } ), crnt(), indices() {}

src/InitTweak/InitTweak.hpp

@@ -9 +9 @@
 // Author           : Rob Schluntz
 // Created On       : Fri May 13 11:26:36 2016
-// Last Modified By : Peter A. Buhr
-// Last Modified On : Thu Jul  2 16:45:44 2026
-// Update Count     : 12
+// Last Modified By : Andrew Beach
+// Last Modified On : Wed Sep 22  9:21:00 2022
+// Update Count     : 9
 //
 
@@ -69 +69 @@
 bool isConstExpr( const ast::Init * init );
 
+/// Modifies objDecl to have:
+///    __attribute__((section (".data#")))
+/// which makes gcc put the declared variable in the data section,
+/// which is helpful for global constants on newer gcc versions,
+/// so that CFA's generated initialization won't segfault when writing it via a const cast.
+/// The trailing # is an injected assembly comment, to suppress the "a" in
+///    .section .data,"a"
+///    .section .data#,"a"
+/// to avoid assembler warning "ignoring changed section attributes for .data"
+void addDataSectionAttribute( ast::ObjectDecl * objDecl );
+
 class InitExpander final {
 public:

src/main.cpp

@@ -10 +10 @@
 // Created On       : Fri May 15 23:12:02 2015
 // Last Modified By : Peter A. Buhr
-// Last Modified On : Tue Jun 23 13:56:23 2026
-// Update Count     : 712
+// Last Modified On : Fri Mar 20 08:10:38 2026
+// Update Count     : 710
 //
 
@@ -281 +281 @@
 
                 // Currently not working due to unresolved issues with UniqueExpr
-
-                // xxx - is this the right place for this? Want to expand ASAP so that, sequent passes don't need to worry about
-                // double-visiting a unique expr - needs to go after InitTweak::fix so that copy constructed return declarations
-                // are reused
-                PASS( "Expand Unique Expr", Tuples::expandUniqueExpr, transUnit );
+                PASS( "Expand Unique Expr", Tuples::expandUniqueExpr, transUnit ); // xxx - is this the right place for this? want to expand ASAP so tha, sequent passes don't need to worry about double-visiting a unique expr - needs to go after InitTweak::fix so that copy constructed return declarations are reused
 
                 PASS( "Translate Tries", ControlStruct::translateTries, transUnit );