Changes in / [f8b69da7:546b51e]
- Files:
-
- 14 edited
-
libcfa/prelude/builtins.c (modified) (1 diff)
-
src/ControlStruct/ExceptTranslate.cc (modified) (1 diff)
-
src/InitTweak/FixInit.cc (modified) (13 diffs)
-
src/InitTweak/InitTweak.cc (modified) (1 diff)
-
src/Makefile.am (modified) (1 diff)
-
src/Makefile.in (modified) (4 diffs)
-
src/SymTab/Autogen.cc (modified) (5 diffs)
-
src/SymTab/Autogen.h (modified) (1 diff)
-
src/SymTab/Validate.cc (modified) (1 diff)
-
src/SynTree/DeclReplacer.cc (modified) (3 diffs)
-
src/SynTree/DeclReplacer.h (modified) (1 diff)
-
tests/raii/.expect/memberCtors-ERR1.txt (modified) (1 diff)
-
tests/raii/.expect/memberCtors.txt (modified) (1 diff)
-
tests/raii/memberCtors.c (modified) (5 diffs)
Legend:
- Unmodified
- Added
- Removed
-
libcfa/prelude/builtins.c
rf8b69da7 r546b51e 111 111 static inline unsigned int ?\=?( unsigned int & x, unsigned long int y ) { x = x \ y; return x; } 112 112 113 // type that wraps a pointer and a destructor-like function - used in generating implicit destructor calls for struct members in user-defined functions114 forall(dtype T)115 struct __Destructor {116 T * object;117 void (*dtor)(T *);118 };119 120 // defined destructor in the case that non-generated code wants to use __Destructor121 forall(dtype T)122 static inline void ^?{}(__Destructor(T) & x) {123 if (x.object && x.dtor) {124 x.dtor(x.object);125 }126 }127 128 // easy interface into __Destructor's destructor for easy codegen purposes129 extern "C" {130 forall(dtype T)131 static inline void __destroy_Destructor(__Destructor(T) * dtor) {132 ^(*dtor){};133 }134 }135 136 113 // Local Variables: // 137 114 // mode: c // -
src/ControlStruct/ExceptTranslate.cc
rf8b69da7 r546b51e 319 319 } 320 320 321 block->push_back( handler-> body);322 handler-> body = nullptr;321 block->push_back( handler->get_body() ); 322 handler->set_body( nullptr ); 323 323 324 324 std::list<Statement *> caseBody -
src/InitTweak/FixInit.cc
rf8b69da7 r546b51e 54 54 #include "SynTree/Type.h" // for Type, Type::StorageClasses 55 55 #include "SynTree/TypeSubstitution.h" // for TypeSubstitution, operator<< 56 #include "SynTree/DeclReplacer.h" // for DeclReplacer57 56 #include "SynTree/Visitor.h" // for acceptAll, maybeAccept 58 57 … … 163 162 using Parent::previsit; 164 163 164 void previsit( ObjectDecl * objDecl ); 165 165 void previsit( FunctionDecl * funcDecl ); 166 166 167 void previsit( CompoundStmt * compoundStmt ); 168 void postvisit( CompoundStmt * compoundStmt ); 169 void previsit( ReturnStmt * returnStmt ); 167 170 void previsit( BranchStmt * stmt ); 168 171 private: … … 204 207 static void generate( std::list< Declaration * > & translationUnit ); 205 208 206 void premutate( StructDecl * structDecl );207 208 209 void premutate( FunctionDecl * funcDecl ); 209 210 DeclarationWithType * postmutate( FunctionDecl * funcDecl ); … … 227 228 bool isCtor = false; // true if current function is a constructor 228 229 StructDecl * structDecl = nullptr; 229 230 // special built-in functions necessary for this to work231 StructDecl * dtorStruct = nullptr;232 FunctionDecl * dtorStructDestroy = nullptr;233 230 }; 234 231 … … 735 732 } 736 733 737 DeclarationWithType * getDtorFunc( ObjectDecl * objDecl, Statement * input, std::list< Statement * > & stmtsToAdd ) {738 // unwrap implicit statement wrapper739 Statement * dtor = input;740 if ( ImplicitCtorDtorStmt * implicit = dynamic_cast< ImplicitCtorDtorStmt * >( input ) ) {741 // dtor = implicit->callStmt;742 // implicit->callStmt = nullptr;743 }744 assert( dtor );745 std::list< Expression * > matches;746 collectCtorDtorCalls( dtor, matches );747 748 if ( dynamic_cast< ExprStmt * >( dtor ) ) {749 // only one destructor call in the expression750 if ( matches.size() == 1 ) {751 DeclarationWithType * func = getFunction( matches.front() );752 assertf( func, "getFunction failed to find function in %s", toString( matches.front() ).c_str() );753 754 // cleanup argument must be a function, not an object (including function pointer)755 if ( FunctionDecl * dtorFunc = dynamic_cast< FunctionDecl * > ( func ) ) {756 if ( dtorFunc->type->forall.empty() ) {757 // simple case where the destructor is a monomorphic function call - can simply758 // use that function as the cleanup function.759 delete dtor;760 return func;761 }762 }763 }764 }765 766 // otherwise the cleanup is more complicated - need to build a single argument cleanup function that767 // wraps the more complicated code.768 static UniqueName dtorNamer( "__cleanup_dtor" );769 FunctionDecl * dtorFunc = FunctionDecl::newFunction( dtorNamer.newName(), SymTab::genDefaultType( objDecl->type->stripReferences(), false ), new CompoundStmt() );770 stmtsToAdd.push_back( new DeclStmt( dtorFunc ) );771 772 // the original code contains uses of objDecl - replace them with the newly generated 'this' parameter.773 ObjectDecl * thisParam = getParamThis( dtorFunc->type );774 Expression * replacement = new VariableExpr( thisParam );775 776 Type * base = replacement->result->stripReferences();777 if ( dynamic_cast< ArrayType * >( base ) || dynamic_cast< TupleType * > ( base ) ) {778 // need to cast away reference for array types, since the destructor is generated without the reference type,779 // and for tuple types since tuple indexing does not work directly on a reference780 replacement = new CastExpr( replacement, base->clone() );781 }782 DeclReplacer::replace( dtor, { std::make_pair( objDecl, replacement ) } );783 dtorFunc->statements->push_back( strict_dynamic_cast<Statement *>( dtor ) );784 785 return dtorFunc;786 }787 788 734 DeclarationWithType * FixInit::postmutate( ObjectDecl *objDecl ) { 789 735 // since this removes the init field from objDecl, it must occur after children are mutated (i.e. postmutate) … … 898 844 ctorInit->ctor = nullptr; 899 845 } 900 901 Statement * dtor = ctorInit->dtor;902 if ( dtor ) {903 ImplicitCtorDtorStmt * implicit = strict_dynamic_cast< ImplicitCtorDtorStmt * >( dtor );904 Statement * dtorStmt = implicit->callStmt;905 906 // don't need to call intrinsic dtor, because it does nothing, but907 // non-intrinsic dtors must be called908 if ( ! isIntrinsicSingleArgCallStmt( dtorStmt ) ) {909 // set dtor location to the object's location for error messages910 DeclarationWithType * dtorFunc = getDtorFunc( objDecl, dtorStmt, stmtsToAddBefore );911 objDecl->attributes.push_back( new Attribute( "cleanup", { new VariableExpr( dtorFunc ) } ) );912 ctorInit->dtor = nullptr;913 } // if914 }915 846 } // if 916 847 } else if ( Initializer * init = ctorInit->init ) { … … 955 886 956 887 888 template<typename Iterator, typename OutputIterator> 889 void insertDtors( Iterator begin, Iterator end, OutputIterator out ) { 890 for ( Iterator it = begin ; it != end ; ++it ) { 891 // extract destructor statement from the object decl and insert it into the output. Note that this is 892 // only called on lists of non-static objects with implicit non-intrinsic dtors, so if the user manually 893 // calls an intrinsic dtor then the call must (and will) still be generated since the argument may 894 // contain side effects. 895 ObjectDecl * objDecl = *it; 896 ConstructorInit * ctorInit = dynamic_cast< ConstructorInit * >( objDecl->get_init() ); 897 assert( ctorInit && ctorInit->get_dtor() ); 898 *out++ = ctorInit->get_dtor()->clone(); 899 } // for 900 } 901 902 void InsertDtors::previsit( ObjectDecl * objDecl ) { 903 // remember non-static destructed objects so that their destructors can be inserted later 904 if ( ! objDecl->get_storageClasses().is_static ) { 905 if ( ConstructorInit * ctorInit = dynamic_cast< ConstructorInit * >( objDecl->get_init() ) ) { 906 // a decision should have been made by the resolver, so ctor and init are not both non-NULL 907 assert( ! ctorInit->get_ctor() || ! ctorInit->get_init() ); 908 Statement * dtor = ctorInit->get_dtor(); 909 // don't need to call intrinsic dtor, because it does nothing, but 910 // non-intrinsic dtors must be called 911 if ( dtor && ! isIntrinsicSingleArgCallStmt( dtor ) ) { 912 // set dtor location to the object's location for error messages 913 ctorInit->dtor->location = objDecl->location; 914 reverseDeclOrder.front().push_front( objDecl ); 915 } // if 916 } // if 917 } // if 918 } 919 957 920 void InsertDtors::previsit( FunctionDecl * funcDecl ) { 958 921 // each function needs to have its own set of labels … … 967 930 } 968 931 932 void InsertDtors::previsit( CompoundStmt * compoundStmt ) { 933 // visit statements - this will also populate reverseDeclOrder list. don't want to dump all destructors 934 // when block is left, just the destructors associated with variables defined in this block, so push a new 935 // list to the top of the stack so that we can differentiate scopes 936 reverseDeclOrder.push_front( OrderedDecls() ); 937 Parent::previsit( compoundStmt ); 938 } 939 940 void InsertDtors::postvisit( CompoundStmt * compoundStmt ) { 941 // add destructors for the current scope that we're exiting, unless the last statement is a return, which 942 // causes unreachable code warnings 943 std::list< Statement * > & statements = compoundStmt->get_kids(); 944 if ( ! statements.empty() && ! dynamic_cast< ReturnStmt * >( statements.back() ) ) { 945 insertDtors( reverseDeclOrder.front().begin(), reverseDeclOrder.front().end(), back_inserter( statements ) ); 946 } 947 reverseDeclOrder.pop_front(); 948 } 949 950 void InsertDtors::previsit( ReturnStmt * ) { 951 // return exits all scopes, so dump destructors for all scopes 952 for ( OrderedDecls & od : reverseDeclOrder ) { 953 insertDtors( od.begin(), od.end(), back_inserter( stmtsToAddBefore ) ); 954 } // for 955 } 956 969 957 // Handle break/continue/goto in the same manner as C++. Basic idea: any objects that are in scope at the 970 958 // BranchStmt but not at the labelled (target) statement must be destructed. If there are any objects in scope … … 994 982 if ( ! diff.empty() ) { 995 983 SemanticError( stmt, std::string("jump to label '") + stmt->get_target().get_name() + "' crosses initialization of " + (*diff.begin())->get_name() + " " ); 984 } // if 985 // S_G-S_L results in set of objects that must be destructed 986 diff.clear(); 987 std::set_difference( curVars.begin(), curVars.end(), lvars.begin(), lvars.end(), std::inserter( diff, diff.end() ) ); 988 DTOR_PRINT( 989 std::cerr << "S_G-S_L = " << printSet( diff ) << std::endl; 990 ) 991 if ( ! diff.empty() ) { 992 // create an auxilliary set for fast lookup -- can't make diff a set, because diff ordering should be consistent for error messages. 993 std::unordered_set<ObjectDecl *> needsDestructor( diff.begin(), diff.end() ); 994 995 // go through decl ordered list of objectdecl. for each element that occurs in diff, output destructor 996 OrderedDecls ordered; 997 for ( OrderedDecls & rdo : reverseDeclOrder ) { 998 // add elements from reverseDeclOrder into ordered if they occur in diff - it is key that this happens in reverse declaration order. 999 copy_if( rdo.begin(), rdo.end(), back_inserter( ordered ), [&]( ObjectDecl * objDecl ) { return needsDestructor.count( objDecl ); } ); 1000 } // for 1001 insertDtors( ordered.begin(), ordered.end(), back_inserter( stmtsToAddBefore ) ); 996 1002 } // if 997 1003 } … … 1019 1025 } 1020 1026 1021 void GenStructMemberCalls::premutate( StructDecl * structDecl ) {1022 if ( ! dtorStruct && structDecl->name == "__Destructor" ) {1023 dtorStruct = structDecl;1024 }1025 }1026 1027 1027 void GenStructMemberCalls::premutate( FunctionDecl * funcDecl ) { 1028 1028 GuardValue( function ); … … 1037 1037 unhandled.clear(); 1038 1038 usedUninit.clear(); 1039 1040 if ( ! dtorStructDestroy && funcDecl->name == "__destroy_Destructor" ) {1041 dtorStructDestroy = funcDecl;1042 return;1043 }1044 1039 1045 1040 function = funcDecl; … … 1053 1048 if ( structType ) { 1054 1049 structDecl = structType->get_baseStruct(); 1055 if ( structDecl == dtorStruct ) return;1056 1050 for ( Declaration * member : structDecl->get_members() ) { 1057 1051 if ( ObjectDecl * field = dynamic_cast< ObjectDecl * >( member ) ) { … … 1122 1116 callStmt->acceptMutator( *visitor ); 1123 1117 if ( isCtor ) { 1124 function-> statements->push_front( callStmt );1125 } else { // TODO: don't generate destructor function/object for intrinsic calls1118 function->get_statements()->push_front( callStmt ); 1119 } else { 1126 1120 // destructor statements should be added at the end 1127 // function->get_statements()->push_back( callStmt ); 1128 1129 // __Destructor _dtor0 = { (void *)&b.a1, (void (*)(void *)_destroy_A }; 1130 std::list< Statement * > stmtsToAdd; 1131 1132 static UniqueName memberDtorNamer = { "__memberDtor" }; 1133 assertf( dtorStruct, "builtin __Destructor not found." ); 1134 assertf( dtorStructDestroy, "builtin __destroy_Destructor not found." ); 1135 1136 Expression * thisExpr = new CastExpr( new AddressExpr( new VariableExpr( thisParam ) ), new PointerType( Type::Qualifiers(), new VoidType( Type::Qualifiers() ) ) ); 1137 Expression * dtorExpr = new VariableExpr( getDtorFunc( thisParam, callStmt, stmtsToAdd ) ); 1138 1139 // cast destructor pointer to void (*)(void *), to silence GCC incompatible pointer warnings 1140 FunctionType * dtorFtype = new FunctionType( Type::Qualifiers(), false ); 1141 dtorFtype->parameters.push_back( ObjectDecl::newObject( "", new PointerType( Type::Qualifiers(), new VoidType( Type::Qualifiers() ) ), nullptr ) ); 1142 Type * dtorType = new PointerType( Type::Qualifiers(), dtorFtype ); 1143 1144 ObjectDecl * destructor = ObjectDecl::newObject( memberDtorNamer.newName(), new StructInstType( Type::Qualifiers(), dtorStruct ), new ListInit( { new SingleInit( thisExpr ), new SingleInit( new CastExpr( dtorExpr, dtorType ) ) } ) ); 1145 function->statements->push_front( new DeclStmt( destructor ) ); 1146 destructor->attributes.push_back( new Attribute( "cleanup", { new VariableExpr( dtorStructDestroy ) } ) ); 1147 1148 function->statements->kids.splice( function->statements->kids.begin(), stmtsToAdd ); 1121 function->get_statements()->push_back( callStmt ); 1149 1122 } 1150 1123 } catch ( SemanticErrorException & error ) { -
src/InitTweak/InitTweak.cc
rf8b69da7 r546b51e 339 339 std::list< Expression * > matches; 340 340 collectCtorDtorCalls( stmt, matches ); 341 assert f( matches.size() <= 1, "%zd constructor/destructors found in %s", matches.size(), toString( stmt ).c_str());341 assert( matches.size() <= 1 ); 342 342 return matches.size() == 1 ? matches.front() : nullptr; 343 343 } -
src/Makefile.am
rf8b69da7 r546b51e 94 94 CodeGen/CodeGenerator.cc \ 95 95 CodeGen/FixMain.cc \ 96 CodeGen/Generate.cc \97 96 CodeGen/GenType.cc \ 98 97 CodeGen/OperatorTable.cc \ -
src/Makefile.in
rf8b69da7 r546b51e 182 182 SynTree/DeclReplacer.$(OBJEXT) CompilationState.$(OBJEXT) \ 183 183 CodeGen/CodeGenerator.$(OBJEXT) CodeGen/FixMain.$(OBJEXT) \ 184 CodeGen/Gen erate.$(OBJEXT) CodeGen/GenType.$(OBJEXT) \185 Co deGen/OperatorTable.$(OBJEXT) Common/Assert.$(OBJEXT) \186 Common/ Eval.$(OBJEXT) Common/SemanticError.$(OBJEXT) \187 Co mmon/UniqueName.$(OBJEXT) Concurrency/Keywords.$(OBJEXT) \184 CodeGen/GenType.$(OBJEXT) CodeGen/OperatorTable.$(OBJEXT) \ 185 Common/Assert.$(OBJEXT) Common/Eval.$(OBJEXT) \ 186 Common/SemanticError.$(OBJEXT) Common/UniqueName.$(OBJEXT) \ 187 Concurrency/Keywords.$(OBJEXT) \ 188 188 ControlStruct/ForExprMutator.$(OBJEXT) \ 189 189 ControlStruct/LabelFixer.$(OBJEXT) \ … … 621 621 CodeGen/CodeGenerator.cc \ 622 622 CodeGen/FixMain.cc \ 623 CodeGen/Generate.cc \624 623 CodeGen/GenType.cc \ 625 624 CodeGen/OperatorTable.cc \ … … 798 797 CodeGen/$(DEPDIR)/$(am__dirstamp) 799 798 CodeGen/FixMain.$(OBJEXT): CodeGen/$(am__dirstamp) \ 800 CodeGen/$(DEPDIR)/$(am__dirstamp)801 CodeGen/Generate.$(OBJEXT): CodeGen/$(am__dirstamp) \802 799 CodeGen/$(DEPDIR)/$(am__dirstamp) 803 800 CodeGen/GenType.$(OBJEXT): CodeGen/$(am__dirstamp) \ … … 990 987 clean-cfa_cpplibPROGRAMS: 991 988 -test -z "$(cfa_cpplib_PROGRAMS)" || rm -f $(cfa_cpplib_PROGRAMS) 989 CodeGen/Generate.$(OBJEXT): CodeGen/$(am__dirstamp) \ 990 CodeGen/$(DEPDIR)/$(am__dirstamp) 992 991 CodeGen/FixNames.$(OBJEXT): CodeGen/$(am__dirstamp) \ 993 992 CodeGen/$(DEPDIR)/$(am__dirstamp) -
src/SymTab/Autogen.cc
rf8b69da7 r546b51e 45 45 /// Data used to generate functions generically. Specifically, the name of the generated function and a function which generates the routine protoype 46 46 struct FuncData { 47 typedef FunctionType * (*TypeGen)( Type * , bool);47 typedef FunctionType * (*TypeGen)( Type * ); 48 48 FuncData( const std::string & fname, const TypeGen & genType ) : fname( fname ), genType( genType ) {} 49 49 std::string fname; … … 231 231 232 232 /// given type T, generate type of default ctor/dtor, i.e. function type void (*) (T *) 233 FunctionType * genDefaultType( Type * paramType, bool maybePolymorphic ) { 233 FunctionType * genDefaultType( Type * paramType ) { 234 const auto & typeParams = getGenericParams( paramType ); 234 235 FunctionType *ftype = new FunctionType( Type::Qualifiers(), false ); 235 if ( maybePolymorphic ) { 236 // only copy in 237 const auto & typeParams = getGenericParams( paramType ); 238 cloneAll( typeParams, ftype->forall ); 239 } 236 cloneAll( typeParams, ftype->forall ); 240 237 ObjectDecl *dstParam = new ObjectDecl( "_dst", Type::StorageClasses(), LinkageSpec::Cforall, nullptr, new ReferenceType( Type::Qualifiers(), paramType->clone() ), nullptr ); 241 238 ftype->parameters.push_back( dstParam ); … … 244 241 245 242 /// given type T, generate type of copy ctor, i.e. function type void (*) (T *, T) 246 FunctionType * genCopyType( Type * paramType , bool maybePolymorphic) {247 FunctionType *ftype = genDefaultType( paramType , maybePolymorphic);243 FunctionType * genCopyType( Type * paramType ) { 244 FunctionType *ftype = genDefaultType( paramType ); 248 245 ObjectDecl *srcParam = new ObjectDecl( "_src", Type::StorageClasses(), LinkageSpec::Cforall, nullptr, paramType->clone(), nullptr ); 249 246 ftype->parameters.push_back( srcParam ); … … 252 249 253 250 /// given type T, generate type of assignment, i.e. function type T (*) (T *, T) 254 FunctionType * genAssignType( Type * paramType , bool maybePolymorphic) {255 FunctionType *ftype = genCopyType( paramType , maybePolymorphic);251 FunctionType * genAssignType( Type * paramType ) { 252 FunctionType *ftype = genCopyType( paramType ); 256 253 ObjectDecl *returnVal = new ObjectDecl( "_ret", Type::StorageClasses(), LinkageSpec::Cforall, nullptr, paramType->clone(), nullptr ); 257 254 ftype->returnVals.push_back( returnVal ); … … 311 308 for ( const FuncData & d : data ) { 312 309 // generate a function (?{}, ?=?, ^?{}) based on the current FuncData. 313 FunctionType * ftype = d.genType( type , true);310 FunctionType * ftype = d.genType( type ); 314 311 315 312 // destructor for concurrent type must be mutex -
src/SymTab/Autogen.h
rf8b69da7 r546b51e 45 45 extern FunctionDecl * dereferenceOperator; 46 46 47 /// generate the type of an assignment function for paramType. 48 /// maybePolymorphic is true if the resulting FunctionType is allowed to be polymorphic 49 FunctionType * genAssignType( Type * paramType, bool maybePolymorphic = true ); 50 51 /// generate the type of a default constructor or destructor for paramType. 52 /// maybePolymorphic is true if the resulting FunctionType is allowed to be polymorphic 53 FunctionType * genDefaultType( Type * paramType, bool maybePolymorphic = true ); 54 55 /// generate the type of a copy constructor for paramType. 56 /// maybePolymorphic is true if the resulting FunctionType is allowed to be polymorphic 57 FunctionType * genCopyType( Type * paramType, bool maybePolymorphic = true ); 47 // generate the type of an assignment function for paramType 48 FunctionType * genAssignType( Type * paramType ); 49 50 // generate the type of a default constructor or destructor for paramType 51 FunctionType * genDefaultType( Type * paramType ); 52 53 // generate the type of a copy constructor for paramType 54 FunctionType * genCopyType( Type * paramType ); 58 55 59 56 /// inserts into out a generated call expression to function fname with arguments dstParam and srcParam. Intended to be used with generated ?=?, ?{}, and ^?{} calls. -
src/SymTab/Validate.cc
rf8b69da7 r546b51e 1333 1333 void FindSpecialDeclarations::previsit( FunctionDecl * funcDecl ) { 1334 1334 if ( ! dereferenceOperator ) { 1335 // find and remember the intrinsic dereference operator for object pointers 1336 if ( funcDecl->name == "*?" && funcDecl->linkage == LinkageSpec::Intrinsic ) { 1337 FunctionType * ftype = funcDecl->type; 1338 if ( ftype->parameters.size() == 1 ) { 1339 PointerType * ptrType = strict_dynamic_cast<PointerType *>( ftype->parameters.front()->get_type() ); 1340 if ( ptrType->base->get_qualifiers() == Type::Qualifiers() ) { 1341 TypeInstType * inst = dynamic_cast<TypeInstType *>( ptrType->base ); 1342 if ( inst && ! inst->get_isFtype() ) { 1343 dereferenceOperator = funcDecl; 1344 } 1345 } 1335 if ( funcDecl->get_name() == "*?" && funcDecl->get_linkage() == LinkageSpec::Intrinsic ) { 1336 FunctionType * ftype = funcDecl->get_functionType(); 1337 if ( ftype->get_parameters().size() == 1 && ftype->get_parameters().front()->get_type()->get_qualifiers() == Type::Qualifiers() ) { 1338 dereferenceOperator = funcDecl; 1346 1339 } 1347 1340 } -
src/SynTree/DeclReplacer.cc
rf8b69da7 r546b51e 38 38 void previsit( TypeInstType * inst ); 39 39 }; 40 41 /// Mutator that replaces uses of declarations with arbitrary expressions, according to the supplied mapping42 struct ExprDeclReplacer {43 private:44 const ExprMap & exprMap;45 bool debug;46 public:47 ExprDeclReplacer( const ExprMap & exprMap, bool debug = false );48 49 // replace variable with new node from expr map50 Expression * postmutate( VariableExpr * varExpr );51 };52 40 } 53 41 … … 65 53 DeclMap declMap; 66 54 replace( node, declMap, typeMap, debug ); 67 }68 69 void replace( BaseSyntaxNode *& node, const ExprMap & exprMap, bool debug ) {70 PassVisitor<ExprDeclReplacer> replacer( exprMap, debug );71 node = maybeMutate( node, replacer );72 55 } 73 56 … … 96 79 } 97 80 } 98 99 ExprDeclReplacer::ExprDeclReplacer( const ExprMap & exprMap, bool debug ) : exprMap( exprMap ), debug( debug ) {}100 101 Expression * ExprDeclReplacer::postmutate( VariableExpr * varExpr ) {102 if ( exprMap.count( varExpr->var ) ) {103 Expression * replacement = exprMap.at( varExpr->var )->clone();104 if ( debug ) {105 std::cerr << "replacing variable reference: " << (void*)varExpr->var << " " << varExpr->var << " with " << (void*)replacement << " " << replacement << std::endl;106 }107 std::swap( varExpr->env, replacement->env );108 delete varExpr;109 return replacement;110 }111 return varExpr;112 }113 81 } 114 82 } // namespace VarExprReplacer -
src/SynTree/DeclReplacer.h
rf8b69da7 r546b51e 26 26 typedef std::map< DeclarationWithType *, DeclarationWithType * > DeclMap; 27 27 typedef std::map< TypeDecl *, TypeDecl * > TypeMap; 28 typedef std::map< DeclarationWithType *, Expression * > ExprMap;29 28 30 29 void replace( BaseSyntaxNode * node, const DeclMap & declMap, bool debug = false ); 31 30 void replace( BaseSyntaxNode * node, const TypeMap & typeMap, bool debug = false ); 32 31 void replace( BaseSyntaxNode * node, const DeclMap & declMap, const TypeMap & typeMap, bool debug = false ); 33 34 void replace( BaseSyntaxNode *& node, const ExprMap & exprMap, bool debug = false);35 template<typename T>36 void replace( T *& node, const ExprMap & exprMap, bool debug = false ) {37 if ( ! node ) return;38 BaseSyntaxNode * arg = node;39 replace( arg, exprMap, debug );40 node = dynamic_cast<T *>( arg );41 assertf( node, "DeclReplacer fundamentally changed the type of its argument." );42 }43 32 } 44 33 -
tests/raii/.expect/memberCtors-ERR1.txt
rf8b69da7 r546b51e 1 raii/memberCtors.c: 92:1 error: in void ?{}(B &b), field a2 used before being constructed1 raii/memberCtors.c:71:1 error: in void ?{}(B &b), field a2 used before being constructed -
tests/raii/.expect/memberCtors.txt
rf8b69da7 r546b51e 1 1 Before declaration of b1 2 constructing int id: 0 3 constructing int id: 1 4 constructing int id: 2 5 default construct A 0 6 constructing int id: 3 7 constructing int id: 4 8 constructing int id: 5 9 default construct A 1 10 begin construct B id: 0 2 constructing int 3 constructing int 4 constructing int 5 constructing int 6 constructing int 7 constructing int 8 begin construct B 11 9 assign b.a2 12 constructing int id: 613 constructing int id: 714 begin construct A id: 215 construct a.x 16 constructing int: 1001 id: 817 assign a.y 18 assigning int: 0 0 id: 619 end construct A 20 copy constructing int: 0 id: 921 copy constructing int: 0 id: 1022 begin copy construct A id: 323 copy construct this.x 24 copy constructing int: 1001 id: 1125 assign this.y 26 copy constructing int: 0 id: 1227 destructing int: 0 id: 1228 destructing int: 0 id: 1229 end copy construct A 30 begin ?=? A id: 031 copy constructing int: 1001 id: 1332 destructing int: 1001 id: 1333 destructing int: 1001 id: 1334 copy constructing int: 0 id: 1435 destructing int: 0 id: 1436 destructing int: 0 id: 1437 copy constructing int: 0 id: 1538 destructing int: 0 id: 1539 destructing int: 0 id: 1510 constructing int 11 constructing int 12 begin construct A 13 construct a.x 14 constructing int: 1001 15 assign a.y 16 assigning int: 0 0 17 end construct A 18 copy constructing int: 0 19 copy constructing int: 0 20 begin copy construct A 21 copy construct this.x 22 copy constructing int: 1001 23 assign this.y 24 copy constructing int: 0 25 destructing int: 0 26 destructing int: 0 27 end copy construct A 28 begin ?=? A 29 copy constructing int: 1001 30 destructing int: 1001 31 destructing int: 1001 32 copy constructing int: 0 33 destructing int: 0 34 destructing int: 0 35 copy constructing int: 0 36 destructing int: 0 37 destructing int: 0 40 38 end ?=? A 41 copy constructing int: 0 id: 1642 copy constructing int: 0 id: 1743 begin copy construct A id: 444 copy construct this.x 45 copy constructing int: 1001 id: 1846 assign this.y 47 copy constructing int: 0 id: 1948 destructing int: 0 id: 1949 destructing int: 0 id: 1950 end copy construct A 51 destructing int: 0 id: 1752 destructing int: 0 id: 1953 destructing int: 1001 id: 1854 destructing int: 0 id: 1055 destructing int: 0 id: 1256 destructing int: 1001 id: 1139 copy constructing int: 0 40 copy constructing int: 0 41 begin copy construct A 42 copy construct this.x 43 copy constructing int: 1001 44 assign this.y 45 copy constructing int: 0 46 destructing int: 0 47 destructing int: 0 48 end copy construct A 49 destructing int: 0 50 destructing int: 0 51 destructing int: 1001 52 destructing int: 0 53 destructing int: 0 54 destructing int: 1001 57 55 construct b.a1 58 constructing int id: 2059 constructing int id: 2160 begin construct A id: 561 construct a.x 62 constructing int: 1000 id: 2263 assign a.y 64 assigning int: 0 0 id: 2056 constructing int 57 constructing int 58 begin construct A 59 construct a.x 60 constructing int: 1000 61 assign a.y 62 assigning int: 0 0 65 63 end construct A 66 64 end construct B 67 destructing int: 0 id: 768 destructing int: 0 id: 669 destructing int: 1001 id: 865 destructing int: 0 66 destructing int: 0 67 destructing int: 1001 70 68 Before declaration of b2 71 copy constructing int: 0 id: 2372 copy constructing int: 0 id: 2473 begin copy construct A id: 674 copy construct this.x 75 copy constructing int: 1000 id: 2576 assign this.y 77 copy constructing int: 0 id: 2678 destructing int: 0 id: 2679 destructing int: 0 id: 2680 end copy construct A 81 copy constructing int: 0 id: 2782 copy constructing int: 0 id: 2883 begin copy construct A id: 784 copy construct this.x 85 copy constructing int: 1001 id: 2986 assign this.y 87 copy constructing int: 0 id: 3088 destructing int: 0 id: 3089 destructing int: 0 id: 3090 end copy construct A 91 copy constructing int: 0 id: 3192 copy constructing int: 0 id: 3293 begin copy construct A id: 894 copy construct this.x 95 copy constructing int: 0 id: 3396 assign this.y 97 copy constructing int: 0 id: 3498 destructing int: 0 id: 3499 destructing int: 0 id: 3469 copy constructing int: 0 70 copy constructing int: 0 71 begin copy construct A 72 copy construct this.x 73 copy constructing int: 1000 74 assign this.y 75 copy constructing int: 0 76 destructing int: 0 77 destructing int: 0 78 end copy construct A 79 copy constructing int: 0 80 copy constructing int: 0 81 begin copy construct A 82 copy construct this.x 83 copy constructing int: 1001 84 assign this.y 85 copy constructing int: 0 86 destructing int: 0 87 destructing int: 0 88 end copy construct A 89 copy constructing int: 0 90 copy constructing int: 0 91 begin copy construct A 92 copy construct this.x 93 copy constructing int: 0 94 assign this.y 95 copy constructing int: 0 96 destructing int: 0 97 destructing int: 0 100 98 end copy construct A 101 99 End of main 102 begin destruct B id: 1 103 constructing int id: 35 104 constructing int id: 36 105 begin construct A id: 9 106 construct a.x 107 constructing int: 999 id: 37 108 assign a.y 109 assigning int: 0 0 id: 35 110 end construct A 111 copy constructing int: 0 id: 38 112 copy constructing int: 0 id: 39 113 begin copy construct A id: 10 114 copy construct this.x 115 copy constructing int: 999 id: 40 116 assign this.y 117 copy constructing int: 0 id: 41 118 destructing int: 0 id: 41 119 destructing int: 0 id: 41 120 end copy construct A 121 begin ?=? A id: 7 122 copy constructing int: 999 id: 42 123 destructing int: 999 id: 42 124 destructing int: 999 id: 42 125 copy constructing int: 0 id: 43 126 destructing int: 0 id: 43 127 destructing int: 0 id: 43 128 copy constructing int: 0 id: 44 129 destructing int: 0 id: 44 130 destructing int: 0 id: 44 100 constructing int 101 constructing int 102 begin construct A 103 construct a.x 104 constructing int: 999 105 assign a.y 106 assigning int: 0 0 107 end construct A 108 copy constructing int: 0 109 copy constructing int: 0 110 begin copy construct A 111 copy construct this.x 112 copy constructing int: 999 113 assign this.y 114 copy constructing int: 0 115 destructing int: 0 116 destructing int: 0 117 end copy construct A 118 begin ?=? A 119 copy constructing int: 999 120 destructing int: 999 121 destructing int: 999 122 copy constructing int: 0 123 destructing int: 0 124 destructing int: 0 125 copy constructing int: 0 126 destructing int: 0 127 destructing int: 0 131 128 end ?=? A 132 copy constructing int: 0 id: 45 133 copy constructing int: 0 id: 46 134 begin copy construct A id: 11 135 copy construct this.x 136 copy constructing int: 999 id: 47 137 assign this.y 138 copy constructing int: 0 id: 48 139 destructing int: 0 id: 48 140 destructing int: 0 id: 48 141 end copy construct A 142 destructing int: 0 id: 46 143 destructing int: 0 id: 48 144 destructing int: 999 id: 47 145 destructing int: 0 id: 39 146 destructing int: 0 id: 41 147 destructing int: 999 id: 40 148 destructing int: 0 id: 24 149 destructing int: 0 id: 26 150 destructing int: 1000 id: 25 151 end destruct B 152 destructing int: 0 id: 36 153 destructing int: 0 id: 35 154 destructing int: 999 id: 37 155 destructing int: 0 id: 32 156 destructing int: 0 id: 34 157 destructing int: 0 id: 33 158 destructing int: 0 id: 44 159 destructing int: 0 id: 43 160 destructing int: 999 id: 42 161 begin destruct B id: 2 162 constructing int id: 49 163 constructing int id: 50 164 begin construct A id: 12 165 construct a.x 166 constructing int: 999 id: 51 167 assign a.y 168 assigning int: 0 0 id: 49 169 end construct A 170 copy constructing int: 0 id: 52 171 copy constructing int: 0 id: 53 172 begin copy construct A id: 13 173 copy construct this.x 174 copy constructing int: 999 id: 54 175 assign this.y 176 copy constructing int: 0 id: 55 177 destructing int: 0 id: 55 178 destructing int: 0 id: 55 179 end copy construct A 180 begin ?=? A id: 0 181 copy constructing int: 999 id: 56 182 destructing int: 999 id: 56 183 destructing int: 999 id: 56 184 copy constructing int: 0 id: 57 185 destructing int: 0 id: 57 186 destructing int: 0 id: 57 187 copy constructing int: 0 id: 58 188 destructing int: 0 id: 58 189 destructing int: 0 id: 58 129 copy constructing int: 0 130 copy constructing int: 0 131 begin copy construct A 132 copy construct this.x 133 copy constructing int: 999 134 assign this.y 135 copy constructing int: 0 136 destructing int: 0 137 destructing int: 0 138 end copy construct A 139 destructing int: 0 140 destructing int: 0 141 destructing int: 999 142 destructing int: 0 143 destructing int: 0 144 destructing int: 999 145 destructing int: 0 146 destructing int: 0 147 destructing int: 1000 148 destructing int: 0 149 destructing int: 0 150 destructing int: 999 151 destructing int: 0 152 destructing int: 0 153 destructing int: 0 154 destructing int: 0 155 destructing int: 0 156 destructing int: 999 157 constructing int 158 constructing int 159 begin construct A 160 construct a.x 161 constructing int: 999 162 assign a.y 163 assigning int: 0 0 164 end construct A 165 copy constructing int: 0 166 copy constructing int: 0 167 begin copy construct A 168 copy construct this.x 169 copy constructing int: 999 170 assign this.y 171 copy constructing int: 0 172 destructing int: 0 173 destructing int: 0 174 end copy construct A 175 begin ?=? A 176 copy constructing int: 999 177 destructing int: 999 178 destructing int: 999 179 copy constructing int: 0 180 destructing int: 0 181 destructing int: 0 182 copy constructing int: 0 183 destructing int: 0 184 destructing int: 0 190 185 end ?=? A 191 copy constructing int: 0 id: 59 192 copy constructing int: 0 id: 60 193 begin copy construct A id: 14 194 copy construct this.x 195 copy constructing int: 999 id: 61 196 assign this.y 197 copy constructing int: 0 id: 62 198 destructing int: 0 id: 62 199 destructing int: 0 id: 62 200 end copy construct A 201 destructing int: 0 id: 60 202 destructing int: 0 id: 62 203 destructing int: 999 id: 61 204 destructing int: 0 id: 53 205 destructing int: 0 id: 55 206 destructing int: 999 id: 54 207 destructing int: 0 id: 21 208 destructing int: 0 id: 20 209 destructing int: 1000 id: 22 210 end destruct B 211 destructing int: 0 id: 50 212 destructing int: 0 id: 49 213 destructing int: 999 id: 51 214 destructing int: 0 id: 5 215 destructing int: 0 id: 4 216 destructing int: 0 id: 3 217 destructing int: 0 id: 58 218 destructing int: 0 id: 57 219 destructing int: 999 id: 56 186 copy constructing int: 0 187 copy constructing int: 0 188 begin copy construct A 189 copy construct this.x 190 copy constructing int: 999 191 assign this.y 192 copy constructing int: 0 193 destructing int: 0 194 destructing int: 0 195 end copy construct A 196 destructing int: 0 197 destructing int: 0 198 destructing int: 999 199 destructing int: 0 200 destructing int: 0 201 destructing int: 999 202 destructing int: 0 203 destructing int: 0 204 destructing int: 1000 205 destructing int: 0 206 destructing int: 0 207 destructing int: 999 208 destructing int: 0 209 destructing int: 0 210 destructing int: 0 211 destructing int: 0 212 destructing int: 0 213 destructing int: 999 -
tests/raii/memberCtors.c
rf8b69da7 r546b51e 1 1 struct WrappedInt { 2 2 int x; 3 int id;4 3 }; 5 int intID = 0;6 4 7 5 void ?{}(WrappedInt & this) { 8 this.id = intID++; 9 printf("constructing int id: %d\n", this.id); 6 printf("constructing int\n"); 10 7 this.x = 0; 11 8 } 12 9 13 10 void ?{}(WrappedInt & this, WrappedInt other) { 14 this.id = intID++; 15 printf("copy constructing int: %d id: %d\n", other.x, this.id); 11 printf("copy constructing int: %d\n", other.x); 16 12 this.x = other.x; 17 13 } 18 14 19 15 void ?{}(WrappedInt & this, int x) { 20 this.id = intID++; 21 printf("constructing int: %d id: %d\n", x, this.id); 16 printf("constructing int: %d\n", x); 22 17 this.x = x; 23 18 } 24 19 25 20 void ^?{}(WrappedInt & this) { 26 printf("destructing int: %d id: %d\n", this.x, this.id);21 printf("destructing int: %d\n", this.x); 27 22 } 28 23 29 /* WrappedInt */void ?=?(WrappedInt & this, int x) {30 printf("assigning int: %d %d id: %d\n", this.x, x, this.id);24 void ?=?(WrappedInt & this, int x) { 25 printf("assigning int: %d %d\n", this.x, x); 31 26 this.x = x; 32 // return this;33 27 } 34 35 // WrappedInt ?=?(WrappedInt & this, WrappedInt other) {36 // printf("assigning int: %d %d\n", this.x, other.x);37 // this.x = other.x;38 // return this;39 // }40 28 41 29 struct A { 42 30 WrappedInt x, y, z; 43 int id;44 31 }; 45 int AID = 0;46 32 47 33 void ?{}(A & a) { 48 34 // currently must define default ctor, since there's no "= default" syntax 49 a.id = AID++;50 printf("default construct A %d\n", a.id);51 35 } 52 36 53 37 void ?{}(A & a, int x) { 54 a.id = AID++; 55 printf("begin construct A id: %d\n", a.id); 38 printf("begin construct A\n"); 56 39 printf("construct a.x\n"); 57 40 (a.x){ x+999 }; … … 62 45 63 46 void ?{}(A & this, A other) { 64 this.id = AID++; 65 printf("begin copy construct A id: %d\n", this.id); 47 printf("begin copy construct A\n"); 66 48 printf("copy construct this.x\n"); 67 49 (this.x){ other.x }; … … 72 54 73 55 A ?=?(A & this, A other) { 74 printf("begin ?=? A id: %d\n", this.id);56 printf("begin ?=? A\n"); 75 57 this.x = other.x; 76 58 this.y = other.y; … … 82 64 struct B { 83 65 A a1, a2, a3; 84 int id;85 66 }; 86 int BID = 0;87 67 88 68 void ?{}(B & b) { 89 b.id = BID++; 90 printf("begin construct B id: %d\n", b.id); 69 printf("begin construct B\n"); 91 70 printf("assign b.a2\n"); 92 71 b.a2 = (A) { 2 }; … … 100 79 101 80 void ^?{}(B & b) { 102 b.id = BID++;103 printf("begin destruct B id: %d\n", b.id);104 81 b.a2 = (A) { 0 }; 105 82 ^(b.a1){}; 106 printf("end destruct B\n");107 83 } // a2, a3 never destructed - will be automatically destructed 108 84 109 85 int main() { 110 86 printf("Before declaration of b1\n"); 111 B b1; // b1 = { { 1000, 0, 0 }, { 1001, 0, 0 }, { 0, 0, 0 } }87 B b1; 112 88 printf("Before declaration of b2\n"); 113 89 B b2 = b1;
Note:
See TracChangeset
for help on using the changeset viewer.