Changeset 5465377c

Timestamp:

Nov 12, 2020, 1:25:42 PM (4 years ago)

Author:

Fangren Yu <f37yu@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

3746f777

Parents:

1d379b5

Message:

fix array_dim problem in old ast

File:

• src/InitTweak/GenInit.cc (modified) (1 diff)

src/InitTweak/GenInit.cc

@@ -202 +202 @@
                         }
                         // don't need to hoist dimension if it's definitely pure - only need to if there's potential for side effects.
-                        // xxx - hoisting has no side effects anyways, so don't skip since we delay resolve     
-                        // only skip in the most trivial case, which does not require resolve
-                        if (dynamic_cast<ConstantExpr *>(arrayType->dimension)) return;
-                        // if ( ! Tuples::maybeImpure( arrayType->dimension ) ) return;
+                        // xxx - hoisting has no side effects anyways, so don't skip since we delay resolve
+                        // still try to detect constant expressions
+                        if ( ! Tuples::maybeImpure( arrayType->dimension ) ) return;
 
                         ObjectDecl * arrayDimension = new ObjectDecl( dimensionName.newName(), storageClasses, LinkageSpec::C, 0, Validate::SizeType->clone(), new SingleInit( arrayType->get_dimension() ) );