Changeset 52c14b3

Timestamp:

Feb 8, 2017, 9:51:14 AM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

4fbdd1e3, 84e2523, b7b8674

Parents:

35b1bf4

Message:

fix scoping issues for labels when inserting destructors

File:

• src/InitTweak/FixInit.cc (modified) (7 diffs)

src/InitTweak/FixInit.cc

@@ -104 +104 @@
                         virtual void visit( CompoundStmt *compoundStmt ) override;
                         virtual void visit( DeclStmt *stmt ) override;
+
+                        // don't go into other functions
+                        virtual void visit( FunctionDecl *decl ) override {}
+
                   protected:
                         ObjectSet curVars;
@@ -166 +170 @@
                         typedef std::list< OrderedDecls > OrderedDeclsStack;
 
-                        InsertDtors( LabelFinder & finder ) : labelVars( finder.vars ) {}
+                        InsertDtors( LabelFinder & finder ) : finder( finder ), labelVars( finder.vars ) {}
 
                         using Parent::visit;
 
                         virtual void visit( ObjectDecl * objDecl ) override;
+                        virtual void visit( FunctionDecl * funcDecl ) override;
 
                         virtual void visit( CompoundStmt * compoundStmt ) override;
@@ -178 +183 @@
                         void handleGoto( BranchStmt * stmt );
 
+                        LabelFinder & finder;
                         LabelFinder::LabelMap & labelVars;
                         OrderedDeclsStack reverseDeclOrder;
@@ -318 +324 @@
                         LabelFinder finder;
                         InsertDtors inserter( finder );
-                        acceptAll( translationUnit, finder );
                         acceptAll( translationUnit, inserter );
                 }
@@ -778 +783 @@
                 }
 
-                void ObjDeclCollector::visit( CompoundStmt *compoundStmt ) {
+                void ObjDeclCollector::visit( CompoundStmt * compoundStmt ) {
                         std::set< ObjectDecl * > prevVars = curVars;
                         Parent::visit( compoundStmt );
@@ -784 +789 @@
                 }
 
-                void ObjDeclCollector::visit( DeclStmt *stmt ) {
+                void ObjDeclCollector::visit( DeclStmt * stmt ) {
                         // keep track of all variables currently in scope
                         if ( ObjectDecl * objDecl = dynamic_cast< ObjectDecl * > ( stmt->get_decl() ) ) {
@@ -828 +833 @@
                         } // if
                         Parent::visit( objDecl );
+                }
+
+                template< typename Visitor >
+                void handleFuncDecl( FunctionDecl * funcDecl, Visitor & visitor ) {
+                        maybeAccept( funcDecl->get_functionType(), visitor );
+                        acceptAll( funcDecl->get_oldDecls(), visitor );
+                        maybeAccept( funcDecl->get_statements(), visitor );
+                }
+
+                void InsertDtors::visit( FunctionDecl * funcDecl ) {
+                        // each function needs to have its own set of labels
+                        ValueGuard< LabelFinder::LabelMap > oldLabels( labelVars );
+                        labelVars.clear();
+                        handleFuncDecl( funcDecl, finder );
+
+                        // all labels for this function have been collected, insert destructors as appropriate.
+                        // can't be Parent::mutate, because ObjDeclCollector bottoms out on FunctionDecl
+                        handleFuncDecl( funcDecl, *this );
                 }