Changeset 4ee1efb for src/SynTree

Timestamp:

Oct 26, 2017, 11:23:26 AM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, arm-eh, ast-experimental, cleanup-dtors, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

136ccd7

Parents:

0b9be4d (diff), 598f50e (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

git-author:

Rob Schluntz <rschlunt@…> (10/26/17 10:43:08)

git-committer:

Rob Schluntz <rschlunt@…> (10/26/17 11:23:26)

Message:

Merge branch 'fix-missing-cast-warning' into cleanup-dtors

Location:

src/SynTree

Files:

• ApplicationExpr.cc (modified) (3 diffs)
• Expression.cc (modified) (2 diffs)
• Expression.h (modified) (4 diffs)
• Type.h (modified) (1 diff)

src/SynTree/ApplicationExpr.cc

@@ -59 +59 @@
 
 ApplicationExpr::ApplicationExpr( const ApplicationExpr &other ) :
-                Expression( other ), function( maybeClone( other.function ) ), inferParams( other.inferParams ) {
+                Expression( other ), function( maybeClone( other.function ) ) {
         cloneAll( other.args, args );
 }
@@ -66 +66 @@
         delete function;
         deleteAll( args );
-}
-
-void printInferParams( const InferredParams & inferParams, std::ostream &os, Indenter indent, int level ) {
-        if ( ! inferParams.empty() ) {
-                os << indent << "with inferred parameters " << level << ":" << std::endl;
-                for ( InferredParams::const_iterator i = inferParams.begin(); i != inferParams.end(); ++i ) {
-                        os << indent+1;
-                        Declaration::declFromId( i->second.decl )->printShort( os, indent+1 );
-                        os << std::endl;
-                        printInferParams( *i->second.inferParams, os, indent+1, level+1 );
-                } // for
-        } // if
 }
 
@@ -88 +76 @@
                 printAll( args, os, indent+1 );
         } // if
-        printInferParams( inferParams, os, indent+1, 0 );
         Expression::print( os, indent );
 }

src/SynTree/Expression.cc

@@ -33 +33 @@
 #include "GenPoly/Lvalue.h"
 
+void printInferParams( const InferredParams & inferParams, std::ostream &os, Indenter indent, int level ) {
+        if ( ! inferParams.empty() ) {
+                os << indent << "with inferred parameters " << level << ":" << std::endl;
+                for ( InferredParams::const_iterator i = inferParams.begin(); i != inferParams.end(); ++i ) {
+                        os << indent+1;
+                        Declaration::declFromId( i->second.decl )->printShort( os, indent+1 );
+                        os << std::endl;
+                        printInferParams( *i->second.inferParams, os, indent+1, level+1 );
+                } // for
+        } // if
+}
+
 Expression::Expression() : result( 0 ), env( 0 ) {}
 
-Expression::Expression( const Expression &other ) : BaseSyntaxNode( other ), result( maybeClone( other.result ) ), env( maybeClone( other.env ) ), extension( other.extension ) {
+Expression::Expression( const Expression &other ) : BaseSyntaxNode( other ), result( maybeClone( other.result ) ), env( maybeClone( other.env ) ), extension( other.extension ), inferParams( other.inferParams ) {
 }
 
@@ -44 +56 @@
 
 void Expression::print( std::ostream &os, Indenter indent ) const {
+        printInferParams( inferParams, os, indent+1, 0 );
+
         if ( env ) {
                 os << std::endl << indent << "... with environment:" << std::endl;

src/SynTree/Expression.h

@@ -31 +31 @@
 
 
-/// Expression is the root type for all expressions
-class Expression : public BaseSyntaxNode{
-  public:
-        Type * result;
-        TypeSubstitution * env;
-        bool extension = false;
-
-        Expression();
-        Expression( const Expression & other );
-        virtual ~Expression();
-
-        Type *& get_result() { return result; }
-        const Type * get_result() const { return result; }
-        void set_result( Type * newValue ) { result = newValue; }
-
-        TypeSubstitution * get_env() const { return env; }
-        void set_env( TypeSubstitution * newValue ) { env = newValue; }
-        bool get_extension() const { return extension; }
-        Expression * set_extension( bool exten ) { extension = exten; return this; }
-
-        virtual Expression * clone() const override = 0;
-        virtual void accept( Visitor & v ) override = 0;
-        virtual Expression * acceptMutator( Mutator & m ) override = 0;
-        virtual void print( std::ostream & os, Indenter indent = {} ) const override;
-};
-
 struct ParamEntry;
 
@@ -73 +47 @@
         Type * actualType;
         Type * formalType;
-        Expression* expr;
+        Expression * expr;
         std::unique_ptr< InferredParams > inferParams;
+};
+
+/// Expression is the root type for all expressions
+class Expression : public BaseSyntaxNode {
+  public:
+        Type * result;
+        TypeSubstitution * env;
+        bool extension = false;
+        InferredParams inferParams;
+
+        Expression();
+        Expression( const Expression & other );
+        virtual ~Expression();
+
+        Type *& get_result() { return result; }
+        const Type * get_result() const { return result; }
+        void set_result( Type * newValue ) { result = newValue; }
+
+        TypeSubstitution * get_env() const { return env; }
+        void set_env( TypeSubstitution * newValue ) { env = newValue; }
+        bool get_extension() const { return extension; }
+        Expression * set_extension( bool exten ) { extension = exten; return this; }
+
+        InferredParams & get_inferParams() { return inferParams; }
+
+        virtual Expression * clone() const override = 0;
+        virtual void accept( Visitor & v ) override = 0;
+        virtual Expression * acceptMutator( Mutator & m ) override = 0;
+        virtual void print( std::ostream & os, Indenter indent = {} ) const override;
 };
 
@@ -83 +86 @@
         Expression * function;
         std::list<Expression *> args;
-        InferredParams inferParams;
 
         ApplicationExpr( Expression * function, const std::list<Expression *> & args = std::list< Expression * >() );
@@ -92 +94 @@
         void set_function( Expression * newValue ) { function = newValue; }
         std::list<Expression *>& get_args() { return args; }
-        InferredParams & get_inferParams() { return inferParams; }
 
         virtual ApplicationExpr * clone() const { return new ApplicationExpr( * this ); }

src/SynTree/Type.h

@@ -298 +298 @@
         void set_isStatic( bool newValue ) { isStatic = newValue; }
 
-        virtual bool isComplete() const override { return ! isVarLen; }
+        // array types are complete if they have a dimension expression or are
+        // VLAs ('*' in parameter declaration), and incomplete otherwise.
+        // See 6.7.6.2
+        virtual bool isComplete() const override { return dimension || isVarLen; }
 
         virtual ArrayType *clone() const override { return new ArrayType( *this ); }