Changeset 4bdb7bf for libcfa

Timestamp:

Aug 31, 2021, 1:49:10 AM (3 years ago)

Author:

Jacob Prud'homme <jafprudhomme@…>

Branches:

ADT, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, pthread-emulation, qualifiedEnum

Children:

cac1d52

Parents:

5241ec2

git-author:

Jacob Prud'homme <jafprudhomme@…> (08/06/21 03:03:42)

git-committer:

Jacob Prud'homme <jafprudhomme@…> (08/31/21 01:49:10)

Message:

Fixed some issues with unfreed memory

Was calling destructor on contents of pointer, without freeing actual data allocated at pointer

File:

• libcfa/src/parseconfig.cfa (modified) (3 diffs)

libcfa/src/parseconfig.cfa

@@ -91 +91 @@
                 } // for
         } catch( Open_Failure * ex; ex->istream == &in ) {
-                ^(*kv_pairs){};
+                delete( kv_pairs );
                 exit | "Error: could not open input file '" | config_file | "'";
                 // HERE (unfreed storage)
@@ -124 +124 @@
                                 // Validate the parsed data, if necessary
                                 if ( entries[j].validate != (bool (*)(void *))0p ) {
-                                        if ( !entries[j].validate( entries[j].variable ) ) throw (Validation_Failure){ entries[j] }; // HERE (segfaults on throw)
+                                        if ( !entries[j].validate( entries[j].variable ) ) {
+                                                delete( kv_pairs );
+                                                throw (Validation_Failure){ entries[j] };
+                                        }
                                 }
 
@@ -134 +137 @@
         }
 
-        ^(*kv_pairs){};
-        // HERE (unfreed storage)
+        delete( kv_pairs );
 } // processConfigFile