Changeset 4bb5d36


Ignore:
Timestamp:
May 16, 2022, 12:09:52 PM (3 months ago)
Author:
Thierry Delisle <tdelisle@…>
Branches:
master
Children:
fa2a3b1
Parents:
c18bf9e
Message:

Visibility stragglers.
cfa_linkonce always means visibility default.

Files:
3 edited

Legend:

Unmodified
Added
Removed
  • libcfa/src/bits/debug.cfa

    rc18bf9e r4bb5d36  
    2121#include <unistd.h>
    2222
     23#include "bits/defs.hfa"
     24
    2325enum { buffer_size = 4096 };
    2426static char buffer[ buffer_size ];
    2527
    2628extern "C" {
    27         void __cfaabi_bits_write( int fd, const char in_buffer[], int len ) {
     29        // would be cool to remove libcfa_public but it's needed for libcfathread
     30        void __cfaabi_bits_write( int fd, const char in_buffer[], int len ) libcfa_public {
    2831                // ensure all data is written
    2932                for ( int count = 0, retcode; count < len; count += retcode ) {
     
    4447        void __cfaabi_bits_release() __attribute__((__weak__)) {}
    4548
    46         int __cfaabi_bits_print_safe  ( int fd, const char fmt[], ... ) __attribute__(( format(printf, 2, 3) )) {
     49        // would be cool to remove libcfa_public but it's needed for libcfathread
     50        int __cfaabi_bits_print_safe  ( int fd, const char fmt[], ... ) __attribute__(( format(printf, 2, 3) )) libcfa_public {
    4751                va_list args;
    4852
  • libcfa/src/parseconfig.cfa

    rc18bf9e r4bb5d36  
    2020
    2121// TODO: Add names of missing config entries to exception (see further below)
    22 static vtable(Missing_Config_Entries) Missing_Config_Entries_vt;
     22vtable(Missing_Config_Entries) Missing_Config_Entries_vt;
    2323
    2424[ void ] ?{}( & Missing_Config_Entries this, unsigned int num_missing ) {
     
    3333
    3434
    35 static vtable(Parse_Failure) Parse_Failure_vt;
     35vtable(Parse_Failure) Parse_Failure_vt;
    3636
    3737[ void ] ?{}( & Parse_Failure this, [] char failed_key, [] char failed_value ) {
     
    5555
    5656
    57 static vtable(Validation_Failure) Validation_Failure_vt;
     57vtable(Validation_Failure) Validation_Failure_vt;
    5858
    5959[ void ] ?{}( & Validation_Failure this, [] char failed_key, [] char failed_value ) {
  • src/CodeGen/LinkOnce.cc

    rc18bf9e r4bb5d36  
    5353                                new ConstantExpr( Constant::from_string( section_name ) )
    5454                        );
     55
     56                        // Unconditionnaly add "visibility(default)" to anything with gnu.linkonce
     57                        // visibility is a mess otherwise
     58                        attributes.push_back(new Attribute("visibility", {new ConstantExpr( Constant::from_string( "default" ) )}));
     59
    5560                }
    5661                visit_children = false;
Note: See TracChangeset for help on using the changeset viewer.