Changeset 4bb5d36

Timestamp:

May 16, 2022, 12:09:52 PM (2 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, ast-experimental, master, pthread-emulation, qualifiedEnum

Children:

fa2a3b1

Parents:

c18bf9e

Message:

Visibility stragglers.
cfa_linkonce always means visibility default.

Files:

• libcfa/src/bits/debug.cfa (modified) (2 diffs)
• libcfa/src/parseconfig.cfa (modified) (3 diffs)
• src/CodeGen/LinkOnce.cc (modified) (1 diff)

libcfa/src/bits/debug.cfa

@@ -21 +21 @@
 #include <unistd.h>
 
+#include "bits/defs.hfa"
+
 enum { buffer_size = 4096 };
 static char buffer[ buffer_size ];
 
 extern "C" {
-        void __cfaabi_bits_write( int fd, const char in_buffer[], int len ) {
+        // would be cool to remove libcfa_public but it's needed for libcfathread
+        void __cfaabi_bits_write( int fd, const char in_buffer[], int len ) libcfa_public {
                 // ensure all data is written
                 for ( int count = 0, retcode; count < len; count += retcode ) {
@@ -44 +47 @@
         void __cfaabi_bits_release() __attribute__((__weak__)) {}
 
-        int __cfaabi_bits_print_safe  ( int fd, const char fmt[], ... ) __attribute__(( format(printf, 2, 3) )) {
+        // would be cool to remove libcfa_public but it's needed for libcfathread
+        int __cfaabi_bits_print_safe  ( int fd, const char fmt[], ... ) __attribute__(( format(printf, 2, 3) )) libcfa_public {
                 va_list args;
 

libcfa/src/parseconfig.cfa

@@ -20 +20 @@
 
 // TODO: Add names of missing config entries to exception (see further below)
-static vtable(Missing_Config_Entries) Missing_Config_Entries_vt;
+vtable(Missing_Config_Entries) Missing_Config_Entries_vt;
 
 [ void ] ?{}( & Missing_Config_Entries this, unsigned int num_missing ) {
@@ -33 +33 @@
 
 
-static vtable(Parse_Failure) Parse_Failure_vt;
+vtable(Parse_Failure) Parse_Failure_vt;
 
 [ void ] ?{}( & Parse_Failure this, [] char failed_key, [] char failed_value ) {
@@ -55 +55 @@
 
 
-static vtable(Validation_Failure) Validation_Failure_vt;
+vtable(Validation_Failure) Validation_Failure_vt;
 
 [ void ] ?{}( & Validation_Failure this, [] char failed_key, [] char failed_value ) {

src/CodeGen/LinkOnce.cc

@@ -53 +53 @@
                                 new ConstantExpr( Constant::from_string( section_name ) )
                         );
+
+                        // Unconditionnaly add "visibility(default)" to anything with gnu.linkonce
+                        // visibility is a mess otherwise
+                        attributes.push_back(new Attribute("visibility", {new ConstantExpr( Constant::from_string( "default" ) )}));
+
                 }
                 visit_children = false;