Changeset 4b97770 for src/SymTab

Timestamp:

Jan 3, 2018, 10:40:02 AM (8 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

6138d0f, b834e98

Parents:

be9aa0f

Message:

Add error handling for C-style initialization of VLAs

File:

• src/SymTab/Validate.cc (modified) (1 diff)

src/SymTab/Validate.cc

@@ -754 +754 @@
                                 throw SemanticError( "Cannot redefine typedef: " + tyDecl->name );
                         }
-                        // cannot redefine VLA typedefs
+                        // Cannot redefine VLA typedefs. Note: this is slightly incorrect, because our notion of VLAs
+                        // at this point in the translator is imprecise. In particular, this will disallow redefining typedefs
+                        // with arrays whose dimension is an enumerator or a cast of a constant/enumerator. The effort required
+                        // to fix this corner case likely outweighs the utility of allowing it.
                         if ( isVariableLength( t1 ) || isVariableLength( t2 ) ) {
                                 throw SemanticError( "Cannot redefine typedef: " + tyDecl->name );