Changeset 4a368547 for src/libcfa/concurrency

Timestamp:

May 29, 2017, 3:08:47 PM (8 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

2ab67b9, a029714

Parents:

ff98952 (diff), 4c5b972 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

Location:

src/libcfa/concurrency

Files:

• monitor (modified) (2 diffs)
• monitor.c (modified) (13 diffs)
• thread (modified) (1 diff)
• thread.c (modified) (1 diff)

src/libcfa/concurrency/monitor

@@ -59 +59 @@
         unsigned short count;                           //Number of criterions in the criteria
         __condition_node_t * next;                      //Intrusive linked list Next field
+        uintptr_t user_info;                            //Custom user info accessible before signalling
 };
 
@@ -85 +86 @@
 }
 
-void wait( condition * this );
-void signal( condition * this );
+void wait( condition * this, uintptr_t user_info = 0 );
+bool signal( condition * this );
+bool signal_block( condition * this );
+static inline bool is_empty( condition * this ) { return !this->blocked.head; }
+uintptr_t front( condition * this );
+
 #endif //MONITOR_H

src/libcfa/concurrency/monitor.c

@@ -62 +62 @@
                         //Some one else has the monitor, wait in line for it
                         append( &this->entry_queue, thrd );
+                        LIB_DEBUG_PRINT_SAFE("%p Blocking on entry\n", thrd);
                         ScheduleInternal( &this->lock );
 
@@ -97 +98 @@
                 unlock( &this->lock );
 
+                LIB_DEBUG_PRINT_SAFE("Next owner is %p\n", new_owner);
+
                 //We need to wake-up the thread
                 ScheduleThread( new_owner );
@@ -134 +137 @@
 }
 
-void debug_break() __attribute__(( noinline ))
-{
-        
+void ?{}(__condition_node_t * this, thread_desc * waiting_thread, unsigned short count, uintptr_t user_info ) {
+        this->waiting_thread = waiting_thread;
+        this->count = count;
+        this->next = NULL;
+        this->user_info = user_info;
+}
+
+void ?{}(__condition_criterion_t * this ) {
+        this->ready  = false;
+        this->target = NULL;
+        this->owner  = NULL;
+        this->next   = NULL;
+}
+
+void ?{}(__condition_criterion_t * this, monitor_desc * target, __condition_node_t * owner ) {
+        this->ready  = false;
+        this->target = target;
+        this->owner  = owner;
+        this->next   = NULL;
 }
 
 //-----------------------------------------------------------------------------
 // Internal scheduling
-void wait( condition * this ) {
+void wait( condition * this, uintptr_t user_info = 0 ) {
         LIB_DEBUG_PRINT_SAFE("Waiting\n");
 
@@ -149 +168 @@
         assertf( this->monitors != NULL, "Waiting with no monitors (%p)", this->monitors );
         assertf( this->monitor_count != 0, "Waiting with 0 monitors (%i)", this->monitor_count );
+        assertf( this->monitor_count < 32u, "Excessive monitor count (%i)", this->monitor_count );
 
         unsigned short count = this->monitor_count;
@@ -156 +176 @@
         LIB_DEBUG_PRINT_SAFE("count %i\n", count);
 
-        __condition_node_t waiter;
-        waiter.waiting_thread = this_thread();
-        waiter.count = count;
-        waiter.next = NULL;
+        __condition_node_t waiter = { this_thread(), count, user_info };
 
         __condition_criterion_t criteria[count];
         for(int i = 0; i < count; i++) {
-                criteria[i].ready  = false;
-                criteria[i].target = this->monitors[i];
-                criteria[i].owner  = &waiter;
-                criteria[i].next   = NULL;
+                (&criteria[i]){ this->monitors[i], &waiter };
                 LIB_DEBUG_PRINT_SAFE( "Criterion %p\n", &criteria[i] );
         }
@@ -184 +198 @@
         }
 
-        debug_break();
-
         for( int i = 0; i < count; i++) {
                 thread_desc * new_owner = next_thread( this->monitors[i] );
@@ -191 +203 @@
         }
 
-        debug_break();
-
         LIB_DEBUG_PRINT_SAFE("Will unblock: ");
         for(int i = 0; i < thread_count; i++) {
@@ -201 +211 @@
         // Everything is ready to go to sleep
         ScheduleInternal( locks, count, threads, thread_count );
-
 
         //WE WOKE UP
@@ -212 +221 @@
 }
 
-void signal( condition * this ) {
-        if( !this->blocked.head ) {
+bool signal( condition * this ) {
+        if( is_empty( this ) ) {
                 LIB_DEBUG_PRINT_SAFE("Nothing to signal\n");
-                return;
+                return false;
         }
 
@@ -224 +233 @@
         unsigned short count = this->monitor_count;
         
+        //Some more checking in debug
         LIB_DEBUG_DO(
                 thread_desc * this_thrd = this_thread();
@@ -237 +247 @@
         );
 
+        //Lock all the monitors
         lock_all( this->monitors, NULL, count );
         LIB_DEBUG_PRINT_SAFE("Signalling");
 
+        //Pop the head of the waiting queue
         __condition_node_t * node = pop_head( &this->blocked );
+
+        //Add the thread to the proper AS stack
         for(int i = 0; i < count; i++) {
                 __condition_criterion_t * crit = &node->criteria[i];
@@ -250 +264 @@
         LIB_DEBUG_PRINT_SAFE("\n");
 
+        //Release
         unlock_all( this->monitors, count );
+
+        return true;
+}
+
+bool signal_block( condition * this ) {
+        if( !this->blocked.head ) {
+                LIB_DEBUG_PRINT_SAFE("Nothing to signal\n");
+                return false;
+        }
+
+        //Check that everything is as expected
+        assertf( this->monitors != NULL, "Waiting with no monitors (%p)", this->monitors );
+        assertf( this->monitor_count != 0, "Waiting with 0 monitors (%i)", this->monitor_count );
+
+        unsigned short count = this->monitor_count;
+        unsigned int recursions[ count ];               //Save the current recursion levels to restore them later
+        spinlock *   locks     [ count ];               //We need to pass-in an array of locks to ScheduleInternal
+
+        lock_all( this->monitors, locks, count );
+
+        //create creteria
+        __condition_node_t waiter = { this_thread(), count, 0 };
+
+        __condition_criterion_t criteria[count];
+        for(int i = 0; i < count; i++) {
+                (&criteria[i]){ this->monitors[i], &waiter };
+                LIB_DEBUG_PRINT_SAFE( "Criterion %p\n", &criteria[i] );
+                push( &criteria[i].target->signal_stack, &criteria[i] );
+        }
+
+        waiter.criteria = criteria;
+
+        //save contexts
+        save_recursion( this->monitors, recursions, count );
+
+        //Find the thread to run
+        thread_desc * signallee = pop_head( &this->blocked )->waiting_thread;
+        for(int i = 0; i < count; i++) {
+                set_owner( this->monitors[i], signallee );
+        }
+
+        LIB_DEBUG_PRINT_SAFE( "Waiting on signal block\n" );
+
+        //Everything is ready to go to sleep
+        ScheduleInternal( locks, count, &signallee, 1 );
+
+        LIB_DEBUG_PRINT_SAFE( "Back from signal block\n" );
+
+        //We are back, restore the owners and recursions
+        lock_all( locks, count );
+        restore_recursion( this->monitors, recursions, count );
+        unlock_all( locks, count );
+
+        return true;
+}
+
+uintptr_t front( condition * this ) {
+        LIB_DEBUG_DO(
+                if( is_empty(this) ) {
+                        abortf( "Attempt to access user data on an empty condition.\n"
+                    "Possible cause is not checking if the condition is empty before reading stored data." );
+                }
+        );
+        return this->blocked.head->user_info;
 }
 
@@ -335 +414 @@
 
         for(    int i = 0; i < count; i++ ) {
+
                 LIB_DEBUG_PRINT_SAFE( "Checking %p for %p\n", &criteria[i], target );
                 if( &criteria[i] == target ) {

src/libcfa/concurrency/thread

@@ -82 +82 @@
 
 void yield();
+void yield( unsigned times );
 
 #endif //THREADS_H

src/libcfa/concurrency/thread.c

@@ -87 +87 @@
 }
 
+void yield( unsigned times ) {
+        for( unsigned i = 0; i < times; i++ ) {
+                yield();
+        }
+}
+
 void ThreadCtxSwitch(coroutine_desc* src, coroutine_desc* dst) {
         // set state of current coroutine to inactive