Changeset 48ec19a for src/Validate

Timestamp:

Jun 26, 2023, 10:51:47 AM (3 years ago)

Author:

caparson <caparson@…>

Branches:

master

Children:

917e1fd

Parents:

adc73a5 (diff), 1fbf481 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:software/cfa/cfa-cc

Location:

src/Validate

Files:

• GenericParameter.cpp (modified) (7 diffs)
• LinkReferenceToTypes.cpp (modified) (6 diffs)

src/Validate/GenericParameter.cpp

@@ -16 +16 @@
 #include "GenericParameter.hpp"
 
-#include "AST/Copy.hpp"
 #include "AST/Decl.hpp"
 #include "AST/Expr.hpp"
@@ -120 +119 @@
 }
 
-struct ValidateGenericParamsCore : public ast::WithCodeLocation {
+bool isSizedPolymorphic( const ast::AggregateDecl * decl ) {
+        for ( const auto & param : decl->params ) {
+                if ( param->sized ) return true;
+        }
+        return false;
+}
+
+struct ValidateGenericParamsCore :
+                public ast::WithCodeLocation, public ast::WithGuards {
+        // Generic parameter filling and checks:
         const ast::StructInstType * previsit( const ast::StructInstType * type ) {
                 assert( location );
@@ -130 +138 @@
                 return validateGeneric( *location, type );
         }
+
+        // Check parameter and bitfield combinations:
+        bool insideSized = false;
+        void previsit( const ast::StructDecl * decl ) {
+                if ( isSizedPolymorphic( decl ) && !insideSized ) {
+                        GuardValue( insideSized ) = true;
+                }
+        }
+
+        void previsit( const ast::UnionDecl * decl ) {
+                if ( isSizedPolymorphic( decl ) && !insideSized ) {
+                        GuardValue( insideSized ) = true;
+                }
+        }
+
+        void previsit( const ast::ObjectDecl * decl ) {
+                if ( insideSized && decl->bitfieldWidth ) {
+                        SemanticError( decl->location, decl,
+                                "Cannot have bitfields inside a sized polymorphic structure." );
+                }
+        }
 };
 
@@ -135 +164 @@
 
 struct TranslateDimensionCore :
-                public WithNoIdSymbolTable, public ast::WithGuards {
+                public WithNoIdSymbolTable, public ast::WithGuards,
+                public ast::WithVisitorRef<TranslateDimensionCore> {
 
         // SUIT: Struct- or Union- InstType
@@ -160 +190 @@
 
         const ast::TypeDecl * postvisit( const ast::TypeDecl * decl );
+        const ast::Type * postvisit( const ast::FunctionType * type );
+        const ast::Type * postvisit( const ast::TypeInstType * type );
+
         const ast::Expr * postvisit( const ast::DimensionExpr * expr );
         const ast::Expr * postvisit( const ast::Expr * expr );
@@ -165 +198 @@
 };
 
+// Declaration of type variable: forall( [N] )  ->  forall( N & | sized( N ) )
 const ast::TypeDecl * TranslateDimensionCore::postvisit(
                 const ast::TypeDecl * decl ) {
@@ -176 +210 @@
         }
         return decl;
+}
+
+// Makes postvisit( TypeInstType ) get called on the entries of the function declaration's type's forall list.
+// Pass.impl.hpp's visit( FunctionType ) does not consider the forall entries to be child nodes.
+// Workaround is: during the current TranslateDimension pass, manually visit down there.
+const ast::Type * TranslateDimensionCore::postvisit(
+                const ast::FunctionType * type ) {
+        visitor->maybe_accept( type, &ast::FunctionType::forall );
+        return type;
+}
+
+// Use of type variable, assuming `forall( [N] )` in scope:  void (*)( foo( /*dimension*/ N ) & )  ->  void (*)( foo( /*dtype*/ N ) & )
+const ast::Type * TranslateDimensionCore::postvisit(
+                const ast::TypeInstType * type ) {
+        if ( type->kind == ast::TypeDecl::Dimension ) {
+                auto mutType = ast::mutate( type );
+                mutType->kind = ast::TypeDecl::Dtype;
+                return mutType;
+        }
+        return type;
 }
 

src/Validate/LinkReferenceToTypes.cpp

@@ -84 +84 @@
                 // Just linking in the node.
                 auto mut = ast::mutate( type );
-                mut->base = const_cast<ast::EnumDecl *>( decl );
+                mut->base = decl;
                 type = mut;
         }
@@ -101 +101 @@
                 // Just linking in the node.
                 auto mut = ast::mutate( type );
-                mut->base = const_cast<ast::StructDecl *>( decl );
+                mut->base = decl;
                 type = mut;
         }
@@ -118 +118 @@
                 // Just linking in the node.
                 auto mut = ast::mutate( type );
-                mut->base = const_cast<ast::UnionDecl *>( decl );
+                mut->base = decl;
                 type = mut;
         }
@@ -141 +141 @@
 
         // Just linking in the node.
-        mut->base = const_cast<ast::TraitDecl *>( decl );
+        mut->base = decl;
 
         // Need to carry over the 'sized' status of each decl in the instance.
@@ -203 +203 @@
         }
 
-        // The following section 
-
         ForwardEnumsType::iterator fwds = forwardEnums.find( decl->name );
         if ( fwds != forwardEnums.end() ) {
@@ -266 +264 @@
 
 ast::TraitDecl const * LinkTypesCore::postvisit( ast::TraitDecl const * decl ) {
-        auto mut = ast::mutate( decl );
-        if ( mut->name == "sized" ) {
-                // "sized" is a special trait - flick the sized status on for the type variable.
-                assertf( mut->params.size() == 1, "Built-in trait 'sized' has incorrect number of parameters: %zd", decl->params.size() );
-                ast::TypeDecl * td = mut->params.front().get_and_mutate();
-                td->sized = true;
-        }
-
         // There is some overlap with code from decayForallPointers,
         // perhaps reorganization or shared helper functions are called for.
         // Move assertions from type parameters into the body of the trait.
+        auto mut = ast::mutate( decl );
         for ( ast::ptr<ast::TypeDecl> const & td : decl->params ) {
                 auto expanded = expandAssertions( td->assertions );