Changes in src/InitTweak/FixInit.cc [a2a8d2a6:486341f]

File:

• src/InitTweak/FixInit.cc (modified) (5 diffs)

src/InitTweak/FixInit.cc

@@ -188 +188 @@
                         virtual void visit( ApplicationExpr * appExpr );
 
-                        SemanticError errors;
                   private:
                         void handleFirstParam( Expression * firstParam );
-                        template< typename... Params >
-                        void emit( const Params &... params );
 
                         FunctionDecl * function = 0;
@@ -261 +258 @@
                                 WarnStructMembers warner;
                                 acceptAll( translationUnit, warner );
-
-                                // visitor doesn't throw so that it can collect all errors
-                                if ( ! warner.errors.isEmpty() ) {
-                                        throw warner.errors;
-                                }
                         }
                 }
@@ -743 +735 @@
                         for ( DeclarationWithType * member : unhandled ) {
                                 // emit a warning for each unhandled member
-                                emit( "in ", CodeGen::genType( function->get_functionType(), function->get_name(), false ), ", member ", member->get_name(), " may not have been ", isConstructor( funcDecl->get_name() ) ? "constructed" : "destructed" );
+                                warn( "in ", CodeGen::genType( function->get_functionType(), function->get_name(), false ), ", member ", member->get_name(), " may not have been ", isConstructor( funcDecl->get_name() ) ? "constructed" : "destructed" );
                         }
 
-                        // need to steal the errors before they're lost
-                        old.errors.append( errors );
                         *this = old;
                 }
@@ -807 +797 @@
                                                         if ( unhandled.count( memberExpr->get_member() ) ) {
                                                                 // emit a warning because a member was used before it was constructed
-                                                                emit( "in ", CodeGen::genType( function->get_functionType(), function->get_name(), false ), ", member ", memberExpr->get_member()->get_name(), " used before being constructed" );
+                                                                warn( "in ", CodeGen::genType( function->get_functionType(), function->get_name(), false ), ", member ", memberExpr->get_member()->get_name(), " used before being constructed" );
                                                         }
                                                 }
@@ -815 +805 @@
                         Parent::visit( memberExpr );
                 }
-
-                template< typename Visitor, typename... Params >
-                void error( Visitor & v, const Params &... params ) {
-                        v.errors.append( toString( params... ) );
-                }
-
-                template< typename... Params >
-                void WarnStructMembers::emit( const Params &... params ) {
-                        // toggle warnings vs. errors here.
-                        // warn( params... );
-                        error( *this, params... );
-                }
         } // namespace
 } // namespace InitTweak