Changes in / [b11fac4:45161b4d]

Location:

src/GenPoly

Files:

• Box.cc (modified) (4 diffs)
• Lvalue.cc (modified) (3 diffs)

src/GenPoly/Box.cc

@@ -292 +292 @@
                         /// adds type parameters to the layout call; will generate the appropriate parameters if needed
                         void addOtypeParamsToLayoutCall( UntypedExpr *layoutCall, const std::list< Type* > &otypeParams );
-
-                        /// Enters a new scope for type-variables, adding the type variables from ty
-                        void beginTypeScope( Type *ty );
-                        /// Exits the type-variable scope
-                        void endTypeScope();
                         
                         ScopedSet< std::string > knownLayouts;          ///< Set of generic type layouts known in the current scope, indexed by sizeofName
@@ -1826 +1821 @@
 ////////////////////////////////////////// PolyGenericCalculator ////////////////////////////////////////////////////
 
-                void PolyGenericCalculator::beginTypeScope( Type *ty ) {
-                        scopeTyVars.beginScope();
-                        makeTyVarMap( ty, scopeTyVars );
-                }
-
-                void PolyGenericCalculator::endTypeScope() {
-                        scopeTyVars.endScope();
-                }
-
                 template< typename DeclClass >
                 DeclClass * PolyGenericCalculator::handleDecl( DeclClass *decl, Type *type ) {
-                        beginTypeScope( type );
-                        knownLayouts.beginScope();
-                        knownOffsets.beginScope();
+                        scopeTyVars.beginScope();
+                        makeTyVarMap( type, scopeTyVars );
 
                         DeclClass *ret = static_cast< DeclClass *>( Mutator::mutate( decl ) );
 
-                        knownOffsets.endScope();
-                        knownLayouts.endScope();
-                        endTypeScope();
+                        scopeTyVars.endScope();
                         return ret;
                 }
@@ -1867 +1850 @@
 
                 Type * PolyGenericCalculator::mutate( PointerType *pointerType ) {
-                        beginTypeScope( pointerType );
+                        scopeTyVars.beginScope();
+                        makeTyVarMap( pointerType, scopeTyVars );
 
                         Type *ret = Mutator::mutate( pointerType );
 
-                        endTypeScope();
+                        scopeTyVars.endScope();
                         return ret;
                 }
 
                 Type * PolyGenericCalculator::mutate( FunctionType *funcType ) {
-                        beginTypeScope( funcType );
+                        scopeTyVars.beginScope();
+                        makeTyVarMap( funcType, scopeTyVars );
 
                         // make sure that any type information passed into the function is accounted for
@@ -1889 +1874 @@
                         Type *ret = Mutator::mutate( funcType );
 
-                        endTypeScope();
+                        scopeTyVars.endScope();
                         return ret;
                 }

src/GenPoly/Lvalue.cc

@@ -17 +17 @@
 
 #include "Lvalue.h"
-
-#include "GenPoly.h"
 
 #include "SynTree/Declaration.h"
@@ -65 +63 @@
 
         namespace {
-                Type* isLvalueRet( FunctionType *function ) {
-                        if ( function->get_returnVals().empty() ) return 0;
-                        Type *ty = function->get_returnVals().front()->get_type();
-                        return ty->get_isLvalue() ? ty : 0;
+                bool isLvalueRet( FunctionType *function ) {
+                        if ( ! function->get_returnVals().empty() ) {
+                                return function->get_returnVals().front()->get_type()->get_isLvalue();
+                        } else {
+                                return false;
+                        } // if
                 }
 
@@ -107 +107 @@
                         assert( function );
 
-                        Type *funType = isLvalueRet( function );
-                        if ( funType && ! isIntrinsicApp( appExpr ) ) {
-                                Expression *expr = appExpr;
-                                Type *appType = appExpr->get_results().front();
-                                if ( isPolyType( funType ) ) {
-                                        // make sure cast for polymorphic type is inside dereference
-                                        expr = new CastExpr( appExpr, new PointerType( Type::Qualifiers(), appType->clone() ) );
-                                }
+                        std::string typeName;
+                        if ( isLvalueRet( function ) && ! isIntrinsicApp( appExpr ) ) {
                                 UntypedExpr *deref = new UntypedExpr( new NameExpr( "*?" ) );
-                                deref->get_results().push_back( appType->clone() );
-                                appExpr->get_results().front() = new PointerType( Type::Qualifiers(), appType );
-                                deref->get_args().push_back( expr );
+                                deref->get_results().push_back( appExpr->get_results().front() );
+                                appExpr->get_results().front() = new PointerType( Type::Qualifiers(), deref->get_results().front()->clone() );
+                                deref->get_args().push_back( appExpr );
                                 return deref;
                         } else {