Changeset 44b5ca0 for src/SymTab

Timestamp:

Jun 5, 2015, 8:12:32 AM (10 years ago)

Author:

Peter A. Buhr <pabuhr@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, ctor, deferred_resn, demangler, enum, forall-pointer-decay, gc_noraii, jacob/cs343-translation, jenkins-sandbox, master, memory, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, string, with_gc

Children:

a65d92e

Parents:

cf0941d

Message:

remove all carriage returns from printing, work on regression testing

File:

• src/SymTab/Indexer.cc (modified) (2 diffs)

src/SymTab/Indexer.cc ¶

@@ -10 +10 @@
 // Created On       : Sun May 17 21:37:33 2015
 // Last Modified By : Peter A. Buhr
-// Last Modified On : Tue May 19 16:49:55 2015
-// Update Count     : 3
+// Last Modified On : Fri Jun  5 08:05:17 2015
+// Update Count     : 5
 //
 
@@ -51 +51 @@
         }
 
-/********
- * A NOTE ON THE ORDER OF TRAVERSAL
- *
- * Types and typedefs have their base types visited before they are added to the type table.
- * This is ok, since there is no such thing as a recursive type or typedef.
- *             typedef struct { T *x; } T; // never allowed
- *
- * for structs/unions, it is possible to have recursion, so the decl should be added as if it's
- * incomplete to begin, the members are traversed, and then the complete type should be added
- * (assuming the type is completed by this particular declaration).
- *             struct T { struct T *x; }; // allowed
- *
- * It's important to add the complete type to the symbol table *after* the members/base has been
- * traversed, since that traversal may modify the definition of the type and these modifications
- * should be visible when the symbol table is queried later in this pass.
- *
- * TODO: figure out whether recursive contexts are sensible/possible/reasonable.
- */
+
+// A NOTE ON THE ORDER OF TRAVERSAL
+//
+// Types and typedefs have their base types visited before they are added to the type table.  This is ok, since there is
+// no such thing as a recursive type or typedef.
+//
+//             typedef struct { T *x; } T; // never allowed
+//
+// for structs/unions, it is possible to have recursion, so the decl should be added as if it's incomplete to begin, the
+// members are traversed, and then the complete type should be added (assuming the type is completed by this particular
+// declaration).
+//
+//             struct T { struct T *x; }; // allowed
+//
+// It is important to add the complete type to the symbol table *after* the members/base has been traversed, since that
+// traversal may modify the definition of the type and these modifications should be visible when the symbol table is
+// queried later in this pass.
+//
+// TODO: figure out whether recursive contexts are sensible/possible/reasonable.
+
 
         void Indexer::visit( TypeDecl *typeDecl ) {
                 // see A NOTE ON THE ORDER OF TRAVERSAL, above
-                // note that assertions come after the type is added to the symtab, since they aren't part
-                // of the type proper and may depend on the type itself
+                // note that assertions come after the type is added to the symtab, since they are not part of the type proper
+                // and may depend on the type itself
                 enterScope();
                 acceptAll( typeDecl->get_parameters(), *this );