Changeset 417117e

Timestamp:

Jun 28, 2019, 3:50:21 PM (5 years ago)

Author:

Aaron Moss <a3moss@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

03bf5c8

Parents:

55b6476

Message:

Assorted cleanup

Location:

src

Files:

• AST/Eval.hpp (added)
• AST/Expr.cpp (modified) (3 diffs)
• AST/Pass.impl.hpp (modified) (2 diffs)
• AST/TypeSubstitution.cpp (modified) (1 diff)
• ResolvExpr/CandidateFinder.cpp (modified) (1 diff)
• ResolvExpr/ResolveTypeof.cc (modified) (1 diff)
• ResolvExpr/Resolver.cc (modified) (4 diffs)
• SymTab/Autogen.h (modified) (5 diffs)
• Tuples/Explode.cc (modified) (1 diff)
• Tuples/Explode.h (modified) (2 diffs)

src/AST/Expr.cpp

@@ -20 +20 @@
 #include <vector>
 
+#include "Eval.hpp"                // for call
 #include "GenericSubstitution.hpp"
 #include "Stmt.hpp"
@@ -51 +52 @@
         assert( arg );
 
-        UntypedExpr * ret = new UntypedExpr{
-                loc, new NameExpr{loc, "*?"}, std::vector<ptr<Expr>>{ ptr<Expr>{ arg } }
-        };
+        UntypedExpr * ret = call( loc, "*?", arg );
         if ( const Type * ty = arg->result ) {
                 const Type * base = InitTweak::getPointerBase( ty );
@@ -74 +73 @@
         assert( lhs && rhs );
 
-        UntypedExpr * ret = new UntypedExpr{
-                loc, new NameExpr{loc, "?=?"}, std::vector<ptr<Expr>>{ ptr<Expr>{ lhs }, ptr<Expr>{ rhs } }
-        };
+        UntypedExpr * ret = call( loc, "?=?", lhs, rhs );
         if ( lhs->result && rhs->result ) {
                 // if both expressions are typed, assumes that this assignment is a C bitwise assignment,

src/AST/Pass.impl.hpp

@@ -1920 +1920 @@
                                 guard_symtab guard { *this };
                                 auto new_node = p.second->accept( *this );
-                                if (new_node != p.second) mutated = false;
+                                if (new_node != p.second) mutated = true;
                                 new_map.insert({ p.first, new_node });
                         }
@@ -1936 +1936 @@
                                 guard_symtab guard { *this };
                                 auto new_node = p.second->accept( *this );
-                                if (new_node != p.second) mutated = false;
+                                if (new_node != p.second) mutated = true;
                                 new_map.insert({ p.first, new_node });
                         }

src/AST/TypeSubstitution.cpp

@@ -183 +183 @@
                 // bind type variables from generic type instantiations
                 if ( auto decl = type->aggr() ) {
-                        const std::vector<ptr<TypeDecl>> &baseParameters =  decl->params;
-                        if (! type->params.empty()) {
-                                for ( const TypeDecl * tyvar : baseParameters ) {
+                        if ( ! type->params.empty() ) {
+                                for ( const TypeDecl * tyvar : decl->params ) {
                                         boundVars.insert( tyvar->name );
                                 } // for

src/ResolvExpr/CandidateFinder.cpp

@@ -370 +370 @@
                                                         // push empty tuple expression
                                                         newResult.parent = i;
-                                                        std::vector< ast::ptr< ast::Expr > > emptyList;
-                                                        newResult.expr = 
-                                                                new ast::TupleExpr{ CodeLocation{}, move( emptyList ) };
+                                                        newResult.expr = new ast::TupleExpr{ CodeLocation{}, {} };
                                                         argType = newResult.expr->result;
                                                 } else {

src/ResolvExpr/ResolveTypeof.cc

@@ -153 +153 @@
                         }
 
-                        return newType;
+                        return newType.release();
                 }
         };

src/ResolvExpr/Resolver.cc

@@ -1109 +1109 @@
                 
                 // set up and resolve expression cast to void
-                ast::CastExpr * untyped = new ast::CastExpr{ expr };
+                ast::ptr< ast::CastExpr > untyped = new ast::CastExpr{ expr };
                 CandidateRef choice = findUnfinishedKindExpression( 
                         untyped, symtab, "", anyCandidate, ResolvMode::withAdjustment() );
@@ -1248 +1248 @@
         };
 
-        void resolve( std::list< ast::ptr<ast::Decl> >& translationUnit ) {
+        void resolve( std::list< ast::ptr< ast::Decl > >& translationUnit ) {
                 ast::Pass< Resolver_new > resolver;
                 accept_all( translationUnit, resolver );
@@ -1282 +1282 @@
                 ast::ptr< ast::FunctionDecl > ret = functionDecl;
                 for ( unsigned i = 0; i < functionDecl->type->params.size(); ++i ) {
-                        const ast::ptr<ast::DeclWithType> & d = functionDecl->type->params[i];
+                        const ast::ptr< ast::DeclWithType > & d = functionDecl->type->params[i];
 
                         if ( const ast::ObjectDecl * obj = d.as< ast::ObjectDecl >() ) {
@@ -1299 +1299 @@
                         }
                 }
-                return ret.get();
+                return ret.release();
         }
 

src/SymTab/Autogen.h

@@ -21 +21 @@
 
 #include "AST/Decl.hpp"
+#include "AST/Eval.hpp"
 #include "AST/Expr.hpp"
 #include "AST/Init.hpp"
@@ -264 +265 @@
                 }
 
-                ast::ptr< ast::Expr > begin, end, cmp, update;
+                ast::ptr< ast::Expr > begin, end;
+                std::string cmp, update;
 
                 if ( forward ) {
@@ -270 +272 @@
                         begin = ast::ConstantExpr::from_int( loc, 0 );
                         end = array->dimension;
-                        cmp = new ast::NameExpr{ loc, "?<?" };
-                        update = new ast::NameExpr{ loc, "++?" };
+                        cmp = "?<?";
+                        update = "++?";
                 } else {
                         // generate: for ( int i = N-1; i >= 0; --i )
-                        begin = new ast::UntypedExpr{ 
-                                loc, new ast::NameExpr{ loc, "?-?" }, 
-                                { array->dimension, ast::ConstantExpr::from_int( loc, 1 ) } };
+                        begin = ast::call( 
+                                loc, "?-?", array->dimension, ast::ConstantExpr::from_int( loc, 1 ) );
                         end = ast::ConstantExpr::from_int( loc, 0 );
-                        cmp = new ast::NameExpr{ loc, "?>=?" };
-                        update = new ast::NameExpr{ loc, "--?" };
+                        cmp = "?>=?";
+                        update = "--?";
                 }
 
@@ -285 +286 @@
                         loc, indexName.newName(), new ast::BasicType{ ast::BasicType::SignedInt }, 
                         new ast::SingleInit{ loc, begin } };
-                
-                ast::ptr< ast::Expr > cond = new ast::UntypedExpr{
-                        loc, cmp, { new ast::VariableExpr{ loc, index }, end } };
-                
-                ast::ptr< ast::Expr > inc = new ast::UntypedExpr{
-                        loc, update, { new ast::VariableExpr{ loc, index } } };
-                
-                ast::ptr< ast::Expr > dstIndex = new ast::UntypedExpr{
-                        loc, new ast::NameExpr{ loc, "?[?]" }, 
-                        { dstParam, new ast::VariableExpr{ loc, index } } };
+                ast::ptr< ast::Expr > indexVar = new ast::VariableExpr{ loc, index };
+                
+                ast::ptr< ast::Expr > cond = ast::call( loc, cmp, indexVar, end );
+                
+                ast::ptr< ast::Expr > inc = ast::call( loc, update, indexVar );
+                
+                ast::ptr< ast::Expr > dstIndex = ast::call( loc, "?[?]", dstParam, indexVar );
                 
                 // srcParam must keep track of the array indices to build the source parameter and/or 
                 // array list initializer
-                srcParam.addArrayIndex( new ast::VariableExpr{ loc, index }, array->dimension );
+                srcParam.addArrayIndex( indexVar, array->dimension );
 
                 // for stmt's body, eventually containing call
@@ -384 +382 @@
                 if ( isUnnamedBitfield( obj ) ) return {};
 
-                ast::ptr< ast::Type > addCast = nullptr;
+                ast::ptr< ast::Type > addCast;
                 if ( (fname == "?{}" || fname == "^?{}") && ( ! obj || ( obj && ! obj->bitfieldWidth ) ) ) {
                         assert( dstParam->result );

src/Tuples/Explode.cc

@@ -129 +129 @@
                         for ( const ast::Expr * expr : tupleExpr->exprs ) {
                                 exprs.emplace_back( applyCast( expr, false ) );
-                                //exprs.emplace_back( ast::ptr< ast::Expr >( applyCast( expr, false ) ) );
                         }
                         if ( first ) {

src/Tuples/Explode.h

@@ -210 +210 @@
                         }
                         // Cast a reference away to a value-type to allow further explosion.
-                        if ( dynamic_cast< const ast::ReferenceType *>( local->result.get() ) ) {
+                        if ( local->result.as< ast::ReferenceType >() ) {
                                 local = new ast::CastExpr{ local, tupleType };
                         }
@@ -220 +220 @@
                                 // delete idx;
                         }
-                        // delete local;
                 }
         } else {