Changes in libcfa/src/collections/string_res.cfa [0860d9c:416b443]

File:

• libcfa/src/collections/string_res.cfa (modified) (3 diffs)

libcfa/src/collections/string_res.cfa

@@ -218 +218 @@
     // Read in chunks.  Often, one chunk is enough.  Keep the string that accumulates chunks last in the heap,
     // so available room is rest of heap.  When a chunk fills the heap, force growth then take the next chunk.
-    for (bool cont = true; cont; ) {
-        cont = false;
-
+    for (;;) {
         // Append dummy content to temp, forcing expansion when applicable (occurs always on subsequent loops)
         // length 2 ensures room for at least one real char, plus scanf/pipe-cstr's null terminator
@@ -230 +228 @@
         temp.Handle.ulink->EndVbyte -= 2;
 
-        // rest of heap is available to read into
-        int lenReadable = (char*)temp.Handle.ulink->ExtVbyte - temp.Handle.ulink->EndVbyte;
-        assert (lenReadable >= 2);
+        // rest of heap, less 1 byte for null terminator, is available to read into
+        int lenReadable = (char*)temp.Handle.ulink->ExtVbyte - temp.Handle.ulink->EndVbyte - 1;
+        assert (lenReadable >= 1);
 
         // get bytes
-        try {
-            in | wdi( lenReadable, temp.Handle.ulink->EndVbyte );
-        } catch (cstring_length*) {
-            cont = true;
-        }
+        in | wdi( lenReadable + 1, lenReadable, temp.Handle.ulink->EndVbyte );
         int lenWasRead = strlen(temp.Handle.ulink->EndVbyte);
 
@@ -245 +239 @@
         temp.Handle.lnth += lenWasRead;
         temp.Handle.ulink->EndVbyte += lenWasRead;
+
+      if (lenWasRead < lenReadable) break;
     }