Changeset 3d2b7bc

Timestamp:

Mar 28, 2018, 4:46:54 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, with_gc

Children:

f6e3e34

Parents:

b5563e1

git-author:

Rob Schluntz <rschlunt@…> (03/28/18 10:35:21)

git-committer:

Rob Schluntz <rschlunt@…> (03/28/18 16:46:54)

Message:

Check for operator-as-object errors

Location:

src

Files:

• CodeGen/OperatorTable.cc (modified) (2 diffs)
• CodeGen/OperatorTable.h (modified) (1 diff)
• SymTab/Validate.cc (modified) (1 diff)
• tests/operators.c (modified) (1 diff)

src/CodeGen/OperatorTable.cc

@@ -79 +79 @@
         } // namespace
 
-        bool operatorLookup( std::string funcName, OperatorInfo &info ) {
+        bool operatorLookup( const std::string & funcName, OperatorInfo & info ) {
                 static bool init = false;
                 if ( ! init ) {
@@ -100 +100 @@
                         return true;
                 } // if
+        }
+
+        bool isOperator( const std::string & funcName ) {
+                OperatorInfo info;
+                return operatorLookup( funcName, info );
         }
 

src/CodeGen/OperatorTable.h

@@ -41 +41 @@
         };
 
-        bool operatorLookup( std::string funcName, OperatorInfo &info );
+        bool isOperator( const std::string & funcName );
+        bool operatorLookup( const std::string & funcName, OperatorInfo & info );
 
         bool isConstructor( const std::string & );

src/SymTab/Validate.cc

@@ -630 +630 @@
                         forallFixer( pointer->base->forall, object );
                 } // if
+                // ensure that operator names only apply to functions or function pointers
+                if ( CodeGen::isOperator( object->name ) && ! dynamic_cast< FunctionType * >( object->type->stripDeclarator() ) ) {
+                        SemanticError( object->location, toCString( "operator ", object->name.c_str(), " is not a function or function pointer." )  );
+                }
                 object->fixUniqueId();
         }

src/tests/operators.c

@@ -27 +27 @@
         a(b);
         a + b;
-        struct accumulator ?+?; // why not, eh?
-        a + b;
 }