Changes in src/ResolvExpr/Resolver.cc [ec79847:3cfe27f]

File:

• src/ResolvExpr/Resolver.cc (modified) (16 diffs)

src/ResolvExpr/Resolver.cc

@@ -5 +5 @@
 // file "LICENCE" distributed with Cforall.
 //
-// Resolver.cc --
+// Resolver.cc -- 
 //
 // Author           : Richard C. Bilson
 // Created On       : Sun May 17 12:17:01 2015
-// Last Modified By : Rob Schluntz
-// Last Modified On : Mon May 09 12:10:19 2016
-// Update Count     : 203
+// Last Modified By : Peter A. Buhr
+// Last Modified On : Thu Mar 24 16:43:11 2016
+// Update Count     : 181
 //
 
@@ -25 +25 @@
 #include "SymTab/Indexer.h"
 #include "Common/utility.h"
-#include "InitTweak/FixInit.h"
 
 #include <iostream>
@@ -34 +33 @@
           public:
                 Resolver() : SymTab::Indexer( false ), switchType( 0 ) {}
-
+  
                 virtual void visit( FunctionDecl *functionDecl );
                 virtual void visit( ObjectDecl *functionDecl );
@@ -55 +54 @@
                 virtual void visit( SingleInit *singleInit );
                 virtual void visit( ListInit *listInit );
-                virtual void visit( ConstructorInit *ctorInit );
           private:
         typedef std::list< Initializer * >::iterator InitIterator;
@@ -61 +59 @@
           void resolveAggrInit( AggregateDecl *, InitIterator &, InitIterator & );
           void resolveSingleAggrInit( Declaration *, InitIterator &, InitIterator & );
-          void fallbackInit( ConstructorInit * ctorInit );
+
                 std::list< Type * > functionReturn;
                 Type *initContext;
@@ -84 +82 @@
         }
 
-
         namespace {
                 void finishExpr( Expression *expr, const TypeEnvironment &env ) {
@@ -90 +87 @@
                         env.makeSubstitution( *expr->get_env() );
                 }
-        } // namespace
-
-        Expression *findVoidExpression( Expression *untyped, const SymTab::Indexer &indexer ) {
-                global_renamer.reset();
-                TypeEnvironment env;
-                Expression *newExpr = resolveInVoidContext( untyped, indexer, env );
-                finishExpr( newExpr, env );
-                return newExpr;
-        }
-
-        namespace {
+
+                Expression *findVoidExpression( Expression *untyped, const SymTab::Indexer &indexer ) {
+                        global_renamer.reset();
+                        TypeEnvironment env;
+                        Expression *newExpr = resolveInVoidContext( untyped, indexer, env );
+                        finishExpr( newExpr, env );
+                        return newExpr;
+                }
+  
                 Expression *findSingleExpression( Expression *untyped, const SymTab::Indexer &indexer ) {
                         TypeEnvironment env;
@@ -131 +126 @@
                         } // if
                 }
-
+  
                 Expression *findIntegralExpression( Expression *untyped, const SymTab::Indexer &indexer ) {
                         TypeEnvironment env;
@@ -164 +159 @@
                         return newExpr;
                 }
-
-        }
-
+  
+        }
+  
         void Resolver::visit( ObjectDecl *objectDecl ) {
                 Type *new_type = resolveTypeof( objectDecl->get_type(), *this );
@@ -263 +258 @@
                         forStmt->set_condition( newExpr );
                 } // if
-
+                
                 if ( forStmt->get_increment() ) {
                         Expression * newExpr = findVoidExpression( forStmt->get_increment(), *this );
@@ -277 +272 @@
                 delete switchStmt->get_condition();
                 switchStmt->set_condition( newExpr );
-
+  
                 visitor.Visitor::visit( switchStmt );
         }
@@ -319 +314 @@
         bool isCharType( T t ) {
                 if ( BasicType * bt = dynamic_cast< BasicType * >( t ) ) {
-                        return bt->get_kind() == BasicType::Char || bt->get_kind() == BasicType::SignedChar ||
+                        return bt->get_kind() == BasicType::Char || bt->get_kind() == BasicType::SignedChar || 
                                 bt->get_kind() == BasicType::UnsignedChar;
                 }
@@ -331 +326 @@
                                 string n = ne->get_name();
                                 if (n == "0") {
-                                        initContext = new BasicType(Type::Qualifiers(),
+                                        initContext = new BasicType(Type::Qualifiers(), 
                                                                                                 BasicType::SignedInt);
                                 } else {
@@ -337 +332 @@
                                         initContext = decl->get_type();
                                 }
-                        } else if (ConstantExpr * e =
+                        } else if (ConstantExpr * e = 
                                            dynamic_cast<ConstantExpr*>(singleInit->get_value())) {
                                 Constant *c = e->get_constant();
@@ -360 +355 @@
                                                         singleInit->set_value( ce->get_arg() );
                                                         ce->set_arg( NULL );
-                                                        delete ce;
+                                                        delete ce;                                                                      
                                                 }
                                         }
@@ -476 +471 @@
 #endif
         }
-
-        // ConstructorInit - fall back on C-style initializer
-        void Resolver::fallbackInit( ConstructorInit * ctorInit ) {
-                // could not find valid constructor, or found an intrinsic constructor
-                // fall back on C-style initializer
-                delete ctorInit->get_ctor();
-                ctorInit->set_ctor( NULL );
-                maybeAccept( ctorInit->get_init(), *this );
-        }
-
-        void Resolver::visit( ConstructorInit *ctorInit ) {
-                try {
-                        maybeAccept( ctorInit->get_ctor(), *this );
-                        maybeAccept( ctorInit->get_dtor(), *this );
-                } catch ( SemanticError ) {
-                        // no alternatives for the constructor initializer - fallback on C-style initializer
-                        // xxx- not sure if this makes a ton of sense - should maybe never be able to have this situation?
-                        fallbackInit( ctorInit );
-                        return;
-                }
-
-                // found a constructor - can get rid of C-style initializer
-                delete ctorInit->get_init();
-                ctorInit->set_init( NULL );
-
-                // intrinsic single parameter constructors and destructors do nothing. Since this was
-                // implicitly generated, there's no way for it to have side effects, so get rid of it
-                // to clean up generated code.
-                if ( InitTweak::isInstrinsicSingleArgCallStmt( ctorInit->get_ctor() ) ) {
-                        delete ctorInit->get_ctor();
-                        ctorInit->set_ctor( NULL );
-                }
-                if ( InitTweak::isInstrinsicSingleArgCallStmt( ctorInit->get_ctor() ) ) {
-                        delete ctorInit->get_dtor();
-                        ctorInit->set_dtor( NULL );
-                }
-        }
 } // namespace ResolvExpr