Changeset 3c55fcd

Timestamp:

Jun 28, 2024, 2:17:20 PM (2 days ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

master

Children:

4117761

Parents:

259012e

Message:

Added some notes about how to enable heap statistics. Reformated some of the related macro code to make it a bit more compact and hopefully clearer.

File:

• src/Common/Stats/Heap.cpp (modified) (1 diff)

src/Common/Stats/Heap.cpp

@@ -21 +21 @@
 #include <iostream>
 
-#if defined(__has_feature)
+// Most of the other statistics features are deactivated only by defining
+// NO_STATISTICS (or their NO_%_STATISTICS macro). However the heap has some
+// other compatability concerns and will disable itself in some cases.
+//
+// I do not claim to understand these cases. But TCMALLOC is often defined by
+// default and you can pass --disable-gprofiler to configure to remove it.
+
+#if defined(NO_STATISTICS) || defined(TCMALLOC) || defined(__SANITIZE_ADDRESS__)
+        #define NO_HEAP_STATISTICS
+#elif defined(__has_feature)
         #if __has_feature(address_sanitizer)
-                #define NO_HEAP_STATISTICS
-        # endif
-#endif
-
-#if defined( NO_STATISTICS ) || defined( TCMALLOC ) || defined(__SANITIZE_ADDRESS__)
-        #if !defined(NO_HEAP_STATISTICS)
                 #define NO_HEAP_STATISTICS
         #endif