Changeset 35cc6d4 for src

Timestamp:

Dec 12, 2024, 4:35:32 PM (6 days ago)

Author:

Michael Brooks <mlbrooks@…>

Branches:

master

Children:

8ee211d

Parents:

f979f0ba

Message:

Mitigate several unused-declaration warnings in generated code.

See tests/nowarn/unused for the specific cases.

Location:

src

Files:

• GenPoly/Box.cpp (modified) (1 diff)
• Validate/Autogen.cpp (modified) (4 diffs)
• Validate/CompoundLiteral.cpp (modified) (1 diff)
• Validate/ImplementEnumFunc.cpp (modified) (1 diff)

src/GenPoly/Box.cpp

@@ -86 +86 @@
                         makeLayoutCType()
                 ) );
-                params.emplace_back( new ast::ObjectDecl(
+                auto alignParam = new ast::ObjectDecl(
                         sizedParam->location,
                         alignofName( paramName ),
                         makeLayoutCType()
-                ) );
+                );
+                alignParam->attributes.push_back( new ast::Attribute( "unused" ) );
+                params.emplace_back( alignParam );
         }
 }

src/Validate/Autogen.cpp

@@ -229 +229 @@
 }
 
-/// Changes the node inside a pointer so that it has the unused attribute.
-void addUnusedAttribute( ast::ptr<ast::DeclWithType> & declPtr ) {
-        ast::DeclWithType * decl = declPtr.get_and_mutate();
+/// Changes the freshly-constructed (non-const) decl so that it has the unused attribute.
+ast::ObjectDecl * addUnusedAttribute( ast::ObjectDecl * decl ) {
         decl->attributes.push_back( new ast::Attribute( "unused" ) );
+        return decl;
 }
 
@@ -373 +373 @@
 
 ast::ObjectDecl * FuncGenerator::dstParam() const {
-        return new ast::ObjectDecl( getLocation(), "_dst",
-                new ast::ReferenceType( ast::deepCopy( type ) ) );
+        return addUnusedAttribute(
+                new ast::ObjectDecl( getLocation(), "_dst",
+                        new ast::ReferenceType( ast::deepCopy( type ) ) ) );
 }
 
 ast::ObjectDecl * FuncGenerator::srcParam() const {
-        return new ast::ObjectDecl( getLocation(), "_src",
-                ast::deepCopy( type ) );
+        return addUnusedAttribute(
+                new ast::ObjectDecl( getLocation(), "_src",
+                        ast::deepCopy( type ) ) );
 }
 
@@ -673 +675 @@
                 // Default constructor and destructor is empty.
                 functionDecl->stmts = new ast::CompoundStmt( location );
-                // Add unused attribute to parameter to silence warnings.
-                addUnusedAttribute( params.front() );
         }
 }
@@ -747 +747 @@
                 // Default constructor and destructor is empty.
                 functionDecl->stmts = new ast::CompoundStmt( location );
-                // Just add unused attribute to parameter to silence warnings.
-                addUnusedAttribute( params.front() );
         }
 }

src/Validate/CompoundLiteral.cpp

@@ -52 +52 @@
                 storageClasses
                 );
+        // FIXME: A resolution of #280 could make the unused attribute unnecessary here
+        //     (let test nowarn/unused decide)
+        temp->attributes.push_back( new ast::Attribute( "unused" ) );
         declsToAddBefore.push_back( temp );
         return new ast::VariableExpr( expr->location, temp );

src/Validate/ImplementEnumFunc.cpp

@@ -240 +240 @@
         return genProto(
                 "type_name",
-                {new ast::ObjectDecl(getLocation(), "_i", new ast::EnumInstType(decl))},
+                {new ast::ObjectDecl(getLocation(), "", new ast::EnumInstType(decl))},
                 {new ast::ObjectDecl(
                         getLocation(), "_ret",