Changeset 34dcc474

Timestamp:

Apr 11, 2018, 4:24:06 PM (5 years ago)

Author:

Aaron Moss <a3moss@…>

Branches:

new-env, with_gc

Children:

09a1ae6

Parents:

9f2012f

Message:

Fix one GC tracing bug

Location:

src

Files:

• Common/GC.cc (modified) (3 diffs)
• SynTree/GcTracer.h (modified) (2 diffs)

src/Common/GC.cc

@@ -22 +22 @@
 #include <algorithm>
 #include <cassert>
+
+// #include <csignal>
 
 GC& GC::get() {
@@ -55 +57 @@
 
 void GC::register_object(GC_Object* obj) {
+        // if ( obj == (GC_Object*)0x60f00000e410ul ) std::raise( SIGTRAP );
         (using_young ? young : old).push_back(obj);
-        obj->mark = this->mark;
+        obj->mark = ! this->mark;  // initialize as un-marked
 }
 
@@ -105 +108 @@
         for ( GC_Object*& obj : old ) {
                 if ( obj->mark != mark ) {
+                        // if ( obj == (GC_Object*)0x60f00000e410ul ) std::raise( SIGTRAP );
                         delete obj;
                         obj = nullptr;

src/SynTree/GcTracer.h

@@ -34 +34 @@
         GcTracer( const GC& gc ) : gc(gc) {}
 
+        // mark node and children
+
         void previsit( BaseSyntaxNode * node ) {
                 // skip tree if already seen
@@ -45 +47 @@
         }
 
+        // add visits left out by PassVisitor
+
         void postvisit( Expression* expr ) {
                 maybeAccept( expr->env, *visitor );
+        }
+
+        void postvisit( UntypedExpr* expr ) {
+                postvisit( static_cast<Expression*>(expr) );
+                maybeAccept( expr->function, *visitor );
         }