Changes in src/AST/GenericSubstitution.cpp [60aaa51d:335f2d8]

File:

• src/AST/GenericSubstitution.cpp (modified) (2 diffs)

src/AST/GenericSubstitution.cpp

@@ -31 +31 @@
                 TypeSubstitution sub;
 
-                void previsit( const Type * ) {
-                        // allow empty substitution for non-generic type
-                        visit_children = false;
+                void previsit( const Type * ty ) {
+                        assertf( false, "Attempted generic substitution for non-aggregate type: %s",
+                                toString( ty ).c_str() );
                 }
 
@@ -40 +40 @@
                 }
 
-        private:
-                // make substitution for generic type
-                void makeSub( const ReferenceToType * ty ) {
+                void previsit( const ReferenceToType * ty ) {
                         visit_children = false;
+                        // build substitution from base parameters
                         const AggregateDecl * aggr = ty->aggr();
                         sub = TypeSubstitution{ aggr->params.begin(), aggr->params.end(), ty->params.begin() };
-                }
-
-        public:
-                void previsit( const StructInstType * ty ) {
-                        makeSub( ty );
-                }
-
-                void previsit( const UnionInstType * ty ) {
-                        makeSub( ty );
                 }
         };
 }
 
-TypeSubstitution genericSubstitution( const Type * ty ) {
+TypeSubstitution genericSubsitution( const Type * ty ) {
         Pass<GenericSubstitutionBuilder> builder;
         maybe_accept( ty, builder );