Changeset 3322180

Timestamp:

Jun 24, 2022, 12:12:26 PM (23 months ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, ast-experimental, master, pthread-emulation, qualifiedEnum

Children:

5a076837

Parents:

d28524a

Message:

Fix enum assignment warning

Files:

• src/GenPoly/Box.cc (modified) (1 diff)
• src/Validate/Autogen.cpp (modified) (2 diffs)
• tests/.expect/attributes.nast.arm64.txt (modified) (1 diff)
• tests/.expect/attributes.nast.x64.txt (modified) (1 diff)
• tests/.expect/attributes.nast.x86.txt (modified) (1 diff)
• tests/.expect/attributes.oast.x64.txt (modified) (1 diff)

src/GenPoly/Box.cc

@@ -1277 +1277 @@
                         FunctionType * ftype = functionDecl->type;
                         if ( ! ftype->returnVals.empty() && functionDecl->statements ) {
-                                if ( ! isPrefix( functionDecl->name, "_thunk" ) && ! isPrefix( functionDecl->name, "_adapter" ) ) { // xxx - remove check for prefix once thunks properly use ctor/dtors
+                                // intrinsic functions won't be using the _retval so no need to generate it.
+                                if ( functionDecl->linkage != LinkageSpec::Intrinsic && !isPrefix( functionDecl->name, "_thunk" ) && ! isPrefix( functionDecl->name, "_adapter" ) ) { // xxx - remove check for prefix once thunks properly use ctor/dtors
                                         assert( ftype->returnVals.size() == 1 );
                                         DeclarationWithType * retval = ftype->returnVals.front();

src/Validate/Autogen.cpp

@@ -183 +183 @@
         {
                 // TODO: These functions are somewhere between instrinsic and autogen,
-                // could possibly use a new linkage type. For now we just make them
-                // intrinsic to code-gen them as C assignments.
-                proto_linkage = ast::Linkage::Intrinsic;
+                // could possibly use a new linkage type. For now we just make the
+                // basic ones intrinsic to code-gen them as C assignments.
+                const auto & real_type = decl->base;
+                const auto & basic = real_type.as<ast::BasicType>();
+                if(!real_type || (basic && basic->isInteger())) proto_linkage = ast::Linkage::Intrinsic;
         }
 
@@ -402 +404 @@
         auto retval = srcParam();
         retval->name = "_ret";
-        // xxx - Adding this unused attribute can slience unused variable warning
-        // However, some code might not be compiled as expected
-        // Temporarily disabled
-        // retval->attributes.push_back(new ast::Attribute("unused"));
         return genProto( "?=?", { dstParam(), srcParam() }, { retval } );
 }

tests/.expect/attributes.nast.arm64.txt

@@ -1334 +1334 @@
     }
     inline enum __anonymous4 _X16_operator_assignFM12__anonymous4_M12__anonymous4M12__anonymous4_intrinsic___2(enum __anonymous4 *_X4_dstM12__anonymous4_2, enum __anonymous4 _X4_srcM12__anonymous4_2){
-        enum __anonymous4 _X4_retM12__anonymous4_2;
         {
             ((void)((*_X4_dstM12__anonymous4_2)=_X4_srcM12__anonymous4_2));

tests/.expect/attributes.nast.x64.txt

@@ -1334 +1334 @@
     }
     inline enum __anonymous4 _X16_operator_assignFM12__anonymous4_M12__anonymous4M12__anonymous4_intrinsic___2(enum __anonymous4 *_X4_dstM12__anonymous4_2, enum __anonymous4 _X4_srcM12__anonymous4_2){
-        enum __anonymous4 _X4_retM12__anonymous4_2;
         {
             ((void)((*_X4_dstM12__anonymous4_2)=_X4_srcM12__anonymous4_2));

tests/.expect/attributes.nast.x86.txt

@@ -1334 +1334 @@
     }
     inline enum __anonymous4 _X16_operator_assignFM12__anonymous4_M12__anonymous4M12__anonymous4_intrinsic___2(enum __anonymous4 *_X4_dstM12__anonymous4_2, enum __anonymous4 _X4_srcM12__anonymous4_2){
-        enum __anonymous4 _X4_retM12__anonymous4_2;
         {
             ((void)((*_X4_dstM12__anonymous4_2)=_X4_srcM12__anonymous4_2));

tests/.expect/attributes.oast.x64.txt

@@ -1334 +1334 @@
     }
     inline enum __anonymous4 _X16_operator_assignFM12__anonymous4_M12__anonymous4M12__anonymous4_intrinsic___2(enum __anonymous4 *_X4_dstM12__anonymous4_2, enum __anonymous4 _X4_srcM12__anonymous4_2){
-        enum __anonymous4 _X4_retM12__anonymous4_2;
         {
             ((void)((*_X4_dstM12__anonymous4_2)=_X4_srcM12__anonymous4_2));