Changeset 32a8b61

Timestamp:

Nov 23, 2020, 5:10:23 PM (4 years ago)

Author:

Thierry Delisle <tdelisle@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

0bb691b1

Parents:

b2e0df3

Message:

Tentative fix for the recurring crash, caching the current cluster to avoid re-reading for a pointer that could have been invalidated.

File:

• libcfa/src/concurrency/kernel.cfa (modified) (1 diff)

libcfa/src/concurrency/kernel.cfa

@@ -379 +379 @@
 
         ready_schedule_lock();
-                push( thrd->curr_cluster, thrd );
-                __wake_one(thrd->curr_cluster);
+                // Dereference the thread now because once we push it, there is not guaranteed it's still valid.
+                struct cluster * cl = thrd->curr_cluster;
+
+                // push the thread to the cluster ready-queue
+                push( cl, thrd );
+
+                // variable thrd is no longer safe to use
+
+                // wake the cluster using the save variable.
+                __wake_one( cl );
         ready_schedule_unlock();