Changeset 302ef2a

Timestamp:

Dec 22, 2020, 3:16:47 PM (4 years ago)

Author:

Fangren Yu <f37yu@…>

Branches:

ADT, arm-eh, ast-experimental, enum, forall-pointer-decay, jacob/cs343-translation, master, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

2daea42

Parents:

797a193

Message:

smart pointer memory safety

Location:

src

Files:

• AST/Node.hpp (modified) (1 diff)
• ResolvExpr/Resolver.cc (modified) (1 diff)
• ResolvExpr/Resolver.h (modified) (1 diff)
• ResolvExpr/Unify.cc (modified) (3 diffs)

src/AST/Node.hpp

@@ -229 +229 @@
         const node_t & operator* () const { _check(); return *node; }
         explicit operator bool() const { _check(); return node; }
-        operator const node_t * () const { _check(); return node; }
+        operator const node_t * () const & { _check(); return node; }
+        operator const node_t * () && = delete;
 
         const node_t * release() {

src/ResolvExpr/Resolver.cc

@@ -1311 +1311 @@
         }
 
-        ast::ptr< ast::Expr > resolveStmtExpr(
+        const ast::Expr * resolveStmtExpr(
                 const ast::StmtExpr * stmtExpr, const ast::SymbolTable & symtab
         ) {
                 assert( stmtExpr );
                 ast::Pass< Resolver_new > resolver{ symtab };
-                ast::ptr< ast::Expr > ret = stmtExpr;
-                ret = ret->accept( resolver );
-                strict_dynamic_cast< ast::StmtExpr * >( ret.get_and_mutate() )->computeResult();
+                auto ret = mutate(stmtExpr->accept(resolver));
+                strict_dynamic_cast< ast::StmtExpr * >( ret )->computeResult();
                 return ret;
         }

src/ResolvExpr/Resolver.h

@@ -72 +72 @@
         ast::ptr< ast::Init > resolveCtorInit(
                 const ast::ConstructorInit * ctorInit, const ast::SymbolTable & symtab );
-        /// Resolves a statement expression
-        ast::ptr< ast::Expr > resolveStmtExpr(
+        /// Resolves a statement expression 
+        const ast::Expr * resolveStmtExpr(
                 const ast::StmtExpr * stmtExpr, const ast::SymbolTable & symtab );
 } // namespace ResolvExpr

src/ResolvExpr/Unify.cc

@@ -811 +811 @@
                 /// Creates a tuple type based on a list of DeclWithType
                 template< typename Iter >
-                static ast::ptr< ast::Type > tupleFromTypes( Iter crnt, Iter end ) {
+                static const ast::Type * tupleFromTypes( Iter crnt, Iter end ) {
                         std::vector< ast::ptr< ast::Type > > types;
                         while ( crnt != end ) {
@@ -821 +821 @@
                         }
 
-                        return { new ast::TupleType{ std::move(types) } };
+                        return new ast::TupleType{ std::move(types) };
                 }
 
@@ -1034 +1034 @@
         private:
                 /// Creates a tuple type based on a list of Type
-                static ast::ptr< ast::Type > tupleFromTypes(
+                static const ast::Type * tupleFromTypes(
                         const std::vector< ast::ptr< ast::Type > > & tys
                 ) {