Changeset 2c04369 for src/SymTab

Timestamp:

May 28, 2019, 12:04:43 PM (7 years ago)

Author:

Andrew Beach <ajbeach@…>

Branches:

ADT, arm-eh, ast-experimental, cleanup-dtors, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, pthread-emulation, qualifiedEnum

Children:

0d70e0d

Parents:

a7d50b6

Message:

Fixed some problems in convert. One of which was better solved by removing the FindSpecialDeclarations hack.

Location:

src/SymTab

Files:

• Autogen.h (modified) (2 diffs)
• Validate.cc (modified) (5 diffs)

src/SymTab/Autogen.h

@@ -9 +9 @@
 // Author           : Rob Schluntz
 // Created On       : Sun May 17 21:53:34 2015
-// Last Modified By : Peter A. Buhr
-// Last Modified On : Sat Jul 22 09:50:25 2017
-// Update Count     : 15
+// Last Modified By : Andrew Beach
+// Last Modified On : Tue May 28 11:04:00 2019
+// Update Count     : 16
 //
 
@@ -40 +40 @@
         /// such as in determining array dimension type
         extern Type * SizeType;
-
-        /// intrinsic dereference operator for unqualified types - set when *? function is seen in FindSpecialDeclarations.
-        /// Useful for creating dereference ApplicationExprs without a full resolver pass.
-        extern FunctionDecl * dereferenceOperator;
 
         // generate the type of an assignment function for paramType

src/SymTab/Validate.cc

@@ -9 +9 @@
 // Author           : Richard C. Bilson
 // Created On       : Sun May 17 21:50:04 2015
-// Last Modified By : Peter A. Buhr
-// Last Modified On : Mon Aug 28 13:47:23 2017
-// Update Count     : 359
+// Last Modified By : Andrew Beach
+// Last Modified On : Tue May 28 11:07:00 2019
+// Update Count     : 360
 //
 
@@ -288 +288 @@
         };
 
-        FunctionDecl * dereferenceOperator = nullptr;
-        struct FindSpecialDeclarations final {
-                void previsit( FunctionDecl * funcDecl );
-        };
-
         void validate( std::list< Declaration * > &translationUnit, __attribute__((unused)) bool doDebug ) {
                 PassVisitor<EnumAndPointerDecay> epc;
@@ -299 +294 @@
                 PassVisitor<CompoundLiteral> compoundliteral;
                 PassVisitor<ValidateGenericParameters> genericParams;
-                PassVisitor<FindSpecialDeclarations> finder;
                 PassVisitor<LabelAddressFixer> labelAddrFixer;
                 PassVisitor<HoistTypeDecls> hoistDecls;
@@ -376 +370 @@
                         Stats::Time::TimeBlock("Array Length", [&]() {
                                 ArrayLength::computeLength( translationUnit );
-                        });
-                        Stats::Time::TimeBlock("Find Special Declarations", [&]() {
-                                acceptAll( translationUnit, finder ); // xxx - remove this pass soon
                         });
                         Stats::Time::TimeBlock("Fix Label Address", [&]() {
@@ -1372 +1363 @@
                 return addrExpr;
         }
-
-        void FindSpecialDeclarations::previsit( FunctionDecl * funcDecl ) {
-                if ( ! dereferenceOperator ) {
-                        if ( funcDecl->get_name() == "*?" && funcDecl->get_linkage() == LinkageSpec::Intrinsic ) {
-                                FunctionType * ftype = funcDecl->get_functionType();
-                                if ( ftype->get_parameters().size() == 1 && ftype->get_parameters().front()->get_type()->get_qualifiers() == Type::Qualifiers() ) {
-                                        dereferenceOperator = funcDecl;
-                                }
-                        }
-                }
-        }
 } // namespace SymTab