Changeset 2ae16219 for src/Common

Timestamp:

Apr 19, 2018, 11:04:47 AM (6 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, with_gc

Children:

c28bcc7

Parents:

b2da0574 (diff), 61323a7 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge branch 'master' of plg.uwaterloo.ca:/u/cforall/software/cfa/cfa-cc

Location:

src/Common

Files:

• SemanticError.cc (modified) (1 diff)
• SemanticError.h (modified) (2 diffs)

src/Common/SemanticError.cc

@@ -68 +68 @@
 }
 
-void SemanticWarningImpl( CodeLocation location, Warning, const char * const fmt, ... ) {
-        va_list args;
-        va_start(args, fmt);
-        std::string msg = fmtToString( fmt, args );
-        va_end(args);
-        std::cerr << ErrorHelpers::bold() << location << ErrorHelpers::warning_str() << ErrorHelpers::reset_font() << msg << std::endl;
+void SemanticWarningImpl( CodeLocation location, Warning warning, const char * const fmt, ... ) {
+        Severity severity = WarningFormats[(int)warning].severity;
+        switch(severity) {
+        case Severity::Suppress :
+                break;
+        case Severity::Warn :
+                {
+                        va_list args;
+                        va_start(args, fmt);
+                        std::string msg = fmtToString( fmt, args );
+                        va_end(args);
+                        std::cerr << ErrorHelpers::bold() << location << ErrorHelpers::warning_str() << ErrorHelpers::reset_font() << msg << std::endl;
+                }
+                break;
+        case Severity::Error :
+                {
+                        va_list args;
+                        va_start(args, fmt);
+                        std::string msg = fmtToString( fmt, args );
+                        va_end(args);
+                        SemanticError(location, msg);
+                }
+                break;
+        case Severity::Critical :
+                assertf(false, "Critical errors not implemented yet");
+                break;
+        }
 }
 

src/Common/SemanticError.h

@@ -36 +36 @@
 // Warnings
 
-constexpr const char * const WarningFormats[] = {
-        "self assignment of expression: %s",
-        "rvalue to reference conversion of rvalue: %s",
+enum class Severity {
+        Suppress,
+        Warn,
+        Error,
+        Critical
+};
+
+struct WarningData {
+        const char * const name;
+        const char * const message;
+        mutable Severity severity;
+};
+
+constexpr const WarningData WarningFormats[] = {
+        {"self-assign"         , "self assignment of expression: %s"           , Severity::Warn},
+        {"reference-conversion", "rvalue to reference conversion of rvalue: %s", Severity::Warn},
 };
 
@@ -52 +65 @@
 );
 
-// ## used here to allow empty __VA_ARGS__
-#define SemanticWarning(loc, id, ...) SemanticWarningImpl(loc, id, WarningFormats[(int)id], ## __VA_ARGS__)
+#define SemanticWarning(loc, id, ...) SemanticWarningImpl(loc, id, WarningFormats[(int)id].message, __VA_ARGS__)
 
 void SemanticWarningImpl (CodeLocation loc, Warning warn, const char * const fmt, ...) __attribute__((format(printf, 3, 4)));