Changes in src/AST/Convert.cpp [0b57626:20a5977]

File:

• src/AST/Convert.cpp (modified) (1 diff)

src/AST/Convert.cpp

@@ -700 +700 @@
         }
 
-        bool isIntlikeConstantType(const ast::Type *t) {
-                if ( const ast::BasicType * basicType = dynamic_cast< const ast::BasicType * >( t ) ) {
-                        if ( basicType->isInteger() ) {
-                                return true;
-                        }
-                } else if ( dynamic_cast< const ast::OneType * >( t ) ) {
-                        return true;
-                } else if ( dynamic_cast< const ast::ZeroType * >( t ) ) {
-                        return true;
-                } else if ( dynamic_cast< const ast::PointerType * >( t ) ) {
-                        // null pointer constants, with zero int-values
-                        return true;
-                }
-                return false;
-        }
-
-        bool isFloatlikeConstantType(const ast::Type *t) {
-                if ( const ast::BasicType * bty = dynamic_cast< const ast::BasicType * >( t ) ) {
-                        if ( ! bty->isInteger() ) {
-                                return true;
-                        }
-                }
-                return false;
-        }
-
-        bool isStringlikeConstantType(const ast::Type *t) {
-                if ( const ast::ArrayType * aty = dynamic_cast< const ast::ArrayType * >( t ) ) {
-                        if ( const ast::BasicType * bty = aty->base.as<ast::BasicType>() ) {
-                           if ( bty->kind == ast::BasicType::Kind::Char ) {
-                                   return true;
-                           }
-                        }
-                }
-                return false;
-        }
-
         const ast::Expr * visit( const ast::ConstantExpr * node ) override final {
                 ConstantExpr *rslt = nullptr;
-                if (isIntlikeConstantType(node->result)) {
-                        rslt = new ConstantExpr(Constant(
-                                get<Type>().accept1(node->result),
+                switch ( node->kind ) {
+                case ast::ConstantExpr::Integer:
+                        rslt = new ConstantExpr{Constant{
+                                get<Type>().accept1( node->result ),
                                 node->rep,
                                 (unsigned long long) node->intValue()
-                        ));
-                } else if (isFloatlikeConstantType(node->result)) {
-                        rslt = new ConstantExpr(Constant(
+                        }};
+                        break;
+                case ast::ConstantExpr::FloatingPoint:
+                        rslt = new ConstantExpr{Constant{
                                 get<Type>().accept1(node->result),
                                 node->rep,
                                 (double) node->floatValue()
-                        ));
-                } else if (isStringlikeConstantType(node->result)) {
-                        rslt = new ConstantExpr(Constant::from_string(
-                                node->rep
-                        ));
+                        }};
+                        break;
+                case ast::ConstantExpr::String:
+                        rslt = new ConstantExpr{Constant::from_string( node->rep )};
+                        break;
                 }
                 assert(rslt);