Changeset 1f370451 for src

Timestamp:

Nov 27, 2017, 2:38:37 PM (7 years ago)

Author:

Rob Schluntz <rschlunt@…>

Branches:

ADT, aaron-thesis, arm-eh, ast-experimental, cleanup-dtors, deferred_resn, demangler, enum, forall-pointer-decay, jacob/cs343-translation, jenkins-sandbox, master, new-ast, new-ast-unique-expr, new-env, no_list, persistent-indexer, pthread-emulation, qualifiedEnum, resolv-new, with_gc

Children:

c029f4d

Parents:

a7caf3d

Message:

Carry attributes through typedefs

Location:

src

Files:

• GenPoly/Box.cc (modified) (1 diff)
• Parser/TypeData.cc (modified) (3 diffs)
• SymTab/Autogen.cc (modified) (2 diffs)
• SymTab/Validate.cc (modified) (4 diffs)
• tests/polymorphism.c (modified) (1 diff)

src/GenPoly/Box.cc

@@ -855 +855 @@
                         DeclarationWithType *adapteeDecl = adapterType->get_parameters().front();
                         adapteeDecl->set_name( "_adaptee" );
+                        // do not carry over attributes to real type parameters/return values
+                        for ( DeclarationWithType * dwt : realType->parameters ) {
+                                deleteAll( dwt->get_type()->attributes );
+                                dwt->get_type()->attributes.clear();
+                        }
+                        for ( DeclarationWithType * dwt : realType->returnVals ) {
+                                deleteAll( dwt->get_type()->attributes );
+                                dwt->get_type()->attributes.clear();
+                        }
                         ApplicationExpr *adapteeApp = new ApplicationExpr( new CastExpr( new VariableExpr( adapteeDecl ), new PointerType( Type::Qualifiers(), realType ) ) );
                         Statement *bodyStmt;

src/Parser/TypeData.cc

@@ -792 +792 @@
 
 
-NamedTypeDecl * buildSymbolic( const TypeData * td, const string & name, Type::StorageClasses scs, LinkageSpec::Spec linkage ) {
+NamedTypeDecl * buildSymbolic( const TypeData * td, std::list< Attribute * > attributes, const string & name, Type::StorageClasses scs, LinkageSpec::Spec linkage ) {
         assert( td->kind == TypeData::Symbolic );
         NamedTypeDecl * ret;
@@ -803 +803 @@
         buildList( td->symbolic.params, ret->get_parameters() );
         buildList( td->symbolic.assertions, ret->get_assertions() );
+        ret->base->attributes.splice( ret->base->attributes.end(), attributes );
         return ret;
 } // buildSymbolic
@@ -866 +867 @@
                 return buildEnum( td, attributes, linkage );
         } else if ( td->kind == TypeData::Symbolic ) {
-                return buildSymbolic( td, name, scs, linkage );
+                return buildSymbolic( td, attributes, name, scs, linkage );
         } else {
                 return (new ObjectDecl( name, scs, linkage, bitfieldWidth, typebuild( td ), init, attributes ))->set_asmName( asmName );

src/SymTab/Autogen.cc

@@ -372 +372 @@
                                 continue;
                         }
-                        memCtorType->parameters.push_back( new ObjectDecl( field->name, Type::StorageClasses(), LinkageSpec::Cforall, 0, field->get_type()->clone(), 0 ) );
+                        // do not carry over field's attributes to parameter type
+                        Type * paramType = field->get_type()->clone();
+                        deleteAll( paramType->attributes );
+                        paramType->attributes.clear();
+                        // add a parameter corresponding to this field
+                        memCtorType->parameters.push_back( new ObjectDecl( field->name, Type::StorageClasses(), LinkageSpec::Cforall, nullptr, paramType, nullptr ) );
                         FunctionDecl * ctor = genFunc( "?{}", memCtorType->clone(), functionNesting );
                         makeFieldCtorBody( aggregateDecl->members.begin(), aggregateDecl->members.end(), ctor );
@@ -503 +508 @@
                                 break;
                         }
-                        memCtorType->parameters.push_back( new ObjectDecl( field->name, Type::StorageClasses(), LinkageSpec::Cforall, nullptr, field->get_type()->clone(), nullptr ) );
+                        // do not carry over field's attributes to parameter type
+                        Type * paramType = field->get_type()->clone();
+                        deleteAll( paramType->attributes );
+                        paramType->attributes.clear();
+                        // add a parameter corresponding to this field
+                        memCtorType->parameters.push_back( new ObjectDecl( field->name, Type::StorageClasses(), LinkageSpec::Cforall, nullptr, paramType, nullptr ) );
                         FunctionDecl * ctor = genFunc( "?{}", memCtorType->clone(), functionNesting );
                         ObjectDecl * srcParam = strict_dynamic_cast<ObjectDecl *>( ctor->type->parameters.back() );

src/SymTab/Validate.cc

@@ -201 +201 @@
                 Declaration * postmutate( TraitDecl * contextDecl );
 
+                void premutate( FunctionType * ftype );
+
           private:
                 template<typename AggDecl>
@@ -214 +216 @@
                 TypeDeclMap typedeclNames;
                 int scopeLevel;
+                bool inFunctionType = false;
         };
 
@@ -725 +728 @@
                         Type *ret = def->second.first->base->clone();
                         ret->get_qualifiers() |= typeInst->get_qualifiers();
+                        // attributes are not carried over from typedef to function parameters/return values
+                        if ( ! inFunctionType ) {
+                                ret->attributes.splice( ret->attributes.end(), typeInst->attributes );
+                        } else {
+                                deleteAll( ret->attributes );
+                                ret->attributes.clear();
+                        }
                         // place instance parameters on the typedef'd type
                         if ( ! typeInst->parameters.empty() ) {
@@ -901 +911 @@
         Declaration *EliminateTypedef::postmutate( TraitDecl * traitDecl ) {
                 return handleAggregate( traitDecl );
+        }
+
+        void EliminateTypedef::premutate( FunctionType * ) {
+                GuardValue( inFunctionType );
+                inFunctionType = true;
         }
 

src/tests/polymorphism.c

@@ -89 +89 @@
                 // ensure that the size of aggregates with polymorphic members
                 // matches the size of the aggregates in a monomorphic context
-                assertf( struct_size(x, y) == sizeof(S), "struct size differs in polymorphic context." );
-                assertf( union_size(x, y) == sizeof(U), "union size differs in polymorphic context." );
+                size_t ssz = struct_size(x, y);
+                size_t usz = union_size(x, y);
+                assertf( ssz == sizeof(S), "struct size differs in polymorphic context: %zd / %zd", ssz, sizeof(S));
+                assertf( usz == sizeof(U), "union size differs in polymorphic context: %zd / %zd", usz, sizeof(U));
 
                 y_type ?=?(y_type & this, zero_t) {